inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-07 17:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merged V3.4-BUG-FIX to HEAD

Browse Source 
32229: Fix for ALF-11247 - Browsing in Alfresco Explorer leads to memory leaks and eventual IllegalStateException

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@32230 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Kevin Roast
2011-11-23 11:46:28 +00:00
parent 90c9f141ad
commit 64e0dc6bbc
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
source/java/org/alfresco/web/ui/repo/component/UIActions.java
View File

@@ -103,6 +103,10 @@ public class UIActions extends SelfRenderingComponent
this.showLink = (Boolean)values[2]; this.showLink = (Boolean)values[2];
this.verticalSpacing = (Integer)values[3]; this.verticalSpacing = (Integer)values[3];
this.groups = new HashSet<String>(4); this.groups = new HashSet<String>(4);
// when the state of the component is restored, clear the child list of components - they
// are always rebuilt on initial page render - otherwise the list will grow forever...
this.getChildren().clear();
} }
/** /**
@@ -139,7 +143,7 @@ public class UIActions extends SelfRenderingComponent
if (actionContext instanceof Node) if (actionContext instanceof Node)
{ {
contextId = ((Node)actionContext).getType().toString(); contextId = ((Node)actionContext).getType().toString();
if (groups.contains(contextId)) if (this.groups.contains(contextId))
{ {
if (logger.isDebugEnabled()) if (logger.isDebugEnabled())
logger.debug("---already built component tree for actions contextId: " + contextId); logger.debug("---already built component tree for actions contextId: " + contextId);
@@ -149,7 +153,7 @@ public class UIActions extends SelfRenderingComponent
else else
{ {
contextId = CONTEXTID_DEFAULT; contextId = CONTEXTID_DEFAULT;
if (groups.contains(contextId)) if (this.groups.contains(contextId))
{ {
if (logger.isDebugEnabled()) if (logger.isDebugEnabled())
logger.debug("---already built component tree for default actions."); logger.debug("---already built component tree for default actions.");
@@ -292,6 +296,8 @@ public class UIActions extends SelfRenderingComponent
wrapper.setId(createUniqueId()); wrapper.setId(createUniqueId());
wrapper.getAttributes().put("contextId", contextId); wrapper.getAttributes().put("contextId", contextId);
this.getChildren().add(wrapper); this.getChildren().add(wrapper);
if (logger.isDebugEnabled())
logger.debug("UIActions id: " + this.getId() + " Children() structure size: " + this.getChildren().size());
this.groups.add(contextId); this.groups.add(contextId);
// process each ActionDefinition in the order they were defined // process each ActionDefinition in the order they were defined
@@ -640,6 +646,8 @@ public class UIActions extends SelfRenderingComponent
public void reset() public void reset()
{ {
// clear any child components and reset the list of groups // clear any child components and reset the list of groups
if (logger.isDebugEnabled())
logger.debug("UIActions id: " + this.getId() + "reset() - clearing component child list.");
this.getChildren().clear(); this.getChildren().clear();
this.groups.clear(); this.groups.clear();
} }
@@ -655,7 +663,7 @@ public class UIActions extends SelfRenderingComponent
} }
catch (UnsupportedEncodingException e) catch (UnsupportedEncodingException e)
{ {
throw new RuntimeException(e); throw new RuntimeException(e);
} }
} }