Collapsed test methods to avoid ordering issues

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@42014 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Kevin Roast
2012-09-26 09:29:05 +00:00
parent ec8a54d69d
commit 6609ccaab5
2 changed files with 77 additions and 74 deletions

View File

@@ -123,7 +123,8 @@ public class OAuth1CredentialsStoreServiceTest
} }
@Test (expected=AccessDeniedException.class) @Test (expected=AccessDeniedException.class)
public void testSecureUpdateSharedOAuth1Credentials() public void testSecureUpdateSharedOAuth1CredentialsTestUpdateSharedOAuth1Credentials()
{
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_TWO); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_TWO);
//Update credentials //Update credentials
@@ -132,8 +133,7 @@ public class OAuth1CredentialsStoreServiceTest
oauth1CredentialsStoreService.updateSharedOAuth1Credentials(oAuth1CredentialsInfo, RemoteSystemId, UpdatedToken, UpdatedSecret); oauth1CredentialsStoreService.updateSharedOAuth1Credentials(oAuth1CredentialsInfo, RemoteSystemId, UpdatedToken, UpdatedSecret);
} }
@Test //public void testUpdateSharedOAuth1Credentials()
public void testUpdateSharedOAuth1Credentials()
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE);
//Update credentials //Update credentials
@@ -144,6 +144,7 @@ public class OAuth1CredentialsStoreServiceTest
assertEquals("Expect that access tokens will match", UpdatedToken, _oAuth1CredentialsInfo.getOAuthToken()); assertEquals("Expect that access tokens will match", UpdatedToken, _oAuth1CredentialsInfo.getOAuthToken());
assertEquals("Expect the refresh token will match", UpdatedSecret, _oAuth1CredentialsInfo.getOAuthSecret()); assertEquals("Expect the refresh token will match", UpdatedSecret, _oAuth1CredentialsInfo.getOAuthSecret());
} }
}
@Test @Test
public void testDeletePesonalOAuth1Credentials() public void testDeletePesonalOAuth1Credentials()
@@ -160,16 +161,15 @@ public class OAuth1CredentialsStoreServiceTest
} }
@Test(expected=AccessDeniedException.class) @Test(expected=AccessDeniedException.class)
public void testSecureDeleteSharedOAuth1Credentials() public void testSecureDeleteSharedOAuth1CredentialsTestDeleteSharedOAuth1Credentials()
{
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_TWO); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_TWO);
List<OAuth1CredentialsInfo> sharedCredentials = oauth1CredentialsStoreService.listSharedOAuth1Credentials(RemoteSystemId); List<OAuth1CredentialsInfo> sharedCredentials = oauth1CredentialsStoreService.listSharedOAuth1Credentials(RemoteSystemId);
OAuth1CredentialsInfo oAuth1CredentialsInfo = sharedCredentials.get(0); OAuth1CredentialsInfo oAuth1CredentialsInfo = sharedCredentials.get(0);
oauth1CredentialsStoreService.deleteSharedOAuth1Credentials(RemoteSystemId, oAuth1CredentialsInfo); oauth1CredentialsStoreService.deleteSharedOAuth1Credentials(RemoteSystemId, oAuth1CredentialsInfo);
} }
//public void testDeleteSharedOAuth1Credentials()
@Test
public void testDeleteSharedOAuth1Credentials()
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE);
List<OAuth1CredentialsInfo> sharedCredentials = oauth1CredentialsStoreService.listSharedOAuth1Credentials(RemoteSystemId); List<OAuth1CredentialsInfo> sharedCredentials = oauth1CredentialsStoreService.listSharedOAuth1Credentials(RemoteSystemId);
@@ -178,6 +178,7 @@ public class OAuth1CredentialsStoreServiceTest
assertTrue(deleted); assertTrue(deleted);
} }
}
// -------------------------------------------------------------------------------- // --------------------------------------------------------------------------------

View File

@@ -146,7 +146,8 @@ public class OAuth2CredentialsStoreServiceTest
} }
@Test @Test
public void testUpdateSharedOAuth2Credentials() public void testUpdateSharedOAuth2CredentialsTestDeletePesonalOAuth2Credentials()
{
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE);
//Update credentials //Update credentials
@@ -160,8 +161,7 @@ public class OAuth2CredentialsStoreServiceTest
assertEquals("Expect that the issued date will match", UpdatedIssuedAt, _oAuth2CredentialsInfo.getOAuthTicketIssuedAt()); assertEquals("Expect that the issued date will match", UpdatedIssuedAt, _oAuth2CredentialsInfo.getOAuthTicketIssuedAt());
} }
@Test //public void testDeletePesonalOAuth2Credentials()
public void testDeletePesonalOAuth2Credentials()
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE);
boolean deleted = oauth2CredentialsStoreService.deletePersonalOAuth2Credentials(RemoteSystemId); boolean deleted = oauth2CredentialsStoreService.deletePersonalOAuth2Credentials(RemoteSystemId);
@@ -173,9 +173,11 @@ public class OAuth2CredentialsStoreServiceTest
assertFalse(_deleted); assertFalse(_deleted);
} }
}
@Test(expected=AccessDeniedException.class) @Test(expected=AccessDeniedException.class)
public void testSecureDeleteSharedOAuth2Credentials() public void testSecureDeleteSharedOAuth2CredentialsTestDeleteSharedOAuth2Credentials()
{
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_TWO); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_TWO);
List<OAuth2CredentialsInfo> sharedCredentials = oauth2CredentialsStoreService.listSharedOAuth2Credentials(RemoteSystemId); List<OAuth2CredentialsInfo> sharedCredentials = oauth2CredentialsStoreService.listSharedOAuth2Credentials(RemoteSystemId);
@@ -183,8 +185,7 @@ public class OAuth2CredentialsStoreServiceTest
oauth2CredentialsStoreService.deleteSharedOAuth2Credentials(RemoteSystemId, oAuth2CredentialsInfo); oauth2CredentialsStoreService.deleteSharedOAuth2Credentials(RemoteSystemId, oAuth2CredentialsInfo);
} }
@Test //public void testDeleteSharedOAuth2Credentials()
public void testDeleteSharedOAuth2Credentials()
{ {
AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE); AuthenticationUtil.setFullyAuthenticatedUser(TEST_USER_ONE);
List<OAuth2CredentialsInfo> sharedCredentials = oauth2CredentialsStoreService.listSharedOAuth2Credentials(RemoteSystemId); List<OAuth2CredentialsInfo> sharedCredentials = oauth2CredentialsStoreService.listSharedOAuth2Credentials(RemoteSystemId);
@@ -193,6 +194,7 @@ public class OAuth2CredentialsStoreServiceTest
assertTrue(deleted); assertTrue(deleted);
} }
}
// -------------------------------------------------------------------------------- // --------------------------------------------------------------------------------