From 684ba6a6bd5742c6f877cb0bf3bb103cd563b79a Mon Sep 17 00:00:00 2001 From: Tuna Aksoy Date: Sat, 1 Nov 2014 18:23:30 +0000 Subject: [PATCH] Fixed critical issues (Dodgy - instanceof will always return true) reported in Sonar git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@89714 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261 --- .../relationship/RelationshipServiceImpl.java | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/relationship/RelationshipServiceImpl.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/relationship/RelationshipServiceImpl.java index ba7b3964a2..8c7d71b176 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/relationship/RelationshipServiceImpl.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/relationship/RelationshipServiceImpl.java @@ -557,17 +557,9 @@ public class RelationshipServiceImpl extends RecordsManagementAdminBase implemen { type = RelationshipType.PARENTCHILD; } - else if (associationDefinition instanceof AssociationDefinition) - { - type = RelationshipType.BIDIRECTIONAL; - } else { - StringBuilder sb = new StringBuilder(); - sb.append("Unsupported association definition: '") - .append(associationDefinition.getName().getLocalName()) - .append("'."); - throw new AlfrescoRuntimeException(sb.toString()); + type = RelationshipType.BIDIRECTIONAL; } return type;