diff --git a/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneConjunction.java b/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneConjunction.java index 6af5fad2c3..5465d335ca 100644 --- a/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneConjunction.java +++ b/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneConjunction.java @@ -58,10 +58,9 @@ public class LuceneConjunction extends BaseConjunctio public Q addComponent(Set selectors, Map functionArgs, QueryBuilderContext luceneContext, FunctionEvaluationContext functionContext) throws E { - QueryParserExpressionAdaptor expressionAdaptor = luceneContext.getLuceneQueryParserAdaptor().getExpressionAdaptor(); boolean must = false; - boolean must_not = false; + boolean mustNot = false; for (Constraint constraint : getConstraints()) { if (constraint instanceof LuceneQueryBuilderComponent) @@ -84,23 +83,20 @@ public class LuceneConjunction extends BaseConjunctio break; case EXCLUDE: expressionAdaptor.addExcluded(constraintQuery, constraint.getBoost()); - must_not = true; + mustNot = true; break; } - } } else { throw new UnsupportedOperationException(); } - if(!must && must_not) - { - expressionAdaptor.addRequired(luceneContext.getLuceneQueryParserAdaptor().getMatchAllNodesQuery()); - } + } + if(!must && mustNot) + { + expressionAdaptor.addRequired(luceneContext.getLuceneQueryParserAdaptor().getMatchAllNodesQuery()); } return expressionAdaptor.getQuery(); - } - } diff --git a/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneQuery.java b/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneQuery.java index 56edddc0e7..2d238fcbad 100644 --- a/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneQuery.java +++ b/data-model/src/main/java/org/alfresco/repo/search/impl/querymodel/impl/lucene/LuceneQuery.java @@ -40,12 +40,10 @@ import org.alfresco.repo.search.impl.querymodel.PropertyArgument; import org.alfresco.repo.search.impl.querymodel.Selector; import org.alfresco.repo.search.impl.querymodel.Source; import org.alfresco.repo.search.impl.querymodel.impl.BaseQuery; -import org.alfresco.repo.search.impl.querymodel.impl.SimpleConstraint; import org.alfresco.repo.search.impl.querymodel.impl.functions.PropertyAccessor; import org.alfresco.repo.search.impl.querymodel.impl.functions.Score; import org.alfresco.service.cmr.search.SearchParameters.SortDefinition; import org.alfresco.service.cmr.search.SearchParameters.SortDefinition.SortType; -import org.alfresco.util.Pair; /** * @author andyh @@ -72,10 +70,8 @@ public class LuceneQuery extends BaseQuery implements QueryParserExpressionAdaptor expressionBuilder = luceneContext.getLuceneQueryParserAdaptor().getExpressionAdaptor(); boolean must = false; - boolean must_not = false; + boolean mustNot = false; - ArrayList> queriestoConjoin = new ArrayList<>(); - if (selectors != null) { for (String selector : selectors) @@ -86,7 +82,6 @@ public class LuceneQuery extends BaseQuery implements @SuppressWarnings("unchecked") LuceneQueryBuilderComponent luceneQueryBuilderComponent = (LuceneQueryBuilderComponent) current; Q selectorQuery = luceneQueryBuilderComponent.addComponent(selectors, null, luceneContext, functionContext); - queriestoConjoin.add(new Pair(new SimpleConstraint(org.alfresco.repo.search.impl.querymodel.Constraint.Occur.MANDATORY), selectorQuery)); if (selectorQuery != null) { expressionBuilder.addRequired(selectorQuery); @@ -108,8 +103,7 @@ public class LuceneQuery extends BaseQuery implements @SuppressWarnings("unchecked") LuceneQueryBuilderComponent luceneQueryBuilderComponent = (LuceneQueryBuilderComponent) constraint; Q constraintQuery = luceneQueryBuilderComponent.addComponent(selectors, null, luceneContext, functionContext); - queriestoConjoin.add(new Pair(constraint, constraintQuery)); - + if (constraintQuery != null) { switch (constraint.getOccur()) @@ -124,7 +118,7 @@ public class LuceneQuery extends BaseQuery implements break; case EXCLUDE: expressionBuilder.addExcluded(constraintQuery, constraint.getBoost()); - must_not = true; + mustNot = true; break; } } @@ -135,13 +129,12 @@ public class LuceneQuery extends BaseQuery implements } } - if (!must && must_not) + if (!must && mustNot) { expressionBuilder.addRequired(luceneContext.getLuceneQueryParserAdaptor().getMatchAllNodesQuery()); } return expressionBuilder.getQuery(); - } /* @@ -165,10 +158,10 @@ public class LuceneQuery extends BaseQuery implements { if ((getOrderings() == null) || (getOrderings().size() == 0)) { - return Collections.emptyList(); + return Collections.emptyList(); } - ArrayList definitions = new ArrayList(getOrderings().size()); + List definitions = new ArrayList<>(getOrderings().size()); for (Ordering ordering : getOrderings()) {