diff --git a/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/base/BaseRestTest.java b/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/base/BaseRestTest.java index 86d25ac5ac..88c3426586 100644 --- a/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/base/BaseRestTest.java +++ b/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/base/BaseRestTest.java @@ -49,6 +49,7 @@ import org.alfresco.rest.rm.community.requests.FilePlanComponentAPI; import org.alfresco.rest.rm.community.requests.RMSiteAPI; import org.alfresco.utility.constants.UserRole; import org.alfresco.utility.data.DataUser; +import org.alfresco.utility.model.SiteModel; import org.alfresco.utility.model.UserModel; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Value; @@ -230,28 +231,21 @@ public class BaseRestTest extends RestTest public UserModel createRMUserWithRole(String userName, UserRole userRole) throws Exception { rmSiteAPI.usingRestWrapper().authenticateUser(dataUser.getAdminUser()); - String siteId = rmSiteAPI.getSite().getId(); - logger.info("Site:" + rmSiteAPI.getSite() + " id: " + siteId); // check if user exists UserModel user = new UserModel(); user.setUsername(userName); user.setPassword(userName); - rmSiteAPI.usingRestWrapper().withCoreAPI().usingSite(siteId).getSiteMember(user); - - if (rmSiteAPI.usingRestWrapper().getStatusCode().equals(HttpStatus.NOT_FOUND.toString())) + + if (!dataUser.isUserInRepo(userName)) { // user doesn't exist, create it - logger.info("user doesn't exist, creating"); - user = dataUser.createUser(userName, userName); user.setUserRole(userRole); - - rmSiteAPI.usingRestWrapper().withCoreAPI().usingSite(siteId).addPerson(user); - rmSiteAPI.usingRestWrapper().assertStatusCodeIs(HttpStatus.CREATED); + + dataUser.addUserToSite(user, new SiteModel(siteId), userRole); } - logger.info("returning existing user"); return user; } diff --git a/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/fileplancomponents/NonElectronicRecordTests.java b/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/fileplancomponents/NonElectronicRecordTests.java index 6848d39ba9..c556821f73 100644 --- a/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/fileplancomponents/NonElectronicRecordTests.java +++ b/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/fileplancomponents/NonElectronicRecordTests.java @@ -39,6 +39,7 @@ import static org.alfresco.rest.rm.community.util.PojoUtility.toJson; import static org.alfresco.utility.data.RandomData.getRandomAlphanumeric; import static org.springframework.http.HttpStatus.BAD_REQUEST; import static org.springframework.http.HttpStatus.CREATED; +import static org.springframework.http.HttpStatus.FORBIDDEN; import static org.springframework.http.HttpStatus.NOT_FOUND; import static org.springframework.http.HttpStatus.UNPROCESSABLE_ENTITY; import static org.testng.Assert.assertEquals; @@ -348,8 +349,8 @@ public class NonElectronicRecordTests extends BaseRestTest { } - // user who isn't an RM site member can't access the container path, hence NOT_FOUND - filePlanComponentAPI.usingRestWrapper().assertStatusCodeIs(NOT_FOUND); + // user who isn't an RM site member can't access the container path + filePlanComponentAPI.usingRestWrapper().assertStatusCodeIs(FORBIDDEN); } /**