From 6e31f713f0e11d1eb556188b6eb0059f2395f612 Mon Sep 17 00:00:00 2001 From: Tom Page Date: Thu, 20 Oct 2022 14:00:14 +0100 Subject: [PATCH] ACS-3652 Script node validation. (#1507) * ACS-3652 Add validation for individual actions. In particular write access is required for the folder specified in the copy and move actions. * ACS-3652: Adding action validations for node permissions. * ACS-3652: Fixing failing E2E tests. * ACS-3652: Adding E2E tests. * ACS-3652: Adding E2E tests. * ACS-3652 E2E tests for script validation. * ACS-3652 Fix script validation test to use admin. * ACS-3652: Removing unnecessary code. * ACS-3652 E2Es for link to category action. * ACS-3652 Fix test case for normal user using script in rule. * ACS-3652: Adding applicable action definition check. * ACS-3652: Adding more thorough action definition checks and fixing node permission and type checks. * ACS-3652: Adding more thorough E2E tests and some fixes. * ACS-3652: Adding more E2E tests and some fixes. * ACS-3652: Fixing some missing corner cases, adding tests. * ACS-3652: Small refactoring after code review. Co-authored-by: mpichura --- .../test/java/org/alfresco/rest/rules/CreateRulesTests.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packaging/tests/tas-restapi/src/test/java/org/alfresco/rest/rules/CreateRulesTests.java b/packaging/tests/tas-restapi/src/test/java/org/alfresco/rest/rules/CreateRulesTests.java index cfdb0378ef..a2880dbdc9 100644 --- a/packaging/tests/tas-restapi/src/test/java/org/alfresco/rest/rules/CreateRulesTests.java +++ b/packaging/tests/tas-restapi/src/test/java/org/alfresco/rest/rules/CreateRulesTests.java @@ -712,17 +712,17 @@ public class CreateRulesTests extends RestTest } /** - * Check the admin user can create a rule with a script. + * Check the user can create a rule with a script. */ @Test (groups = { TestGroup.REST_API, TestGroup.RULES }) - public void checkAdminCanUseScriptInRule() + public void checkCanUseScriptInRule() { RestRuleModel ruleModel = rulesUtils.createRuleModelWithDefaultValues(); RestActionBodyExecTemplateModel scriptAction = rulesUtils.createCustomActionModel( SCRIPT_ACTION, Map.of(RULE_SCRIPT_PARAM_ID, rulesUtils.getReviewAndApproveWorkflowNode())); ruleModel.setActions(List.of(scriptAction)); - restClient.authenticateUser(dataUser.getAdminUser()).withPrivateAPI().usingNode(ruleFolder).usingDefaultRuleSet() + restClient.authenticateUser(user).withPrivateAPI().usingNode(ruleFolder).usingDefaultRuleSet() .createSingleRule(ruleModel); restClient.assertStatusCodeIs(CREATED);