inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-07 17:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct SiteService listMembers size limiting (needs to break out of both loops)

Browse Source 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@30227 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Nick Burch
2011-09-05 15:17:25 +00:00
parent f694b1c928
commit 72e5557688
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/java/org/alfresco/repo/site/SiteServiceImpl.java
View File

@@ -1466,7 +1466,8 @@ public class SiteServiceImpl extends AbstractLifecycleBean implements SiteServic
QName siteType = directNodeService.getType(siteNodeRef); QName siteType = directNodeService.getType(siteNodeRef);
Set<String> permissions = this.permissionService.getSettablePermissions(siteType); Set<String> permissions = this.permissionService.getSettablePermissions(siteType);
Map<String, String> groupsToExpand = new HashMap<String, String>(32); Map<String, String> groupsToExpand = new HashMap<String, String>(32);
for (String permission : permissions)
AUTHORITY_FIND: for (String permission : permissions)
{ {
if (roleFilter == null || roleFilter.length() == 0 || roleFilter.equals(permission)) if (roleFilter == null || roleFilter.length() == 0 || roleFilter.equals(permission))
{ {
@@ -1489,7 +1490,7 @@ public class SiteServiceImpl extends AbstractLifecycleBean implements SiteServic
members.put(authority, permission); members.put(authority, permission);
// break on max size limit reached // break on max size limit reached
if (members.size() == size) break; if (members.size() == size) break AUTHORITY_FIND;
} }
break; break;
case GROUP: case GROUP:
@@ -1524,6 +1525,9 @@ public class SiteServiceImpl extends AbstractLifecycleBean implements SiteServic
// No name filter add this group // No name filter add this group
members.put(authority, permission); members.put(authority, permission);
} }
// break on max size limit reached
if (members.size() == size) break AUTHORITY_FIND;
} }
break; break;
} }