[feature/MNT-24127-EndpointToCalculateFolderSize] Addressing review comments

This commit is contained in:
mohit-singh4
2024-10-18 15:47:10 +05:30
parent 855ab535b6
commit 74cc4c0b4c

View File

@@ -147,13 +147,6 @@ public class NodeSizeDetailsTest extends AbstractBaseApiTest
String jobId = (String) jsonObject.get("jobId"); String jobId = (String) jsonObject.get("jobId");
assertNotNull("In response, JobId should be present", jobId); assertNotNull("In response, JobId should be present", jobId);
Thread.sleep(500);
// Prepare parameters.
Map<String, String> params = new HashMap<>();
params.put("nodeId", childFolder);
params.put("jobId", jobId);
HttpResponse getResponse = getSingle(getNodeSizeDetailsUrl(childFolder, jobId), null, 200); HttpResponse getResponse = getSingle(getNodeSizeDetailsUrl(childFolder, jobId), null, 200);
assertNotNull("After executing GET/size-details, it will provide NodeSizeDetails with 200 status code", assertNotNull("After executing GET/size-details, it will provide NodeSizeDetails with 200 status code",
@@ -236,7 +229,7 @@ public class NodeSizeDetailsTest extends AbstractBaseApiTest
LocalTime actualTime = LocalTime.now(); LocalTime actualTime = LocalTime.now();
assertTrue("Calculating folder node is taking time greater than 5 seconds ", actualTime.isBefore(expectedTime)); assertTrue("Calculating folder node is taking time greater than 5 seconds ", actualTime.isBefore(expectedTime));
assertEquals("SizeDetails hasn't been calculated yet, current status -" + nodeSizeDetails.getStatus().name() + "]", status, nodeSizeDetails.getStatus().name()); assertEquals("SizeDetails hasn't been calculated yet, current status -" + nodeSizeDetails.getStatus().name() + "]", status, nodeSizeDetails.getStatus().name());
assertTrue("We are not getting size greater than 0", nodeSizeDetails.getSizeInBytes() > 0L); assertTrue("We are not getting size greater than 0 " + nodeSizeDetails, nodeSizeDetails.getSizeInBytes() > 0L);
Long defaultSize = 22250000L; Long defaultSize = 22250000L;
assertEquals(nodeSizeDetails.getSizeInBytes(), defaultSize); assertEquals(nodeSizeDetails.getSizeInBytes(), defaultSize);
} }