diff --git a/config/alfresco/rendition-services-context.xml b/config/alfresco/rendition-services-context.xml index ce6cb81787..5b4a93789f 100644 --- a/config/alfresco/rendition-services-context.xml +++ b/config/alfresco/rendition-services-context.xml @@ -133,9 +133,7 @@ - - + parent="baseRenderingAction" /> getParameterDefinitions() { @@ -219,19 +208,9 @@ public class HTMLRenderingEngine extends AbstractRenderingEngine ).getChildRef(); } - // If we can, associate it with the rendered HTML, so - // that they're properly linked - QName assocType = SECONDARY_IMAGE; - if(primary) - { - assocType = PRIMARY_IMAGE; - } - if(dictionaryService.getAssociation(assocType) != null) - { - nodeService.createAssociation( - context.getDestinationNode(), img, assocType - ); - } + // TODO Once composite content is properly supported, + // at this point we'll associate the new image with + // the rendered HTML node so the dependency is tracked. // Put the image into the node ContentWriter writer = contentService.getWriter( diff --git a/source/java/org/alfresco/repo/rendition/executer/HTMLRenderingEngineTest.java b/source/java/org/alfresco/repo/rendition/executer/HTMLRenderingEngineTest.java index 9de9deb0cd..a3fc29bb01 100644 --- a/source/java/org/alfresco/repo/rendition/executer/HTMLRenderingEngineTest.java +++ b/source/java/org/alfresco/repo/rendition/executer/HTMLRenderingEngineTest.java @@ -284,10 +284,11 @@ public class HTMLRenderingEngineTest extends BaseAlfrescoSpringTest // Check we didn't get any images for(ChildAssociationRef ref : nodeService.getChildAssocs(htmlNode)) { - if(ref.getTypeQName().equals(HTMLRenderingEngine.PRIMARY_IMAGE)) - fail("Found unexpected primary image of rendered html"); - if(ref.getTypeQName().equals(HTMLRenderingEngine.SECONDARY_IMAGE)) - fail("Found unexpected secondary image of rendered html"); + // TODO Check against composite content associations when present +// if(ref.getTypeQName().equals(HTMLRenderingEngine.PRIMARY_IMAGE)) +// fail("Found unexpected primary image of rendered html"); +// if(ref.getTypeQName().equals(HTMLRenderingEngine.SECONDARY_IMAGE)) +// fail("Found unexpected secondary image of rendered html"); } // All done @@ -376,21 +377,22 @@ public class HTMLRenderingEngineTest extends BaseAlfrescoSpringTest assertEquals(1, nodeService.getChildAssocs(imgFolder).size()); + // TODO Check against composite content associations when present // Check the associations if supported - if(dictionaryService.getAssociation(HTMLRenderingEngine.PRIMARY_IMAGE) != null) - { - boolean hasPrimary = false; - boolean hasSecondary = false; - for(ChildAssociationRef ref : nodeService.getChildAssocs(htmlNode)) - { - if(ref.getTypeQName().equals(HTMLRenderingEngine.PRIMARY_IMAGE)) - hasPrimary = true; - if(ref.getTypeQName().equals(HTMLRenderingEngine.SECONDARY_IMAGE)) - hasSecondary = true; - } - assertEquals(true, hasPrimary); - assertEquals(false, hasSecondary); - } +// if(dictionaryService.getAssociation(HTMLRenderingEngine.PRIMARY_IMAGE) != null) +// { +// boolean hasPrimary = false; +// boolean hasSecondary = false; +// for(ChildAssociationRef ref : nodeService.getChildAssocs(htmlNode)) +// { +// if(ref.getTypeQName().equals(HTMLRenderingEngine.PRIMARY_IMAGE)) +// hasPrimary = true; +// if(ref.getTypeQName().equals(HTMLRenderingEngine.SECONDARY_IMAGE)) +// hasSecondary = true; +// } +// assertEquals(true, hasPrimary); +// assertEquals(false, hasSecondary); +// } // All done tidyUpSourceDoc();