inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-10-08 14:51:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sonar critical bug: inefficient use of keySet iterator instead of entrySet iterator

Browse Source
This commit is contained in:
cagache
2019-07-03 17:30:10 +03:00
parent d27d927f51
commit 7a370248a2
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
rm-community/rm-community-repo/source/compatibility/org/alfresco/module/org_alfresco_module_rm/caveat/ScriptConstraint.java
View File

@@ -105,10 +105,7 @@ public class ScriptConstraint implements Serializable
constraint.setValues(entry.getValue()); constraint.setValues(entry.getValue());
constraints.add(constraint); constraints.add(constraint);
} }
return constraints.toArray(new ScriptConstraintAuthority[constraints.size()]);
ScriptConstraintAuthority[] retVal = constraints.toArray(new ScriptConstraintAuthority[constraints.size()]);
return retVal;
} }
/** /**
@@ -212,17 +209,14 @@ public class ScriptConstraint implements Serializable
// values, authorities // values, authorities
Map<String, List<String>> pivot = PivotUtil.getPivot(details); Map<String, List<String>> pivot = PivotUtil.getPivot(details);
// Here with some data to return
Set<String> values = pivot.keySet();
ArrayList<ScriptConstraintValue> constraints = new ArrayList<>(pivot.size()); ArrayList<ScriptConstraintValue> constraints = new ArrayList<>(pivot.size());
for(String value : values) for (Map.Entry<String, List<String>> entry : pivot.entrySet())
{ {
ScriptConstraintValue constraint = new ScriptConstraintValue(); ScriptConstraintValue constraint = new ScriptConstraintValue();
constraint.setValueName(value); constraint.setValueName(entry.getKey());
constraint.setValueTitle(value); constraint.setValueTitle(entry.getKey());
List<String>authorities = pivot.get(value); List<String> authorities = entry.getValue();
List<ScriptAuthority> sauth = new ArrayList<>(); List<ScriptAuthority> sauth = new ArrayList<>();
for(String authority : authorities) for(String authority : authorities)
{ {
@@ -247,6 +241,7 @@ public class ScriptConstraint implements Serializable
/** /**
* Now go through and add any "empty" values * Now go through and add any "empty" values
*/ */
Set<String> values = pivot.keySet();
for(String value : info.getAllowedValues()) for(String value : info.getAllowedValues())
{ {
if(!values.contains(value)) if(!values.contains(value))