inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-07 17:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merged V3.2 to HEAD

Browse Source 
18484: Merged DEV-TEMPORARY to V3.2 
                  18478: XForms errors - ACT 15969

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@18485 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Gavin Cornwell
2010-02-05 21:02:51 +00:00
parent 6989a3fcb3
commit 7cbb3a0daf
2 changed files with 92 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

149
source/java/org/alfresco/web/forms/xforms/XFormsBean.java
View File

@@ -33,6 +33,7 @@ import java.util.List;
import java.util.Locale; import java.util.Locale;
import java.util.Map; import java.util.Map;
import java.util.ResourceBundle; import java.util.ResourceBundle;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import javax.faces.context.ExternalContext; import javax.faces.context.ExternalContext;
import javax.faces.context.FacesContext; import javax.faces.context.FacesContext;
@@ -179,6 +180,8 @@ public class XFormsBean implements Serializable
private AVMBrowseBean avmBrowseBean; private AVMBrowseBean avmBrowseBean;
private NavigationBean navigator; private NavigationBean navigator;
private ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
public static String BEAN_NAME = "XFormsBean"; public static String BEAN_NAME = "XFormsBean";
/** /**
@@ -240,7 +243,16 @@ public class XFormsBean implements Serializable
final XMLEvent xmle = (XMLEvent)e; final XMLEvent xmle = (XMLEvent)e;
if (XFormsBean.LOGGER.isDebugEnabled()) if (XFormsBean.LOGGER.isDebugEnabled())
XFormsBean.LOGGER.debug("received event " + xmle.getType() + ": " + xmle); XFormsBean.LOGGER.debug("received event " + xmle.getType() + ": " + xmle);
XFormsBean.this.xformsSession.eventLog.add(xmle);
try
{
lock.writeLock().lock();
XFormsBean.this.xformsSession.eventLog.add(xmle);
}
finally
{
lock.writeLock().unlock();
}
} }
}; };
@@ -631,71 +643,90 @@ public class XFormsBean implements Serializable
final Document result = XMLUtil.newDocument(); final Document result = XMLUtil.newDocument();
final Element eventsElement = result.createElement("events"); final Element eventsElement = result.createElement("events");
result.appendChild(eventsElement); result.appendChild(eventsElement);
for (XMLEvent xfe : this.xformsSession.eventLog)
try
{ {
final String type = xfe.getType(); lock.readLock().lock();
if (LOGGER.isDebugEnabled())
{ for (XMLEvent xfe : this.xformsSession.eventLog)
LOGGER.debug("adding event " + type + " to the event log"); {
} final String type = xfe.getType();
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("adding event " + type + " to the event log");
}
final Element target = (Element)xfe.getTarget(); final Element target = (Element)xfe.getTarget();
final Element eventElement = result.createElement(type); final Element eventElement = result.createElement(type);
eventsElement.appendChild(eventElement); eventsElement.appendChild(eventElement);
eventElement.setAttribute("targetId", target.getAttributeNS(null, "id")); eventElement.setAttribute("targetId", target.getAttributeNS(null, "id"));
eventElement.setAttribute("targetName", target.getLocalName()); eventElement.setAttribute("targetName", target.getLocalName());
final Collection properties = xfe.getPropertyNames(); final Collection properties = xfe.getPropertyNames();
if (properties != null) if (properties != null)
{ {
for (Object name : properties) for (Object name : properties)
{ {
final Object value = xfe.getContextInfo((String)name); final Object value = xfe.getContextInfo((String)name);
if (LOGGER.isDebugEnabled()) if (LOGGER.isDebugEnabled())
{ {
LOGGER.debug("adding property {" + name + LOGGER.debug("adding property {" + name +
":" + value + "} to event " + type); ":" + value + "} to event " + type);
} }
final Element propertyElement = result.createElement("property"); final Element propertyElement = result.createElement("property");
eventElement.appendChild(propertyElement); eventElement.appendChild(propertyElement);
propertyElement.setAttribute("name", name.toString()); propertyElement.setAttribute("name", name.toString());
propertyElement.setAttribute("value", propertyElement.setAttribute("value",
value != null ? value.toString() : null); value != null ? value.toString() : null);
} }
} }
if (LOGGER.isDebugEnabled() && XFormsEventNames.SUBMIT_ERROR.equals(type)) if (LOGGER.isDebugEnabled() && XFormsEventNames.SUBMIT_ERROR.equals(type))
{ {
// debug for figuring out which elements aren't valid for submit // debug for figuring out which elements aren't valid for submit
LOGGER.debug("performing full revalidate"); LOGGER.debug("performing full revalidate");
try try
{ {
final Model model = this.xformsSession.chibaBean.getContainer().getDefaultModel(); final Model model = this.xformsSession.chibaBean.getContainer().getDefaultModel();
final Instance instance = model.getDefaultInstance(); final Instance instance = model.getDefaultInstance();
model.getValidator().validate(instance, "/", new DefaultValidatorMode()); model.getValidator().validate(instance, "/", new DefaultValidatorMode());
final Iterator<ModelItem> it = instance.iterateModelItems("/"); final Iterator<ModelItem> it = instance.iterateModelItems("/");
while (it.hasNext()) while (it.hasNext())
{ {
final ModelItem modelItem = it.next(); final ModelItem modelItem = it.next();
if (!modelItem.isValid()) if (!modelItem.isValid())
{ {
LOGGER.debug("model node " + modelItem.getNode() + " is invalid"); LOGGER.debug("model node " + modelItem.getNode() + " is invalid");
} }
if (modelItem.isRequired() && modelItem.getValue().length() == 0) if (modelItem.isRequired() && modelItem.getValue().length() == 0)
{ {
LOGGER.debug("model node " + modelItem.getNode() + " is empty and required"); LOGGER.debug("model node " + modelItem.getNode() + " is empty and required");
} }
} }
} }
catch (final XFormsException xfe2) catch (final XFormsException xfe2)
{ {
LOGGER.debug("error performing revaliation", xfe2); LOGGER.debug("error performing revaliation", xfe2);
} }
} }
}
}
finally
{
lock.readLock().unlock();
}
try
{
lock.writeLock().lock();
this.xformsSession.eventLog.clear();
}
finally
{
lock.writeLock().unlock();
} }
this.xformsSession.eventLog.clear();
if (LOGGER.isDebugEnabled()) if (LOGGER.isDebugEnabled())
{ {

4
source/web/scripts/ajax/xforms.js
View File

@@ -1578,9 +1578,9 @@ alfresco.xforms.ComboboxSelect1 = alfresco.xforms.AbstractSelectWidget.extend({
this.widget = this.domNode; this.widget = this.domNode;
for (var i = 0; i < values.length; i++) for (var i = 0; i < values.length; i++)
{ {
if (initial_value && !values[i].valid) if (!values[i].valid)
{ {
// skip the invalid value if we have a default value // always skip the invalid values for combos
continue; continue;
} }
var option = new Element("option"); var option = new Element("option");