mirror of
https://github.com/Alfresco/alfresco-community-repo.git
synced 2025-07-24 17:32:48 +00:00
Big honkin' merge from head. Sheesh!
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/WCM-DEV2/root@3617 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
@@ -252,13 +252,13 @@ public abstract class AbstractContentTransformer implements ContentTransformer
|
||||
finally
|
||||
{
|
||||
// check that the reader and writer are both closed
|
||||
if (!reader.isClosed())
|
||||
if (reader.isChannelOpen())
|
||||
{
|
||||
logger.error("Content reader not closed by transformer: \n" +
|
||||
" reader: " + reader + "\n" +
|
||||
" transformer: " + this);
|
||||
}
|
||||
if (!writer.isClosed())
|
||||
if (writer.isChannelOpen())
|
||||
{
|
||||
logger.error("Content writer not closed by transformer: \n" +
|
||||
" writer: " + writer + "\n" +
|
||||
|
@@ -25,11 +25,8 @@ import java.util.concurrent.locks.Lock;
|
||||
import java.util.concurrent.locks.ReadWriteLock;
|
||||
import java.util.concurrent.locks.ReentrantReadWriteLock;
|
||||
|
||||
import org.alfresco.error.AlfrescoRuntimeException;
|
||||
import org.alfresco.repo.content.MimetypeMap;
|
||||
import org.apache.commons.logging.Log;
|
||||
import org.apache.commons.logging.LogFactory;
|
||||
import org.springframework.util.Assert;
|
||||
|
||||
/**
|
||||
* Holds and provides the most appropriate content transformer for
|
||||
@@ -47,7 +44,6 @@ public class ContentTransformerRegistry
|
||||
private static final Log logger = LogFactory.getLog(ContentTransformerRegistry.class);
|
||||
|
||||
private List<ContentTransformer> transformers;
|
||||
private MimetypeMap mimetypeMap;
|
||||
/** Cache of previously used transactions */
|
||||
private Map<TransformationKey, List<ContentTransformer>> transformationCache;
|
||||
/** Controls read access to the transformation cache */
|
||||
@@ -58,11 +54,8 @@ public class ContentTransformerRegistry
|
||||
/**
|
||||
* @param mimetypeMap all the mimetypes available to the system
|
||||
*/
|
||||
public ContentTransformerRegistry(MimetypeMap mimetypeMap)
|
||||
public ContentTransformerRegistry()
|
||||
{
|
||||
Assert.notNull(mimetypeMap, "The MimetypeMap is mandatory");
|
||||
this.mimetypeMap = mimetypeMap;
|
||||
|
||||
this.transformers = new ArrayList<ContentTransformer>(10);
|
||||
transformationCache = new HashMap<TransformationKey, List<ContentTransformer>>(17);
|
||||
|
||||
@@ -143,16 +136,6 @@ public class ContentTransformerRegistry
|
||||
*/
|
||||
public ContentTransformer getTransformer(String sourceMimetype, String targetMimetype)
|
||||
{
|
||||
// check that the mimetypes are valid
|
||||
if (!mimetypeMap.getMimetypes().contains(sourceMimetype))
|
||||
{
|
||||
throw new AlfrescoRuntimeException("Unknown source mimetype: " + sourceMimetype);
|
||||
}
|
||||
if (!mimetypeMap.getMimetypes().contains(targetMimetype))
|
||||
{
|
||||
throw new AlfrescoRuntimeException("Unknown target mimetype: " + targetMimetype);
|
||||
}
|
||||
|
||||
TransformationKey key = new TransformationKey(sourceMimetype, targetMimetype);
|
||||
List<ContentTransformer> transformers = null;
|
||||
transformationCacheReadLock.lock();
|
||||
|
@@ -69,7 +69,7 @@ public class ContentTransformerRegistryTest extends AbstractContentTransformerTe
|
||||
bytes[i] = (byte)i;
|
||||
}
|
||||
// create the dummyRegistry
|
||||
dummyRegistry = new ContentTransformerRegistry(mimetypeMap);
|
||||
dummyRegistry = new ContentTransformerRegistry();
|
||||
// create some dummy transformers for reliability tests
|
||||
new DummyTransformer(mimetypeMap, dummyRegistry, A, B, 0.3, 10L);
|
||||
new DummyTransformer(mimetypeMap, dummyRegistry, A, B, 0.6, 10L);
|
||||
|
@@ -25,8 +25,6 @@ import org.alfresco.repo.content.MimetypeMap;
|
||||
*/
|
||||
public class HtmlParserContentTransformerTest extends AbstractContentTransformerTest
|
||||
{
|
||||
private static final String SOME_CONTENT = "azAz10!<21>$%^&*()\t\r\n";
|
||||
|
||||
private ContentTransformer transformer;
|
||||
|
||||
@Override
|
||||
|
Reference in New Issue
Block a user