inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed major issues ("Simplify Boolean Expression") reported in Sonar

Browse Source 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@71962 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Tuna Aksoy
2014-05-27 22:42:15 +00:00
parent 9030ab5569
commit 81a71c041e
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v22/RMv22GhostOnDestroyDispositionActionPatch.java
View File

@@ -130,14 +130,14 @@ public class RMv22GhostOnDestroyDispositionActionPatch extends AbstractModulePat
*/
private void getDispositionSchedules(NodeRef nodeRef, Set<DispositionSchedule> dispositionSchedules)
{
if (filePlanService.isRecordCategory(nodeRef) == true)
if (filePlanService.isRecordCategory(nodeRef))
{
DispositionSchedule dispositionSchedule = this.dispositionService.getDispositionSchedule(nodeRef);
if (dispositionSchedule != null)
{
dispositionSchedules.add(dispositionSchedule);
}
List<ChildAssociationRef> children = nodeService.getChildAssocs(nodeRef, ContentModel.ASSOC_CONTAINS, RegexQNamePattern.MATCH_ALL);
for (ChildAssociationRef childAssoc : children)
{

4
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityInterceptor.java
View File

@@ -123,7 +123,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor
if (logger.isDebugEnabled())
{
CapabilityReport capability = getCapabilityReport(name);
if (expected == false)
if (!expected)
{
conditionName = "!" + conditionName;
}
@@ -155,7 +155,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor
for (Map.Entry<String, Boolean> entry : capability.conditions.entrySet())
{
buffer.append(" - ").append(entry.getKey()).append(" (");
if (entry.getValue() == true)
if (entry.getValue())
{
buffer.append("passed");
}

8
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/transfer/TransferServiceImpl.java
View File

@@ -53,7 +53,7 @@ import org.springframework.extensions.surf.util.ParameterCheck;
* @author Tuna Aksoy
* @since 2.2
*/
public class TransferServiceImpl extends ServiceBaseImpl
public class TransferServiceImpl extends ServiceBaseImpl
implements TransferService, RecordsManagementModel
{
/** Transfer node reference key */
@@ -176,14 +176,14 @@ public class TransferServiceImpl extends ServiceBaseImpl
setPDFIndicationFlag(transferNodeRef, nodeRef);
// Set the transferring indicator aspect
nodeService.addAspect(nodeRef, ASPECT_TRANSFERRING, null);
if (isRecordFolder(nodeRef) == true)
nodeService.addAspect(nodeRef, ASPECT_TRANSFERRING, null);
if (isRecordFolder(nodeRef))
{
// add the transferring indicator aspect to all the child records
for (NodeRef record : recordService.getRecords(nodeRef))
{
nodeService.addAspect(record, ASPECT_TRANSFERRING, null);
}
}
}
return transferNodeRef;