Fixed major issues ("Simplify Boolean Expression") reported in Sonar

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@71962 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Tuna Aksoy
2014-05-27 22:42:15 +00:00
parent 9030ab5569
commit 81a71c041e
3 changed files with 8 additions and 8 deletions

View File

@@ -130,7 +130,7 @@ public class RMv22GhostOnDestroyDispositionActionPatch extends AbstractModulePat
*/
private void getDispositionSchedules(NodeRef nodeRef, Set<DispositionSchedule> dispositionSchedules)
{
if (filePlanService.isRecordCategory(nodeRef) == true)
if (filePlanService.isRecordCategory(nodeRef))
{
DispositionSchedule dispositionSchedule = this.dispositionService.getDispositionSchedule(nodeRef);
if (dispositionSchedule != null)

View File

@@ -123,7 +123,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor
if (logger.isDebugEnabled())
{
CapabilityReport capability = getCapabilityReport(name);
if (expected == false)
if (!expected)
{
conditionName = "!" + conditionName;
}
@@ -155,7 +155,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor
for (Map.Entry<String, Boolean> entry : capability.conditions.entrySet())
{
buffer.append(" - ").append(entry.getKey()).append(" (");
if (entry.getValue() == true)
if (entry.getValue())
{
buffer.append("passed");
}

View File

@@ -177,7 +177,7 @@ public class TransferServiceImpl extends ServiceBaseImpl
// Set the transferring indicator aspect
nodeService.addAspect(nodeRef, ASPECT_TRANSFERRING, null);
if (isRecordFolder(nodeRef) == true)
if (isRecordFolder(nodeRef))
{
// add the transferring indicator aspect to all the child records
for (NodeRef record : recordService.getRecords(nodeRef))