RM-4012 - review updates

This commit is contained in:
Ana Bozianu
2016-10-28 14:44:34 +03:00
parent 935b516646
commit 9237a3b4a2
3 changed files with 13 additions and 13 deletions

View File

@@ -37,9 +37,14 @@ import org.alfresco.rest.api.Nodes;
*/ */
public interface RMNodes extends Nodes public interface RMNodes extends Nodes
{ {
String PARAM_INCLUDE_HAS_RETENTION_SCHEDULE = "hasRetentionSchedule"; public static String PATH_FILE_PLAN = "-filePlan-";
String PARAM_INCLUDE_IS_CLOSED = "isClosed"; public static String PATH_TRANSFERS = "-transfers-";
String PARAM_INCLUDE_IS_COMPLETED = "isCompleted"; public static String PATH_UNFILED = "-unfiled-";
public static String PATH_HOLDS = "-holds-";
public static String PARAM_INCLUDE_HAS_RETENTION_SCHEDULE = "hasRetentionSchedule";
public static String PARAM_INCLUDE_IS_CLOSED = "isClosed";
public static String PARAM_INCLUDE_IS_COMPLETED = "isCompleted";
/** /**
* Identifies if one node is RM site node. * Identifies if one node is RM site node.

View File

@@ -74,11 +74,6 @@ import org.alfresco.util.Pair;
*/ */
public class RMNodesImpl extends NodesImpl implements RMNodes public class RMNodesImpl extends NodesImpl implements RMNodes
{ {
String FILE_PLAN = "-filePlan-";
String TRANSFERS = "-transfers-";
String UNFILED = "-unfiled-";
String HOLDS = "-holds-";
private enum RMNodeType private enum RMNodeType
{ {
// Note: ordered // Note: ordered
@@ -213,7 +208,7 @@ public class RMNodesImpl extends NodesImpl implements RMNodes
throw new InvalidArgumentException("Missing nodeId"); throw new InvalidArgumentException("Missing nodeId");
} }
if (nodeId.equals(FILE_PLAN)) if (nodeId.equals(PATH_FILE_PLAN))
{ {
NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID); NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID);
if (filePlan != null) if (filePlan != null)
@@ -225,7 +220,7 @@ public class RMNodesImpl extends NodesImpl implements RMNodes
throw new EntityNotFoundException(nodeId); throw new EntityNotFoundException(nodeId);
} }
} }
else if (nodeId.equals(TRANSFERS)) else if (nodeId.equals(PATH_TRANSFERS))
{ {
NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID); NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID);
if (filePlan != null) if (filePlan != null)
@@ -237,7 +232,7 @@ public class RMNodesImpl extends NodesImpl implements RMNodes
throw new EntityNotFoundException(nodeId); throw new EntityNotFoundException(nodeId);
} }
} }
else if (nodeId.equals(UNFILED)) else if (nodeId.equals(PATH_UNFILED))
{ {
NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID); NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID);
if (filePlan != null) if (filePlan != null)
@@ -249,7 +244,7 @@ public class RMNodesImpl extends NodesImpl implements RMNodes
throw new EntityNotFoundException(nodeId); throw new EntityNotFoundException(nodeId);
} }
} }
else if (nodeId.equals(HOLDS)) else if (nodeId.equals(PATH_HOLDS))
{ {
NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID); NodeRef filePlan = filePlanService.getFilePlanBySiteId(FilePlanService.DEFAULT_RM_SITE_ID);
if (filePlan != null) if (filePlan != null)

View File

@@ -26,7 +26,7 @@
*/ */
/** /**
* Package info that defines the Information Governance REST API * Package info that defines the Information Governance Nodes REST API
* *
* @author Ana Bozianu * @author Ana Bozianu
* @since 2.6 * @since 2.6