From 959cf8f13f539a5be7fc95941bbb07426e520644 Mon Sep 17 00:00:00 2001 From: Kacper Magdziarz <95610011+kmagdziarz@users.noreply.github.com> Date: Wed, 5 Apr 2023 08:22:25 +0200 Subject: [PATCH] Feature/acs 4462 mtls e2e test (#1861) ACS-4462 add empty response handling --- .../org/alfresco/rest/core/RestWrapper.java | 23 +++++++++++-------- .../transform/RemoteTransformerClient.java | 1 - 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/packaging/tests/tas-restapi/src/main/java/org/alfresco/rest/core/RestWrapper.java b/packaging/tests/tas-restapi/src/main/java/org/alfresco/rest/core/RestWrapper.java index 9d4e41442b..01f4234d57 100644 --- a/packaging/tests/tas-restapi/src/main/java/org/alfresco/rest/core/RestWrapper.java +++ b/packaging/tests/tas-restapi/src/main/java/org/alfresco/rest/core/RestWrapper.java @@ -680,17 +680,22 @@ public class RestWrapper extends DSLWrapper } else { - if (returnedResponse.getContentType().contains("image/png")) - { - LOG.info("On {} {}, received the response with an image and headers: \n{}", restRequest.getHttpMethod(), restRequest.getPath(), - returnedResponse.getHeaders().toString()); - } - else if (returnedResponse.getContentType().contains("application/json") && !returnedResponse.asString().isEmpty()) + if (returnedResponse.asString().isEmpty()) { LOG.info("On {} {}, received the following response \n{}", restRequest.getHttpMethod(), restRequest.getPath(), - Utility.prettyPrintJsonString(returnedResponse.asString())); + returnedResponse.getStatusCode()); } - else if (returnedResponse.getContentType().contains("application/xml") && !returnedResponse.asString().isEmpty()) + else if (returnedResponse.getContentType().contains("image/png")) + { + LOG.info("On {} {}, received the response with an image and headers: \n{}", restRequest.getHttpMethod(), restRequest.getPath(), + returnedResponse.getHeaders().toString()); + } + else if (returnedResponse.getContentType().contains("application/json")) + { + LOG.info("On {} {}, received the following response \n{}", restRequest.getHttpMethod(), restRequest.getPath(), + Utility.prettyPrintJsonString(returnedResponse.asString())); + } + else if (returnedResponse.getContentType().contains("application/xml")) { String response = parseXML(returnedResponse); LOG.info("On {} {}, received the following response \n{}", restRequest.getHttpMethod(), restRequest.getPath(), response); @@ -698,7 +703,7 @@ public class RestWrapper extends DSLWrapper else { LOG.info("On {} {}, received the following response \n{}", restRequest.getHttpMethod(), restRequest.getPath(), - ToStringBuilder.reflectionToString(returnedResponse.asString(), ToStringStyle.MULTI_LINE_STYLE)); + ToStringBuilder.reflectionToString(returnedResponse.asString(), ToStringStyle.MULTI_LINE_STYLE)); } } } diff --git a/repository/src/main/java/org/alfresco/repo/content/transform/RemoteTransformerClient.java b/repository/src/main/java/org/alfresco/repo/content/transform/RemoteTransformerClient.java index c03f9270b4..dfc03d995e 100644 --- a/repository/src/main/java/org/alfresco/repo/content/transform/RemoteTransformerClient.java +++ b/repository/src/main/java/org/alfresco/repo/content/transform/RemoteTransformerClient.java @@ -47,7 +47,6 @@ import org.apache.http.client.methods.HttpPost; import org.apache.http.entity.ContentType; import org.apache.http.entity.mime.MultipartEntityBuilder; import org.apache.http.impl.client.CloseableHttpClient; -import org.apache.http.impl.client.HttpClients; import org.apache.http.util.EntityUtils; /**