Fixed major issues reported by sonar (Unused formal parameter)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64829 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Tuna Aksoy
2014-03-19 00:02:52 +00:00
parent dca3a954ac
commit 9847e15dda
6 changed files with 12 additions and 27 deletions

View File

@@ -37,7 +37,7 @@ public class RMAuthorityDAOImpl extends AuthorityDAOImpl
{
protected void addAuthorityNameIfMatches(Set<String> authorities, String authorityName, AuthorityType type)
{
if (isAuthorityNameMatching(authorities, authorityName, type))
if (isAuthorityNameMatching(authorityName, type))
{
authorities.add(authorityName);
}
@@ -45,7 +45,7 @@ public class RMAuthorityDAOImpl extends AuthorityDAOImpl
protected void addAuthorityNameIfMatches(Set<String> authorities, String authorityName, AuthorityType type, Pattern pattern)
{
if (isAuthorityNameMatching(authorities, authorityName, type))
if (isAuthorityNameMatching(authorityName, type))
{
if (pattern == null)
{
@@ -69,7 +69,7 @@ public class RMAuthorityDAOImpl extends AuthorityDAOImpl
}
}
private boolean isAuthorityNameMatching(Set<String> authorities, String authorityName, AuthorityType type)
private boolean isAuthorityNameMatching(String authorityName, AuthorityType type)
{
boolean isMatching = false;
if (type == null || AuthorityType.getAuthorityType(authorityName).equals(type) && !getAuthorityZones(authorityName).contains("APP.RM"))

View File

@@ -75,19 +75,17 @@ public class RmClassesGet extends DictionaryWebServiceBase implements RecordsMan
*/
protected Map<String, Object> executeImpl(WebScriptRequest req, Status status, Cache cache)
{
return executeImpl(req, status, cache, RmDictionaryWebServiceUtils.isRmSite(req, siteService));
return executeImpl(req, RmDictionaryWebServiceUtils.isRmSite(req, siteService));
}
/**
* Execute custom Java logic
*
* @param req Web Script request
* @param status Web Script status
* @param cache Web Script cache
* @param isRM indicates whether the request comes from an RM site or not
* @return custom service model
*/
private Map<String, Object> executeImpl(WebScriptRequest req, Status status, Cache cache, boolean isRM)
private Map<String, Object> executeImpl(WebScriptRequest req, boolean isRM)
{
String classFilter = getValidInput(req.getParameter(REQ_URL_TEMPL_VAR_CLASS_FILTER));
String namespacePrefix = getValidInput(req.getParameter(REQ_URL_TEMPL_VAR_NAMESPACE_PREFIX));

View File

@@ -66,19 +66,17 @@ public class RmPropertiesGet extends DictionaryWebServiceBase implements Records
*/
protected Map<String, Object> executeImpl(WebScriptRequest req, Status status, Cache cache)
{
return executeImpl(req, status, cache, RmDictionaryWebServiceUtils.isRmSite(req, siteService));
return executeImpl(req, RmDictionaryWebServiceUtils.isRmSite(req, siteService));
}
/**
* Execute custom Java logic
*
* @param req Web Script request
* @param status Web Script status
* @param cache Web Script cache
* @param isRM indicates whether the request comes from an RM site or not
* @return custom service model
*/
private Map<String, Object> executeImpl(WebScriptRequest req, Status status, Cache cache, boolean isRM)
private Map<String, Object> executeImpl(WebScriptRequest req, boolean isRM)
{
QName classQName = null;
String className = req.getServiceMatch().getTemplateVars().get(DICTIONARY_CLASS_NAME);