From 9d6d25b60a9439776d6c6a1797f3e340bb397745 Mon Sep 17 00:00:00 2001
From: Derek Hulley <derek.hulley@alfresco.com>
Date: Tue, 15 Sep 2009 10:02:30 +0000
Subject: [PATCH] Added missed opportunity to cache a value during
 updateValue()

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@16268 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../repo/cache/lookup/EntityLookupCache.java         | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/source/java/org/alfresco/repo/cache/lookup/EntityLookupCache.java b/source/java/org/alfresco/repo/cache/lookup/EntityLookupCache.java
index 7c77c1a6ac..11a5627bbf 100644
--- a/source/java/org/alfresco/repo/cache/lookup/EntityLookupCache.java
+++ b/source/java/org/alfresco/repo/cache/lookup/EntityLookupCache.java
@@ -520,15 +520,13 @@ public class EntityLookupCache<K extends Serializable, V extends Object, VK exte
         // Get the value key.
         VK valueKey = (value == null) ? (VK)VALUE_NULL : entityLookup.getValueKey(value);
         // Check if the value has a good key
-        if (valueKey == null)
+        if (valueKey != null)
         {
-            // No good key, so no caching
-            return updateCount;
+            // There is a good value key, cache by value
+            CacheRegionValueKey valueCacheKey = new CacheRegionValueKey(cacheRegion, valueKey);
+            cache.put(valueCacheKey, key);
         }
-        
-        // Cache the key and value
-        CacheRegionValueKey valueCacheKey = new CacheRegionValueKey(cacheRegion, valueKey);
-        cache.put(valueCacheKey, key);
+        // Cache by key
         cache.put(
                 new CacheRegionKey(cacheRegion, key),
                 (value == null ? VALUE_NULL : value));