inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-24 17:32:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue with RuntimeExecutable transformers not being able to register/initialize

Browse Source 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@2493 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Derek Hulley
2006-02-24 20:19:49 +00:00
parent 68b06886ce
commit 9e462e986f
1 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
source/java/org/alfresco/repo/content/transform/RuntimeExecutableContentTransformer.java
View File

@@ -24,7 +24,6 @@ import org.alfresco.error.AlfrescoRuntimeException;
import org.alfresco.service.cmr.repository.ContentIOException; import org.alfresco.service.cmr.repository.ContentIOException;
import org.alfresco.service.cmr.repository.ContentReader; import org.alfresco.service.cmr.repository.ContentReader;
import org.alfresco.service.cmr.repository.ContentWriter; import org.alfresco.service.cmr.repository.ContentWriter;
import org.alfresco.service.cmr.repository.MimetypeService;
import org.alfresco.util.TempFileProvider; import org.alfresco.util.TempFileProvider;
import org.alfresco.util.exec.RuntimeExec; import org.alfresco.util.exec.RuntimeExec;
import org.alfresco.util.exec.RuntimeExec.ExecutionResult; import org.alfresco.util.exec.RuntimeExec.ExecutionResult;
@@ -63,7 +62,6 @@ public class RuntimeExecutableContentTransformer extends AbstractContentTransfor
private static Log logger = LogFactory.getLog(RuntimeExecutableContentTransformer.class); private static Log logger = LogFactory.getLog(RuntimeExecutableContentTransformer.class);
private boolean available; private boolean available;
private MimetypeService mimetypeService;
private RuntimeExec checkCommand; private RuntimeExec checkCommand;
private RuntimeExec transformCommand; private RuntimeExec transformCommand;
@@ -71,14 +69,6 @@ public class RuntimeExecutableContentTransformer extends AbstractContentTransfor
{ {
} }
/**
* @param mimetypeService the mapping from mimetype to extensions
*/
public void setMimetypeService(MimetypeService mimetypeService)
{
this.mimetypeService = mimetypeService;
}
/** /**
* Set the runtime executer that will be called as part of the initialisation * Set the runtime executer that will be called as part of the initialisation
* to determine if the transformer is able to function. This is optional, but allows * to determine if the transformer is able to function. This is optional, but allows
@@ -119,16 +109,13 @@ public class RuntimeExecutableContentTransformer extends AbstractContentTransfor
* being rendered unusable within the transformer registry, but may still be called * being rendered unusable within the transformer registry, but may still be called
* directly. * directly.
*/ */
public void init() @Override
public void register()
{ {
if (transformCommand == null) if (transformCommand == null)
{ {
throw new AlfrescoRuntimeException("Mandatory property 'transformCommand' not set"); throw new AlfrescoRuntimeException("Mandatory property 'transformCommand' not set");
} }
else if (mimetypeService == null)
{
throw new AlfrescoRuntimeException("Mandatory property 'mimetypeService' not set");
}
// execute the command // execute the command
if (checkCommand != null) if (checkCommand != null)
@@ -142,6 +129,8 @@ public class RuntimeExecutableContentTransformer extends AbstractContentTransfor
// no check - just assume it is available // no check - just assume it is available
available = true; available = true;
} }
// call the base class to make sure that it gets registered
super.register();
} }
/** /**
@@ -178,8 +167,8 @@ public class RuntimeExecutableContentTransformer extends AbstractContentTransfor
String targetMimetype = getMimetype(writer); String targetMimetype = getMimetype(writer);
// get the extensions to use // get the extensions to use
String sourceExtension = mimetypeService.getExtension(sourceMimetype); String sourceExtension = getMimetypeService().getExtension(sourceMimetype);
String targetExtension = mimetypeService.getExtension(targetMimetype); String targetExtension = getMimetypeService().getExtension(targetMimetype);
if (sourceExtension == null || targetExtension == null) if (sourceExtension == null || targetExtension == null)
{ {
throw new AlfrescoRuntimeException("Unknown extensions for mimetypes: \n" + throw new AlfrescoRuntimeException("Unknown extensions for mimetypes: \n" +