diff --git a/source/java/org/alfresco/rest/api/impl/NodesImpl.java b/source/java/org/alfresco/rest/api/impl/NodesImpl.java index 8aa096a395..6c4bbf52f9 100644 --- a/source/java/org/alfresco/rest/api/impl/NodesImpl.java +++ b/source/java/org/alfresco/rest/api/impl/NodesImpl.java @@ -1345,7 +1345,6 @@ public class NodesImpl implements Nodes fileFolderService.delete(nodeRef); } - // TODO should we able to specify content properties (eg. mimeType ... or use extension for now, or encoding) @Override public Node createNode(String parentFolderNodeId, Node nodeInfo, Parameters parameters) { @@ -1384,6 +1383,7 @@ public class NodesImpl implements Nodes validateCmObject(nodeTypeQName); } + /* RA-834: commented-out since not currently applicable for empty file List thumbnailDefs = null; String renditionsParam = parameters.getParameter(PARAM_RENDITIONS); if (renditionsParam != null) @@ -1395,6 +1395,7 @@ public class NodesImpl implements Nodes thumbnailDefs = getThumbnailDefs(renditionsParam); } + */ Map props = new HashMap<>(1); @@ -1448,7 +1449,9 @@ public class NodesImpl implements Nodes Node newNode = getFolderOrDocument(nodeRef.getId(), parameters); + /* RA-834: commented-out since not currently applicable for empty file requestRenditions(thumbnailDefs, newNode); // note: noop for folder + */ return newNode; } diff --git a/source/test-java/org/alfresco/rest/api/tests/RenditionsTest.java b/source/test-java/org/alfresco/rest/api/tests/RenditionsTest.java index eaa80ddcd7..f0ec3a6c72 100644 --- a/source/test-java/org/alfresco/rest/api/tests/RenditionsTest.java +++ b/source/test-java/org/alfresco/rest/api/tests/RenditionsTest.java @@ -509,10 +509,7 @@ public class RenditionsTest extends AbstractBaseApiTest assertEquals(RenditionStatus.CREATED, rendition.getStatus()); */ - /* - // TODO open question (RA-834) - // - should we accept for JSON when creating empty file (ie. with zero-byte content) - // - eg. might fail, eg. doclib for empty plain text / pdf ? + /* RA-834: commented-out since not currently applicable for empty file Document d1 = new Document(); d1.setName("d1.txt"); d1.setNodeType("cm:content");