From a2901da28eefe176bfa4be64c709429a90b5ccfb Mon Sep 17 00:00:00 2001
From: Alan Davis <alan.davis@alfresco.com>
Date: Tue, 11 Feb 2014 23:01:43 +0000
Subject: [PATCH] Merged HEAD-BUG-FIX (4.3/Cloud) to HEAD (4.3/Cloud)    58206:
 Merged V4.2-BUG-FIX (4.2.1) to HEAD-BUG-FIX (Cloud/4.3)       58147: Merged
 V4.1-BUG-FIX (4.1.8) to V4.2-BUG-FIX (4.2.1)          58037: MNT-9932: Merged
 DEV to V4.1-BUG-FIX (4.1.8)             57933: MNT-9932: Error Message while
 accessing cancelled workflow- task-edit link from mail notification          
      - Add useful error messages for case when edit page is opened for
 cancelled task

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@61945 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../repo/forms/processor/workflow/TaskFormProcessor.java  | 8 +++++++-
 .../forms/processor/workflow/TaskFormProcessorTest.java   | 6 ++++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/source/java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessor.java b/source/java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessor.java
index dc31e8ef5f..60c0fb98ba 100644
--- a/source/java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessor.java
+++ b/source/java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessor.java
@@ -107,7 +107,13 @@ public class TaskFormProcessor extends AbstractWorkflowFormProcessor<WorkflowTas
     @Override
     protected WorkflowTask getTypedItemForDecodedId(String itemId)
     {
-        return workflowService.getTaskById(itemId);
+        WorkflowTask task = workflowService.getTaskById(itemId);
+        if (task == null)
+        {
+            String msg = "Workflow task does not exist: " + itemId;
+            throw new IllegalArgumentException(msg);
+        }
+        return task;
     }
 
     /**
diff --git a/source/test-java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessorTest.java b/source/test-java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessorTest.java
index fd7461ae16..a298e5d4dc 100644
--- a/source/test-java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessorTest.java
+++ b/source/test-java/org/alfresco/repo/forms/processor/workflow/TaskFormProcessorTest.java
@@ -57,7 +57,6 @@ import org.alfresco.service.cmr.repository.NodeService;
 import org.alfresco.service.cmr.security.AuthenticationService;
 import org.alfresco.service.cmr.security.PersonService;
 import org.alfresco.service.cmr.workflow.WorkflowDefinition;
-import org.alfresco.service.cmr.workflow.WorkflowException;
 import org.alfresco.service.cmr.workflow.WorkflowInstance;
 import org.alfresco.service.cmr.workflow.WorkflowNode;
 import org.alfresco.service.cmr.workflow.WorkflowPath;
@@ -787,7 +786,10 @@ public class TaskFormProcessorTest extends TestCase
                 if (TASK_ID.equals(id))
                     return task;
                 else
-                    throw new WorkflowException("Task Id not found!");
+                {
+                    // if TaskId is not found then Activity returns null, does not throws WorkflowException
+                    return null;
+                }
             }
         });