Add missing Auditable/NotAuditable tags, and stub auditConfig entry

Fixes ALF-2277, where enabling audit broke some site features of share with
 errors around unanotated service methods on Tagging and Invitation


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@19899 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Nick Burch
2010-04-19 14:25:17 +00:00
parent 0d3f558e11
commit a711bff301
3 changed files with 37 additions and 3 deletions

View File

@@ -184,6 +184,8 @@
<Service name="ExporterService"/> <Service name="ExporterService"/>
<Service name="ImporterService"/> <Service name="ImporterService"/>
<Service name="InvitationService"/>
<Service name="RepositoryExporterService"/> <Service name="RepositoryExporterService"/>
@@ -193,6 +195,8 @@
<Service name="NamespaceService" mode="none" enabled="false"/> <Service name="NamespaceService" mode="none" enabled="false"/>
<Service name="TaggingService" mode="none" enabled="false"/>
<Service name="TransactionService" mode="none" enabled="false"/> <Service name="TransactionService" mode="none" enabled="false"/>
<Service name="WorkflowService" auditInternal="true"> <Service name="WorkflowService" auditInternal="true">
@@ -208,4 +212,4 @@
<Method name="getPooledTasks" mode="none"/> <Method name="getPooledTasks" mode="none"/>
</Service> </Service>
</Audit> </Audit>

View File

@@ -21,6 +21,7 @@ package org.alfresco.service.cmr.invitation;
import java.util.List; import java.util.List;
import org.alfresco.service.Auditable; import org.alfresco.service.Auditable;
import org.alfresco.service.NotAuditable;
import org.alfresco.service.PublicService; import org.alfresco.service.PublicService;
/** /**
@@ -41,6 +42,7 @@ public interface InvitationService
* *
* @return the names of the workkflows managed by the invitation service. * @return the names of the workkflows managed by the invitation service.
*/ */
@NotAuditable
public List<String> getInvitationServiceWorkflowNames(); public List<String> getInvitationServiceWorkflowNames();
/** /**
@@ -166,14 +168,14 @@ public interface InvitationService
* @param invitationId * @param invitationId
* @param reason * @param reason
*/ */
@Auditable(parameters = {"invitationId", "reason"}) @Auditable(parameters = {"invitationId", "reason"})
public Invitation reject(String invitationId, String reason); public Invitation reject(String invitationId, String reason);
/** /**
* cancel this request * cancel this request
*/ */
@Auditable(parameters = {"invitationId"}) @Auditable(parameters = {"invitationId"})
public Invitation cancel (String invitationId); public Invitation cancel (String invitationId);
/** /**
@@ -181,11 +183,13 @@ public interface InvitationService
* *
* @param invitationId; * @param invitationId;
*/ */
@NotAuditable
public Invitation getInvitation(String invitationId) ; public Invitation getInvitation(String invitationId) ;
/** /**
* list Invitations for a specific person * list Invitations for a specific person
*/ */
@NotAuditable
public List<Invitation> listPendingInvitationsForInvitee(String invitee); public List<Invitation> listPendingInvitationsForInvitee(String invitee);
/** /**
@@ -193,6 +197,7 @@ public interface InvitationService
* @param resourceType * @param resourceType
* @param resourceName * @param resourceName
*/ */
@NotAuditable
public List<Invitation> listPendingInvitationsForResource(Invitation.ResourceType resourceType, String resourceName); public List<Invitation> listPendingInvitationsForResource(Invitation.ResourceType resourceType, String resourceName);
/** /**
@@ -201,6 +206,7 @@ public interface InvitationService
* @param criteria * @param criteria
* @return the list of invitations * @return the list of invitations
*/ */
@NotAuditable
public List<Invitation> searchInvitation(InvitationSearchCriteria criteria); public List<Invitation> searchInvitation(InvitationSearchCriteria criteria);

View File

@@ -20,6 +20,8 @@ package org.alfresco.service.cmr.tagging;
import java.util.List; import java.util.List;
import org.alfresco.service.Auditable;
import org.alfresco.service.NotAuditable;
import org.alfresco.service.PublicService; import org.alfresco.service.PublicService;
import org.alfresco.service.cmr.repository.NodeRef; import org.alfresco.service.cmr.repository.NodeRef;
import org.alfresco.service.cmr.repository.StoreRef; import org.alfresco.service.cmr.repository.StoreRef;
@@ -39,6 +41,7 @@ public interface TaggingService
* @param tag tag name * @param tag tag name
* @return boolean true if the tag exists, false otherwise * @return boolean true if the tag exists, false otherwise
*/ */
@NotAuditable
boolean isTag(StoreRef storeRef, String tag); boolean isTag(StoreRef storeRef, String tag);
/** /**
@@ -46,6 +49,7 @@ public interface TaggingService
* *
* @return List<String> list of tags * @return List<String> list of tags
*/ */
@NotAuditable
List<String> getTags(StoreRef storeRef); List<String> getTags(StoreRef storeRef);
/** /**
@@ -55,6 +59,7 @@ public interface TaggingService
* @param filter tag filter * @param filter tag filter
* @return List<String> list of tags * @return List<String> list of tags
*/ */
@NotAuditable
List<String> getTags(StoreRef storeRef, String filter); List<String> getTags(StoreRef storeRef, String filter);
/** /**
@@ -63,6 +68,7 @@ public interface TaggingService
* @param storeRef store reference * @param storeRef store reference
* @param tag tag name * @param tag tag name
*/ */
@Auditable(parameters = {"tag"})
NodeRef createTag(StoreRef storeRef, String tag); NodeRef createTag(StoreRef storeRef, String tag);
/** /**
@@ -71,6 +77,7 @@ public interface TaggingService
* @param storeRef store reference * @param storeRef store reference
* @param tag tag name * @param tag tag name
*/ */
@Auditable(parameters = {"tag"})
void deleteTag(StoreRef storeRef, String tag); void deleteTag(StoreRef storeRef, String tag);
/** /**
@@ -80,6 +87,7 @@ public interface TaggingService
* @param tag tag name * @param tag tag name
* @return boolean true if the node has the tag, false otherwise * @return boolean true if the node has the tag, false otherwise
*/ */
@Auditable(parameters = {"tag"})
boolean hasTag(NodeRef nodeRef, String tag); boolean hasTag(NodeRef nodeRef, String tag);
/** /**
@@ -88,6 +96,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @param tag tag name * @param tag tag name
*/ */
@Auditable(parameters = {"tag"})
void addTag(NodeRef nodeRef, String tag); void addTag(NodeRef nodeRef, String tag);
/** /**
@@ -99,6 +108,7 @@ public interface TaggingService
* @param tag tag * @param tag tag
* @return NodeRef tag node reference or null not exist * @return NodeRef tag node reference or null not exist
*/ */
@NotAuditable
NodeRef getTagNodeRef(StoreRef storeRef, String tag); NodeRef getTagNodeRef(StoreRef storeRef, String tag);
/** /**
@@ -109,6 +119,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @param tags list of tags * @param tags list of tags
*/ */
@Auditable(parameters = {"tags"})
void addTags(NodeRef nodeRef, List<String> tags); void addTags(NodeRef nodeRef, List<String> tags);
/** /**
@@ -117,6 +128,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @param tag tag name * @param tag tag name
*/ */
@Auditable(parameters = {"tag"})
void removeTag(NodeRef nodeRef, String tag); void removeTag(NodeRef nodeRef, String tag);
/** /**
@@ -125,6 +137,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @param tags list of tags * @param tags list of tags
*/ */
@Auditable(parameters = {"tags"})
void removeTags(NodeRef nodeRef, List<String> tags); void removeTags(NodeRef nodeRef, List<String> tags);
/** /**
@@ -133,6 +146,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @return List<String> list of tags on the node * @return List<String> list of tags on the node
*/ */
@NotAuditable
List<String> getTags(NodeRef nodeRef); List<String> getTags(NodeRef nodeRef);
/** /**
@@ -142,6 +156,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @param tags list of tags * @param tags list of tags
*/ */
@Auditable(parameters = {"tags"})
void setTags(NodeRef nodeRef, List<String> tags); void setTags(NodeRef nodeRef, List<String> tags);
/** /**
@@ -149,6 +164,7 @@ public interface TaggingService
* *
* @param nodeRef node reference * @param nodeRef node reference
*/ */
@Auditable
void clearTags(NodeRef nodeRef); void clearTags(NodeRef nodeRef);
/** /**
@@ -157,6 +173,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @return boolean true if node is a tag scope, false otherwise * @return boolean true if node is a tag scope, false otherwise
*/ */
@NotAuditable
boolean isTagScope(NodeRef nodeRef); boolean isTagScope(NodeRef nodeRef);
/** /**
@@ -164,6 +181,7 @@ public interface TaggingService
* *
* @param nodeRef node reference * @param nodeRef node reference
*/ */
@Auditable
void addTagScope(NodeRef nodeRef); void addTagScope(NodeRef nodeRef);
/** /**
@@ -173,6 +191,7 @@ public interface TaggingService
* @param nodeRef tag scope node reference * @param nodeRef tag scope node reference
* @param async indicates whether the tag scope refresh should happen asynchronously or not * @param async indicates whether the tag scope refresh should happen asynchronously or not
*/ */
@Auditable
void refreshTagScope(NodeRef nodeRef, boolean async); void refreshTagScope(NodeRef nodeRef, boolean async);
/** /**
@@ -182,6 +201,7 @@ public interface TaggingService
* *
* @param nodeRef node reference * @param nodeRef node reference
*/ */
@Auditable
void removeTagScope(NodeRef nodeRef); void removeTagScope(NodeRef nodeRef);
/** /**
@@ -195,6 +215,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @return the 'nearest' tag scope or null if none found * @return the 'nearest' tag scope or null if none found
*/ */
@NotAuditable
TagScope findTagScope(NodeRef nodeRef); TagScope findTagScope(NodeRef nodeRef);
/** /**
@@ -207,6 +228,7 @@ public interface TaggingService
* @param nodeRef node reference * @param nodeRef node reference
* @return List<TagScope> list of tag scopes * @return List<TagScope> list of tag scopes
*/ */
@NotAuditable
List<TagScope> findAllTagScopes(NodeRef nodeRef); List<TagScope> findAllTagScopes(NodeRef nodeRef);
/** /**
@@ -215,6 +237,7 @@ public interface TaggingService
* @param tag tag name * @param tag tag name
* @return List<NodeRef> list of nodes tagged with specified tag, empty of none found * @return List<NodeRef> list of nodes tagged with specified tag, empty of none found
*/ */
@NotAuditable
List<NodeRef> findTaggedNodes(StoreRef storeRef, String tag); List<NodeRef> findTaggedNodes(StoreRef storeRef, String tag);
/** /**
@@ -225,6 +248,7 @@ public interface TaggingService
* @param nodeRef node providing context for the search * @param nodeRef node providing context for the search
* @return List<NodeRef> list of nodes tagged in the context specified, empty if none found * @return List<NodeRef> list of nodes tagged in the context specified, empty if none found
*/ */
@NotAuditable
List<NodeRef> findTaggedNodes(StoreRef storeRef, String tag, NodeRef nodeRef); List<NodeRef> findTaggedNodes(StoreRef storeRef, String tag, NodeRef nodeRef);
} }