Merged 5.2.N (5.2.1) to HEAD (5.2)

127122 cturlica: Merged 5.1.N (5.1.2) to 5.2.N (5.2.1)
      127075 rneamtu: Merged 5.1.1 (5.1.1) to 5.1.N (5.1.2)
         127055 gjames: MNT-16259, MNT-16265. Adding a patch to cleanup the admin user default password.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@127866 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

config/alfresco/messages/patch-service.properties

@@ -391,3 +391,7 @@ patch.spacesBootstrapSmartFolderExample.description=Adds smartFoldersExample.jso
 
 patch.db-v4.2-migrate-activiti-workflows.description=Migrated workflow variables into newly created table.
 patch.db-V5.0-activiti-correct-tenant-id-MSSQL.description=Update Tenant ID column in Activiti for MSSQL
+
+patch.updateAdminUserWhenDefault.description=Update Admin User by removing the default SHA256 and falling back to the MD4 (please consider using BCRYPT instead)
+patch.updateAdminUserWhenDefault.start=Update Admin User SHA256 When default
+patch.updateAdminUserWhenDefault.result=\n\Successfully removed password2 property for ''{0}''.

config/alfresco/patch/patch-services-context.xml

@@ -1454,4 +1454,12 @@
         </property>
     </bean>
 
+    <bean id="patch.updateAdminUserWhenDefault" class="org.alfresco.repo.admin.patch.impl.AdminUserPatch" parent="basePatch" >
+        <property name="id"><value>patch.updateAdminUserWhenDefault</value></property>
+        <property name="description"><value>patch.updateAdminUserWhenDefault.description</value></property>
+        <property name="fixesFromSchema"><value>0</value></property>
+        <property name="fixesToSchema"><value>10002</value></property>
+        <property name="targetSchema"><value>10003</value></property>
+        <property name="authenticationContextManager" ref="Authentication" />
+    </bean>
 </beans>

config/alfresco/version.properties

@@ -23,4 +23,4 @@ version.build=r@scm-revision@-b@build-number@
 
 # Schema number
 
-version.schema=10002
+version.schema=10003

source/java/org/alfresco/repo/admin/patch/impl/AdminUserPatch.java

@@ -0,0 +1,122 @@
+/*
+ * #%L
+ * Alfresco Repository
+ * %%
+ * Copyright (C) 2005 - 2016 Alfresco Software Limited
+ * %%
+ * This file is part of the Alfresco software. 
+ * If the software was purchased under a paid Alfresco license, the terms of 
+ * the paid license agreement will prevail.  Otherwise, the software is 
+ * provided under the following open source license terms:
+ * 
+ * Alfresco is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ * 
+ * Alfresco is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
+ * #L%
+ */
+package org.alfresco.repo.admin.patch.impl;
+
+import org.alfresco.model.ContentModel;
+import org.alfresco.repo.admin.patch.AbstractPatch;
+import org.alfresco.repo.management.subsystems.ChildApplicationContextManager;
+import org.alfresco.repo.security.authentication.AuthenticationUtil;
+import org.alfresco.repo.security.authentication.RepositoryAuthenticationDao;
+import org.alfresco.service.cmr.repository.NodeRef;
+import org.alfresco.service.namespace.QName;
+import org.alfresco.util.ParameterCheck;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.springframework.beans.factory.InitializingBean;
+import org.springframework.beans.factory.NoSuchBeanDefinitionException;
+import org.springframework.context.ApplicationContext;
+import org.springframework.extensions.surf.util.I18NUtil;
+
+import java.io.Serializable;
+import java.util.Map;
+
+/**
+ * Patch to reset the admin user's default password to favour md4 instead of sha254
+ *
+ * This patch is run per tenant (that's the default for AbstractPatch)
+ *
+ * @author Gethin James
+ */
+public class AdminUserPatch extends AbstractPatch implements InitializingBean {
+
+    private static final String MSG_START = "patch.updateAdminUserWhenDefault.start";
+    private static final String MSG_RESULT = "patch.updateAdminUserWhenDefault.result";
+    private static final String MSG_NO_ACTION ="patch.updateAdminUserWhenDefault.noaction";
+    private static final Log logger = LogFactory.getLog(AdminUserPatch.class);
+
+    public static String DEFAULT_SHA = "f378d5d7b947d5c26f478e21819e7ec3a6668c8149b050d086c64447bc40173b";
+
+    private ChildApplicationContextManager authenticationContextManager;
+    private RepositoryAuthenticationDao authenticationDao;
+
+    public void setAuthenticationContextManager(ChildApplicationContextManager authenticationContextManager) {
+        this.authenticationContextManager = authenticationContextManager;
+    }
+
+    @Override
+    protected String applyInternal() throws Exception {
+
+        StringBuilder result = new StringBuilder(I18NUtil.getMessage(MSG_START));
+
+        //If there's no RepositoryAuthenticationDao then there's no need for this patch to run
+        if (authenticationDao != null)
+        {
+            final String adminUsername = AuthenticationUtil.getAdminUserName();
+            final NodeRef userNodeRef  = authenticationDao.getUserOrNull(adminUsername);
+
+            if (userNodeRef!= null)
+            {
+                Map<QName, Serializable> userProperties = nodeService.getProperties(userNodeRef);
+                String sha256 = (String) userProperties.get(ContentModel.PROP_PASSWORD_SHA256);
+                if (DEFAULT_SHA.equals(sha256))
+                {
+                    // I am not going to disable any behaviours because authenticationDao.onUpdateUserProperties fires
+                    // that removes Authentication from the cache
+
+                    if (logger.isDebugEnabled())
+                    {
+                        logger.debug("Removing password sha256 hash for user: " + adminUsername);
+                    }
+
+                    // The SHA256 is set to the default (i.e. admin) so i will remove it
+                    nodeService.removeProperty(userNodeRef, ContentModel.PROP_PASSWORD_SHA256);
+
+                    result.append(I18NUtil.getMessage(MSG_RESULT,adminUsername));
+
+                }
+            }
+        }
+
+        return result.toString();
+    }
+
+    @Override
+    public void afterPropertiesSet() throws Exception {
+        ParameterCheck.mandatory("authenticationContextManager", authenticationContextManager);
+
+        //Attempt to get RepositoryAuthenticationDao from the subsystem
+        for(String contextName : authenticationContextManager.getInstanceIds())
+        {
+            ApplicationContext ctx = authenticationContextManager.getApplicationContext(contextName);
+            try
+            {
+                authenticationDao = (RepositoryAuthenticationDao)
+                        ctx.getBean(RepositoryAuthenticationDao.class);
+            } catch(NoSuchBeanDefinitionException e) {}
+        }
+
+    }
+}