inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

RM-6852 Fix inconsistencies in V1 response codes

Browse Source
This commit is contained in:
Sara Aspery
2019-05-23 12:44:20 +01:00
parent 12ad79c3de
commit ace859a087
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
rm-community/rm-community-repo/unit-test/java/org/alfresco/module/org_alfresco_module_rm/record/RecordServiceImplUnitTest.java
View File

@@ -50,6 +50,7 @@ import org.alfresco.model.ContentModel;
import org.alfresco.module.org_alfresco_module_rm.capability.RMPermissionModel;
import org.alfresco.module.org_alfresco_module_rm.disposition.DispositionSchedule;
import org.alfresco.module.org_alfresco_module_rm.test.util.BaseUnitTest;
import org.alfresco.repo.node.integrity.IntegrityException;
import org.alfresco.repo.policy.Behaviour;
import org.alfresco.repo.security.permissions.AccessDeniedException;
import org.alfresco.service.cmr.repository.ChildAssociationRef;
@@ -77,6 +78,7 @@ public class RecordServiceImplUnitTest extends BaseUnitTest
private NodeRef dmNodeRef;
private NodeRef unfiledRecordContainer;
private NodeRef frozenRecordFolder;
private NodeRef closedRecordFolder;
private ChildAssociationRef parentAssoc;
private static QName TYPE_MY_FILE_PLAN = generateQName();
@@ -96,6 +98,7 @@ public class RecordServiceImplUnitTest extends BaseUnitTest
dmNodeRef = generateNodeRef(TYPE_CONTENT);
unfiledRecordContainer = generateNodeRef(TYPE_UNFILED_RECORD_CONTAINER);
frozenRecordFolder = generateNodeRef(TYPE_RECORD_FOLDER);
closedRecordFolder = generateNodeRef(TYPE_RECORD_FOLDER);
parentAssoc = mock(ChildAssociationRef.class);
// set-up node service
@@ -599,6 +602,20 @@ public class RecordServiceImplUnitTest extends BaseUnitTest
recordService.createRecord(filePlan, dmNodeRef, frozenRecordFolder);
}
/**
* Given a file that is not yet a record
* When I create the record specifying a closed destination record folder
* Then an exception is thrown
*/
@Test(expected= IntegrityException.class)
public void createRecordIntoClosedRecordFolder()
{
mocksForRecordCreation();
// create the record
recordService.createRecord(filePlan, dmNodeRef, closedRecordFolder);
}
/* Helper method to set up the mocks for record creation */
private void mocksForRecordCreation()
{
@@ -612,6 +629,7 @@ public class RecordServiceImplUnitTest extends BaseUnitTest
when(mockedFilePlanService.isFilePlan(nonStandardFilePlan)).thenReturn(true);
when(mockedFreezeService.isFrozen(recordFolder)).thenReturn(false);
when(mockedFreezeService.isFrozen(frozenRecordFolder)).thenReturn(true);
when(mockedNodeService.getProperty(closedRecordFolder, PROP_IS_CLOSED)).thenReturn(true);
// mocks for policies
doNothing().when(recordService).invokeBeforeRecordDeclaration(dmNodeRef);