From aff70c96370ed5111e0582741f29befcef7d09f7 Mon Sep 17 00:00:00 2001
From: Tuna Aksoy <tuna.aksoy@alfresco.com>
Date: Tue, 27 May 2014 22:40:52 +0000
Subject: [PATCH] Fixed major issues ("Bad practice - Method with Boolean
 return type returns explicit null") reported in Sonar

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@71961 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../job/NotifyOfRecordsDueForReviewJobExecuter.java           | 4 ++--
 .../org_alfresco_module_rm/role/FilePlanRoleServiceImpl.java  | 2 +-
 .../security/FilePlanPermissionServiceImpl.java               | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/NotifyOfRecordsDueForReviewJobExecuter.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/NotifyOfRecordsDueForReviewJobExecuter.java
index 376f00deaa..3297f7b3ee 100644
--- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/NotifyOfRecordsDueForReviewJobExecuter.java
+++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/NotifyOfRecordsDueForReviewJobExecuter.java
@@ -104,10 +104,10 @@ public class NotifyOfRecordsDueForReviewJobExecuter extends RecordsManagementJob
                 if(resultNodes.size() != 0)
                 {
                     //Send the email message - but we must not retry since email is not transactional
-                    RetryingTransactionCallback<Boolean> txCallbackSendEmail = new RetryingTransactionCallback<Boolean>()
+                    RetryingTransactionCallback<Void> txCallbackSendEmail = new RetryingTransactionCallback<Void>()
                     {
                         // Set the notification issued property.
-                        public Boolean execute()
+                        public Void execute()
                         {
                             // Send notification
                             recordsManagementNotificationHelper.recordsDueForReviewEmailNotification(resultNodes);
diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/role/FilePlanRoleServiceImpl.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/role/FilePlanRoleServiceImpl.java
index 9cc1fa5267..07b8a9abe6 100644
--- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/role/FilePlanRoleServiceImpl.java
+++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/role/FilePlanRoleServiceImpl.java
@@ -792,7 +792,7 @@ public class FilePlanRoleServiceImpl implements FilePlanRoleService,
 
         AuthenticationUtil.runAs(new AuthenticationUtil.RunAsWork<Object>()
         {
-            public Boolean doWork()
+            public Void doWork()
             {
                 String roleAuthority = authorityService.getName(AuthorityType.GROUP, getFullRoleName(role, rmRootNode));
                 authorityService.deleteAuthority(roleAuthority);
diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/FilePlanPermissionServiceImpl.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/FilePlanPermissionServiceImpl.java
index 9a3caf209f..6cf34e8d27 100644
--- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/FilePlanPermissionServiceImpl.java
+++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/FilePlanPermissionServiceImpl.java
@@ -396,7 +396,7 @@ public class FilePlanPermissionServiceImpl extends    ServiceBaseImpl
 
         runAsSystem(new AuthenticationUtil.RunAsWork<Object>()
         {
-            public Boolean doWork()
+            public Void doWork()
             {
                 if (isFilePlan(nodeRef))
                 {
@@ -519,7 +519,7 @@ public class FilePlanPermissionServiceImpl extends    ServiceBaseImpl
     {
         runAsSystem(new AuthenticationUtil.RunAsWork<Object>()
         {
-            public Boolean doWork()
+            public Void doWork()
             {
                 // can't delete permissions if inherited (eg hold and transfer containers)
                 if (!permissionService.getInheritParentPermissions(nodeRef))