From b3a5a0518a93252a2563e48e937fce50b465cfcf Mon Sep 17 00:00:00 2001
From: Tuna Aksoy <tuna.aksoy@alfresco.com>
Date: Sat, 22 Mar 2014 16:24:13 +0000
Subject: [PATCH] Fixed major issues reported by sonar (Simplify Boolean
 Return)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@65400 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../org_alfresco_module_rm/util/ServiceBaseImpl.java      | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java
index 4c6e5ee492..ddd5eeb0e6 100644
--- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java
+++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java
@@ -101,14 +101,12 @@ public class ServiceBaseImpl implements RecordsManagementModel
     {
         ParameterCheck.mandatory("nodeRef", nodeRef);
 
+        boolean isHold = false;
         if (nodeService.exists(nodeRef) && instanceOf(nodeRef, TYPE_HOLD))
         {
-            return true;
-        }
-        else
-        {
-            return false;
+            isHold = true;
         }
+        return isHold;
     }
 
     /**