mirror of
https://github.com/Alfresco/alfresco-community-repo.git
synced 2025-07-24 17:32:48 +00:00
Merged V2.1 to HEAD
6466: Xml metadata. Support for pulling collections of values from XML 6470: Fix for AWC-1321 - Using zero as items per page gives error for Alfresco repos in OpenSearch 6471: Fix for AWC-1496 - OpenSearch dashlet can get in a state where search queries are not executed 6472: Fix for AWC-1495. Searching additional attributes now working correctly for folders. 6473: Fix for AR-1251 (Version error when saving new content via CIFS) 6474: Updated bundles and installers - added missing files back into Linux bundle 6475: LDAP and chainging authentication Resolved conflicted state of 'root\projects\repository\source\java\org\alfresco\repo\security\authentication\AuthenticationUtil.java' 6477: XForms WCM-696. 6478: Fix for WCM-567 (IndexOutOfBoundsException when stepping through wizard rapidly) 6480: Fix to issue when removing locks on directories. 6481: Updated installer and config wizard to fix download option and config behaviour when called from installer. 6482: Fix for WCM-1229 (properties sheet does not refresh) 6483: Fix for AR-1511 6484: Fix for AR-1351 6485: Missed a unit test update git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@6737 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
@@ -26,49 +26,65 @@ package org.alfresco.repo.ownable.impl;
|
||||
|
||||
import java.io.Serializable;
|
||||
import java.util.HashMap;
|
||||
import java.util.Map;
|
||||
|
||||
import org.alfresco.model.ContentModel;
|
||||
import org.alfresco.repo.cache.SimpleCache;
|
||||
import org.alfresco.repo.node.NodeServicePolicies;
|
||||
import org.alfresco.repo.policy.JavaBehaviour;
|
||||
import org.alfresco.repo.policy.PolicyComponent;
|
||||
import org.alfresco.service.cmr.repository.ChildAssociationRef;
|
||||
import org.alfresco.service.cmr.repository.NodeRef;
|
||||
import org.alfresco.service.cmr.repository.NodeService;
|
||||
import org.alfresco.service.cmr.repository.datatype.DefaultTypeConverter;
|
||||
import org.alfresco.service.cmr.security.AuthenticationService;
|
||||
import org.alfresco.service.cmr.security.OwnableService;
|
||||
import org.alfresco.service.namespace.NamespaceService;
|
||||
import org.alfresco.service.namespace.QName;
|
||||
import org.alfresco.util.EqualsHelper;
|
||||
import org.springframework.beans.factory.InitializingBean;
|
||||
|
||||
/**
|
||||
* Ownership service support. Use in permissions framework as dynamic authority.
|
||||
* Ownership service support. Use in permissions framework as dynamic authority.
|
||||
*
|
||||
* @author Andy Hind
|
||||
*/
|
||||
public class OwnableServiceImpl implements OwnableService, InitializingBean
|
||||
public class OwnableServiceImpl implements OwnableService, InitializingBean, NodeServicePolicies.OnAddAspectPolicy, NodeServicePolicies.OnUpdatePropertiesPolicy,
|
||||
NodeServicePolicies.OnRemoveAspectPolicy, NodeServicePolicies.OnDeleteNodePolicy
|
||||
{
|
||||
private NodeService nodeService;
|
||||
|
||||
|
||||
private AuthenticationService authenticationService;
|
||||
|
||||
|
||||
private SimpleCache<NodeRef, String> nodeOwnerCache;
|
||||
|
||||
private PolicyComponent policyComponent;
|
||||
|
||||
public OwnableServiceImpl()
|
||||
{
|
||||
super();
|
||||
}
|
||||
|
||||
// IOC
|
||||
|
||||
|
||||
public void setNodeService(NodeService nodeService)
|
||||
{
|
||||
this.nodeService = nodeService;
|
||||
}
|
||||
|
||||
|
||||
public void setAuthenticationService(AuthenticationService authenticationService)
|
||||
{
|
||||
this.authenticationService = authenticationService;
|
||||
}
|
||||
|
||||
|
||||
public void setPolicyComponent(PolicyComponent policyComponent)
|
||||
{
|
||||
this.policyComponent = policyComponent;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param ownerCache a transactionally-safe cache of node owners
|
||||
* @param ownerCache
|
||||
* a transactionally-safe cache of node owners
|
||||
*/
|
||||
public void setNodeOwnerCache(SimpleCache<NodeRef, String> ownerCache)
|
||||
{
|
||||
@@ -89,14 +105,31 @@ public class OwnableServiceImpl implements OwnableService, InitializingBean
|
||||
{
|
||||
throw new IllegalArgumentException("Property 'nodeOwnerCache' has not been set");
|
||||
}
|
||||
if (policyComponent == null)
|
||||
{
|
||||
throw new IllegalArgumentException("Property 'policyComponent' has not been set");
|
||||
}
|
||||
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onAddAspect"), ContentModel.ASPECT_OWNABLE, new JavaBehaviour(this, "onAddAspect"));
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onUpdateProperties"), ContentModel.ASPECT_OWNABLE, new JavaBehaviour(this, "onUpdateProperties"));
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onRemoveAspect"), ContentModel.ASPECT_OWNABLE, new JavaBehaviour(this,
|
||||
"onRemoveAspect"));
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onDeleteNode"), ContentModel.ASPECT_OWNABLE, new JavaBehaviour(this, "onDeleteNode"));
|
||||
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onAddAspect"), ContentModel.ASPECT_AUDITABLE, new JavaBehaviour(this, "onAddAspect"));
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onUpdateProperties"), ContentModel.ASPECT_AUDITABLE, new JavaBehaviour(this, "onUpdateProperties"));
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onRemoveAspect"), ContentModel.ASPECT_AUDITABLE, new JavaBehaviour(this,
|
||||
"onRemoveAspect"));
|
||||
policyComponent.bindClassBehaviour(QName.createQName(NamespaceService.ALFRESCO_URI, "onDeleteNode"), ContentModel.ASPECT_AUDITABLE, new JavaBehaviour(this, "onDeleteNode"));
|
||||
|
||||
}
|
||||
|
||||
|
||||
// OwnableService implmentation
|
||||
|
||||
|
||||
public String getOwner(NodeRef nodeRef)
|
||||
{
|
||||
String userName = nodeOwnerCache.get(nodeRef);
|
||||
|
||||
|
||||
if (userName == null)
|
||||
{
|
||||
// If ownership is not explicitly set then we fall back to the creator
|
||||
@@ -104,13 +137,13 @@ public class OwnableServiceImpl implements OwnableService, InitializingBean
|
||||
{
|
||||
userName = DefaultTypeConverter.INSTANCE.convert(String.class, nodeService.getProperty(nodeRef, ContentModel.PROP_OWNER));
|
||||
}
|
||||
else if(nodeService.hasAspect(nodeRef, ContentModel.ASPECT_AUDITABLE))
|
||||
else if (nodeService.hasAspect(nodeRef, ContentModel.ASPECT_AUDITABLE))
|
||||
{
|
||||
userName = DefaultTypeConverter.INSTANCE.convert(String.class, nodeService.getProperty(nodeRef, ContentModel.PROP_CREATOR));
|
||||
}
|
||||
nodeOwnerCache.put(nodeRef, userName);
|
||||
}
|
||||
|
||||
|
||||
return userName;
|
||||
}
|
||||
|
||||
@@ -138,4 +171,41 @@ public class OwnableServiceImpl implements OwnableService, InitializingBean
|
||||
{
|
||||
return getOwner(nodeRef) != null;
|
||||
}
|
||||
|
||||
public void onAddAspect(NodeRef nodeRef, QName aspectTypeQName)
|
||||
{
|
||||
nodeOwnerCache.remove(nodeRef);
|
||||
}
|
||||
|
||||
public void onRemoveAspect(NodeRef nodeRef, QName aspectTypeQName)
|
||||
{
|
||||
nodeOwnerCache.remove(nodeRef);
|
||||
}
|
||||
|
||||
public void onDeleteNode(ChildAssociationRef childAssocRef, boolean isNodeArchived)
|
||||
{
|
||||
nodeOwnerCache.remove(childAssocRef.getChildRef());
|
||||
}
|
||||
|
||||
public void onUpdateProperties(NodeRef nodeRef, Map<QName, Serializable> before, Map<QName, Serializable> after)
|
||||
{
|
||||
Serializable pb = before.get(ContentModel.PROP_OWNER);
|
||||
Serializable pa = after.get(ContentModel.PROP_OWNER);
|
||||
|
||||
if (!EqualsHelper.nullSafeEquals(pb, pa))
|
||||
{
|
||||
nodeOwnerCache.remove(nodeRef);
|
||||
return;
|
||||
}
|
||||
|
||||
pb = before.get(ContentModel.PROP_CREATOR);
|
||||
pa = after.get(ContentModel.PROP_CREATOR);
|
||||
|
||||
if (!EqualsHelper.nullSafeEquals(pb, pa))
|
||||
{
|
||||
nodeOwnerCache.remove(nodeRef);
|
||||
return;
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
|
@@ -24,6 +24,9 @@
|
||||
*/
|
||||
package org.alfresco.repo.ownable.impl;
|
||||
|
||||
import java.io.Serializable;
|
||||
import java.util.HashMap;
|
||||
|
||||
import javax.transaction.UserTransaction;
|
||||
|
||||
import junit.framework.TestCase;
|
||||
@@ -40,6 +43,7 @@ import org.alfresco.service.cmr.security.AccessStatus;
|
||||
import org.alfresco.service.cmr.security.AuthenticationService;
|
||||
import org.alfresco.service.cmr.security.OwnableService;
|
||||
import org.alfresco.service.cmr.security.PermissionService;
|
||||
import org.alfresco.service.namespace.QName;
|
||||
import org.alfresco.service.transaction.TransactionService;
|
||||
import org.alfresco.util.ApplicationContextHelper;
|
||||
import org.springframework.context.ApplicationContext;
|
||||
@@ -85,7 +89,7 @@ public class OwnableServiceTest extends TestCase
|
||||
permissionService = (PermissionService) ctx.getBean("permissionService");
|
||||
|
||||
authenticationComponent.setCurrentUser(authenticationComponent.getSystemUserName());
|
||||
authenticationDAO = (MutableAuthenticationDao) ctx.getBean("alfDaoImpl");
|
||||
authenticationDAO = (MutableAuthenticationDao) ctx.getBean("authenticationDao");
|
||||
|
||||
|
||||
TransactionService transactionService = (TransactionService) ctx.getBean(ServiceRegistry.TRANSACTION_SERVICE.getLocalName());
|
||||
@@ -147,6 +151,14 @@ public class OwnableServiceTest extends TestCase
|
||||
assertFalse(nodeService.hasAspect(testNode, ContentModel.ASPECT_OWNABLE));
|
||||
assertTrue(dynamicAuthority.hasAuthority(testNode, "andy"));
|
||||
|
||||
assertEquals("andy", ownableService.getOwner(testNode));
|
||||
|
||||
nodeService.setProperty(testNode, ContentModel.PROP_CREATOR, "woof");
|
||||
assertEquals("woof", ownableService.getOwner(testNode));
|
||||
|
||||
nodeService.setProperty(testNode, ContentModel.PROP_CREATOR, "andy");
|
||||
assertEquals("andy", ownableService.getOwner(testNode));
|
||||
|
||||
permissionService.setInheritParentPermissions(testNode, false);
|
||||
|
||||
|
||||
@@ -189,6 +201,16 @@ public class OwnableServiceTest extends TestCase
|
||||
assertEquals(AccessStatus.ALLOWED, permissionService.hasPermission(testNode, PermissionService.TAKE_OWNERSHIP));
|
||||
assertEquals(AccessStatus.ALLOWED, permissionService.hasPermission(testNode, PermissionService.SET_OWNER));
|
||||
|
||||
nodeService.setProperty(testNode, ContentModel.PROP_OWNER, "muppet");
|
||||
assertEquals("muppet", ownableService.getOwner(testNode));
|
||||
nodeService.removeAspect(testNode, ContentModel.ASPECT_OWNABLE);
|
||||
assertEquals("andy", ownableService.getOwner(testNode));
|
||||
|
||||
HashMap<QName, Serializable> aspectProperties = new HashMap<QName, Serializable>();
|
||||
aspectProperties.put(ContentModel.PROP_OWNER, "muppet");
|
||||
nodeService.addAspect(testNode, ContentModel.ASPECT_OWNABLE, aspectProperties);
|
||||
assertEquals("muppet", ownableService.getOwner(testNode));
|
||||
|
||||
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user