Properly hooked up the on close callback for output streams to AVM Nodes.

Got rid of a now superfluous setContentData() call, and now treat files
with no content url (yet) as having length 0.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/WCM-DEV2/root@3660 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/repo/avm/AVMCrawler.java

@@ -26,6 +26,7 @@ import java.util.List;
 import java.util.Map;
 import java.util.Random;
 
+import org.alfresco.error.AlfrescoRuntimeException;
 import org.alfresco.service.cmr.avm.AVMException;
 import org.alfresco.service.cmr.avm.AVMNodeDescriptor;
 import org.alfresco.service.cmr.avm.AVMService;
@@ -225,6 +226,10 @@ class AVMCrawler implements Runnable
             {
                 return;
             }
+            if (e instanceof AlfrescoRuntimeException)
+            {
+                return;
+            }
             e.printStackTrace(System.err);
             throw new AVMException("Failure", e);
         }

source/java/org/alfresco/repo/avm/AVMNodeService.java

@@ -1037,18 +1037,26 @@ public class AVMNodeService extends AbstractNodeServiceImpl implements NodeServi
         // Invoke policy behaviors.
         invokeBeforeUpdateNode(nodeRef);
         Object [] avmVersionPath = AVMNodeConverter.ToAVMVersionPath(nodeRef);
+        if ((Integer)avmVersionPath[0] >= 0)
+        {
+            throw new InvalidNodeRefException("Read only store.", nodeRef);
+        }
         // TODO Just until we can set built in properties on AVM Nodes.
         if (isBuiltInProperty(qname))
         {
             if (qname.equals(ContentModel.PROP_CONTENT))
             {
+                try
+                {
+                    fAVMService.setContentData((String)avmVersionPath[1], (ContentData)value);
+                }
+                catch (ClassCastException e)
+                {
+                    throw new AVMException("Invalid ContentData.");
+                }
             }
             return;
         }
-        if ((Integer)avmVersionPath[0] >= 0)
-        {
-            throw new InvalidNodeRefException("Read only store.", nodeRef);
-        }
         try
         {
             fAVMService.setNodeProperty((String)avmVersionPath[1], qname, new PropertyValue(null, value));

source/java/org/alfresco/repo/avm/AVMStoreImpl.java

@@ -352,8 +352,9 @@ public class AVMStoreImpl implements AVMStore, Serializable
         NodeRef nodeRef = AVMNodeConverter.ToNodeRef(-1, fName + ":" + path);
         ContentWriter writer = 
             AVMContext.fgInstance.getContentService().getWriter(nodeRef, ContentModel.PROP_CONTENT, true);
-        // TODO This can't perform very well.
+        // TODO This can't perform very well. What this gets down to
-        setContentData(path, writer.getContentData());
+        // is that integration with ContentService is awkward.
+        // setContentData(path, writer.getContentData());
         return writer;
     }
     

source/java/org/alfresco/repo/avm/PlainFileNodeImpl.java

@@ -288,6 +288,10 @@ class PlainFileNodeImpl extends FileNodeImpl implements PlainFileNode
      */
     private long getFileLength()
     {
+        if (fContentURL == null)
+        {
+            return 0L;
+        }
         ContentReader reader = AVMContext.fgInstance.getContentStore().getReader(fContentURL);
         return reader.getSize();
     }