Merged V3.1 to HEAD

13867: Fix for ETHREEOH-986 - long names in Explorer details view show correct width in FF browser
   13869: Fixes for ETHREEOH-1387 and ETHREEOH-1390
   13872: Fix for issue where custom-web-framework-application-context should be optional in the web.xml for web-framework project.
   13909: Fix for ETHREEOH-1684
   13910: Fix for ETHREEOH-1266
   14015: Fixes for ETHREEOH-1864 and ETHREEOH-1840

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@14020 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/web/bean/wcm/SubmitDialog.java

@@ -349,6 +349,15 @@ public class SubmitDialog extends BaseDialogBean
 
              String submitLabel = this.label;
              String submitComment = this.comment;
+             // crop to maximum length
+             if (submitLabel != null && submitLabel.length() > 255)
+             {
+                 submitLabel = submitLabel.substring(0, 255);
+             }
+             if (submitComment != null && submitComment.length() > 255)
+             {
+                 submitComment = submitComment.substring(0, 255);
+             }
 
              // note: always submit via workflow (if no workflow selected, then defaults to direct submit workflow)
              getSandboxService().submitListAssets(sbStoreId, relativePaths,

source/java/org/alfresco/web/ui/common/Utils.java

@@ -568,11 +568,11 @@ public final class Utils extends StringUtils
       if (alt != null)
       {
          alt = Utils.encode(alt);
-         buf.append(" alt='")
+         buf.append(" alt=\"")
             .append(alt)
-            .append("' title='")
+            .append("\" title=\"")
             .append(alt)
-            .append("'");
+            .append("\"");
       }
       else
       {
@@ -653,11 +653,11 @@ public final class Utils extends StringUtils
       if (alt != null)
       {
          alt = Utils.encode(alt);
-         buf.append(" alt='")
+         buf.append(" alt=\"")
             .append(alt)
-            .append("' title='")
+            .append("\" title=\"")
             .append(alt)
-            .append("'");
+            .append('"');
       }
       else
       {

source/java/org/alfresco/web/ui/common/renderer/ActionLinkRenderer.java

@@ -270,9 +270,9 @@ public class ActionLinkRenderer extends BaseRenderer
       }
       if (link.getTooltip() != null)
       {
-         out.write(" title='");
+         out.write(" title=\"");
          out.write(Utils.encode(link.getTooltip()));
-         out.write("'");
+         out.write('"');
       }
       out.write('>');
    }

source/java/org/alfresco/web/ui/common/renderer/ImagePickerRadioRenderer.java

@@ -311,9 +311,9 @@ public class ImagePickerRadioRenderer extends BaseRenderer
       
       if (tooltip != null)
       {
-         out.write(" title='");
+         out.write(" title=\"");
          out.write(Utils.encode(tooltip));
-         out.write("'");
+         out.write('"');
       }
       
       if (onclick != null)
@@ -323,11 +323,6 @@ public class ImagePickerRadioRenderer extends BaseRenderer
          out.write("'");
       }
       
-//            if (item.isDisabled())
-//            {
-//               out.write(" disabled='true'");
-//            }
-      
       out.write(">");
       out.write("</td><td align='center'>");
   

source/web/jsp/browse/browse.jsp

@@ -262,7 +262,7 @@
                         </f:facet>
                         
                         <%-- Primary column for details view mode --%>
-                        <a:column id="col1" primary="true" width="200" style="padding:2px;text-align:left" rendered="#{BrowseBean.browseViewMode == 'details'}">
+                        <a:column id="col1" primary="true" style="padding:2px;text-align:left" rendered="#{BrowseBean.browseViewMode == 'details'}">
                            <f:facet name="header">
                               <a:sortLink id="col1-sort" label="#{msg.name}" value="name" mode="case-insensitive" styleClass="header"/>
                            </f:facet>
@@ -409,7 +409,7 @@
                         </f:facet>
                         
                         <%-- Primary column for details view mode --%>
-                        <a:column id="col10" primary="true" width="200" style="padding:2px;text-align:left" rendered="#{BrowseBean.browseViewMode == 'details'}">
+                        <a:column id="col10" primary="true" style="padding:2px;text-align:left" rendered="#{BrowseBean.browseViewMode == 'details'}">
                            <f:facet name="header">
                               <a:sortLink id="col10-sort" label="#{msg.name}" value="name" mode="case-insensitive" styleClass="header"/>
                            </f:facet>

source/web/jsp/wcm/create-website-wizard/form-workflow.jsp

@@ -43,6 +43,6 @@
    
    <h:panelGrid id="grid-3" columns="2" cellpadding="2" cellspacing="2" style="margin-left:16px">
       <h:outputText id="msg-2" value="&nbsp;#{msg.website_filename_match}" escape="false" />
-      <h:inputText id="in-1" value="#{DialogManager.bean.filenamePattern}" size="70" />
+      <h:inputText id="in-1" value="#{DialogManager.bean.filenamePattern}" maxlength="1024" size="70" />
    </h:panelGrid>
 </h:panelGroup>

source/web/jsp/wcm/submit-dialog.jsp

@@ -81,7 +81,7 @@
    
    <h:graphicImage value="/images/icons/required_field.gif" alt="#{msg.required_field}" />
    <h:outputText value="#{msg.submit_snapshotlabel}:"/>
-   <h:inputText id="label" value="#{DialogManager.bean.label}" maxlength="1024" size="35"
+   <h:inputText id="label" value="#{DialogManager.bean.label}" maxlength="255" size="35"
         onkeyup="javascript:checkButtonState();" />
    <h:graphicImage value="/images/icons/required_field.gif" alt="#{msg.required_field}" />
    <h:outputText value="#{msg.submit_comment}:"/>

source/web/scripts/ajax/common.js

@@ -209,7 +209,7 @@ function onlyDigits(e)
    var keychar = String.fromCharCode(keycode);
    var numcheck = /\d/;
    var dialogForm = $('dialog');
-   if (dialogForm && keyCode == 13)
+   if (dialogForm && keycode == 13)
    { 
       dialogForm.setProperty('onsubmit', 'return false;');
    }