RM-1437, added checks in open/close folder actions to ensure that the rules work correctly in unfiled

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@71003 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Mark Hibbins
2014-05-19 16:13:51 +00:00
parent ede2db0bbf
commit c1d9a7a7ea
2 changed files with 5 additions and 2 deletions

View File

@@ -58,7 +58,8 @@ public class CloseRecordFolderAction extends RMActionExecuterAbstractBase
{ {
boolean result = false; boolean result = false;
if (nodeService.exists(actionedUponNodeRef) && if (nodeService.exists(actionedUponNodeRef) &&
!freezeService.isFrozen(actionedUponNodeRef)) !freezeService.isFrozen(actionedUponNodeRef) &&
!TYPE_UNFILED_RECORD_FOLDER.equals(nodeService.getType(actionedUponNodeRef)))
{ {
result = true; result = true;
} }

View File

@@ -18,6 +18,7 @@
*/ */
package org.alfresco.module.org_alfresco_module_rm.action.impl; package org.alfresco.module.org_alfresco_module_rm.action.impl;
import org.alfresco.model.ContentModel;
import org.alfresco.module.org_alfresco_module_rm.action.RMActionExecuterAbstractBase; import org.alfresco.module.org_alfresco_module_rm.action.RMActionExecuterAbstractBase;
import org.alfresco.service.cmr.action.Action; import org.alfresco.service.cmr.action.Action;
import org.alfresco.service.cmr.repository.ChildAssociationRef; import org.alfresco.service.cmr.repository.ChildAssociationRef;
@@ -50,7 +51,8 @@ public class OpenRecordFolderAction extends RMActionExecuterAbstractBase
protected void executeImpl(Action action, NodeRef actionedUponNodeRef) protected void executeImpl(Action action, NodeRef actionedUponNodeRef)
{ {
if (nodeService.exists(actionedUponNodeRef) && if (nodeService.exists(actionedUponNodeRef) &&
!freezeService.isFrozen(actionedUponNodeRef)) !freezeService.isFrozen(actionedUponNodeRef) &&
!(dictionaryService.isSubClass(nodeService.getType(actionedUponNodeRef), ContentModel.TYPE_CONTENT) && !recordService.isFiled(actionedUponNodeRef)))
{ {
// TODO move re-open logic into a service method // TODO move re-open logic into a service method
// TODO check that the user in question has the correct permission to re-open a records folder // TODO check that the user in question has the correct permission to re-open a records folder