RM-7065 ode review comments

This commit is contained in:
Roxana Lucanu
2020-01-08 20:38:37 +02:00
parent b9fc4e101f
commit c40b4217cf
3 changed files with 138 additions and 3 deletions

View File

@@ -38,6 +38,11 @@ import org.alfresco.service.cmr.repository.NodeRef;
*/
public class RetainAction extends RMDispositionActionExecuterAbstractBase
{
/**
* Action name
*/
public static final String NAME = "retain";
@Override
protected void executeRecordFolderLevelDisposition(Action action, NodeRef recordFolder)
{

View File

@@ -737,6 +737,7 @@ public class DispositionServiceImpl extends ServiceBaseImpl
}
DispositionAction da;
// check if current transaction is a READ ONLY one and if true create the node in a READ WRITE one
if (AlfrescoTransactionSupport.getTransactionReadState().equals(TxnReadState.TXN_READ_ONLY))
{
da =
@@ -747,7 +748,8 @@ public class DispositionServiceImpl extends ServiceBaseImpl
return createDispositionAction(nodeRef, props);
}
}, false, true);
} else
}
else
{
da = createDispositionAction(nodeRef, props);
}
@@ -770,14 +772,14 @@ public class DispositionServiceImpl extends ServiceBaseImpl
*/
private DispositionAction createDispositionAction(final NodeRef nodeRef, Map<QName, Serializable> props)
{
NodeRef result = nodeService.createNode(
NodeRef dispositionActionNodeRef = nodeService.createNode(
nodeRef,
ASSOC_NEXT_DISPOSITION_ACTION,
ASSOC_NEXT_DISPOSITION_ACTION,
TYPE_DISPOSITION_ACTION,
props).getChildRef();
return new DispositionActionImpl(serviceRegistry, result);
return new DispositionActionImpl(serviceRegistry, dispositionActionNodeRef);
}
/**