From c68ce588bb951f8a7b802f76c989ea30779cf661 Mon Sep 17 00:00:00 2001 From: Ross Gale Date: Tue, 15 May 2018 10:12:03 +0100 Subject: [PATCH] RM-6318 code review changes --- .../script/slingshot/SearchUtil.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/SearchUtil.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/SearchUtil.java index e088a559eb..84c5b9a61d 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/SearchUtil.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/SearchUtil.java @@ -43,6 +43,7 @@ import org.alfresco.service.namespace.QName; /** * Parent class for records search utilities + * * @author Ross Gale * @since 2.7 */ @@ -55,6 +56,7 @@ public class SearchUtil /** * Setter for node service + * * @param nodeService Node service */ public void setNodeService(NodeService nodeService) @@ -64,6 +66,7 @@ public class SearchUtil /** * Use a container node ref and return the nodeIds of the contents + * * @param nodeRef container * @return list of nodeIds */ @@ -84,13 +87,15 @@ public class SearchUtil NodeRef rootNodeRef = nodeService.getRootNode(STORE_REF_WORKSPACE_SPACESSTORE); List assocRefs = nodeService.getChildAssocs(rootNodeRef, ASSOC_CHILDREN, container); - if (assocRefs.size() == 0) + if (assocRefs.isEmpty()) { return nodeService.createNode(rootNodeRef, ASSOC_CHILDREN, container, TYPE_CONTAINER).getChildRef(); - } else if (assocRefs.size() != 1) + } + else if (assocRefs.size() != 1) { throw new AlfrescoRuntimeException("Only one container is allowed."); - } else + } + else { return assocRefs.iterator().next().getChildRef(); }