inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

PRODENG-276: Resolved peer review comments.

Browse Source
This commit is contained in:
Jamal Kaabi-Mofrad
2024-05-30 17:29:04 +01:00
parent a9a911e77f
commit c82e8d652a
7 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
repository/src/main/java/org/alfresco/repo/security/permissions/dynamic/ServiceAccountAuthority.java
View File

@@ -28,7 +28,7 @@ package org.alfresco.repo.security.permissions.dynamic;
import java.util.Optional; import java.util.Optional;
import java.util.Set; import java.util.Set;
import org.alfresco.repo.sa.ServiceAccountRegistry; import org.alfresco.repo.serviceaccount.ServiceAccountRegistry;
import org.alfresco.repo.security.permissions.DynamicAuthority; import org.alfresco.repo.security.permissions.DynamicAuthority;
import org.alfresco.repo.security.permissions.PermissionReference; import org.alfresco.repo.security.permissions.PermissionReference;
import org.alfresco.service.cmr.repository.NodeRef; import org.alfresco.service.cmr.repository.NodeRef;

2
repository/src/main/java/org/alfresco/repo/sa/ServiceAccountRegistry.java → repository/src/main/java/org/alfresco/repo/serviceaccount/ServiceAccountRegistry.java
View File

@@ -23,7 +23,7 @@
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>. * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
* #L% * #L%
*/ */
package org.alfresco.repo.sa; package org.alfresco.repo.serviceaccount;
import java.util.Optional; import java.util.Optional;
import java.util.Set; import java.util.Set;

2
repository/src/main/java/org/alfresco/repo/sa/ServiceAccountRegistryImpl.java → repository/src/main/java/org/alfresco/repo/serviceaccount/ServiceAccountRegistryImpl.java
View File

@@ -23,7 +23,7 @@
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>. * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
* #L% * #L%
*/ */
package org.alfresco.repo.sa; package org.alfresco.repo.serviceaccount;
import java.util.Locale; import java.util.Locale;
import java.util.Optional; import java.util.Optional;

2
repository/src/main/resources/alfresco/authority-services-context.xml
View File

@@ -143,7 +143,7 @@
</property> </property>
</bean> </bean>
<bean id="serviceAccountRegistry" class="org.alfresco.repo.sa.ServiceAccountRegistryImpl"> <bean id="serviceAccountRegistry" class="org.alfresco.repo.serviceaccount.ServiceAccountRegistryImpl">
<property name="globalProperties" ref="global-properties"/> <property name="globalProperties" ref="global-properties"/>
</bean> </bean>

2
repository/src/test/java/org/alfresco/AllUnitTestsSuite.java
View File

@@ -262,7 +262,7 @@ import org.junit.runners.Suite;
org.alfresco.util.schemacomp.SchemaDifferenceHelperUnitTest.class, org.alfresco.util.schemacomp.SchemaDifferenceHelperUnitTest.class,
org.alfresco.repo.tagging.TaggingServiceImplUnitTest.class, org.alfresco.repo.tagging.TaggingServiceImplUnitTest.class,
org.alfresco.repo.sa.ServiceAccountRegistryImplTest.class org.alfresco.repo.serviceaccount.ServiceAccountRegistryImplTest.class
}) })
public class AllUnitTestsSuite public class AllUnitTestsSuite
{ {

8
repository/src/test/java/org/alfresco/repo/security/permissions/dynamic/ServiceAccountRoleTest.java
View File

@@ -286,7 +286,7 @@ public class ServiceAccountRoleTest
} }
@Test @Test
public void normalUserCreateAssociationsAccessShouldBeDenied() public void normalUserAssociationAccessShouldBeDenied()
{ {
assertAccessDenied(NORMAL_USER, PermissionService.READ_ASSOCIATIONS); assertAccessDenied(NORMAL_USER, PermissionService.READ_ASSOCIATIONS);
assertAccessDenied(NORMAL_USER, PermissionService.CREATE_ASSOCIATIONS); assertAccessDenied(NORMAL_USER, PermissionService.CREATE_ASSOCIATIONS);
@@ -294,7 +294,7 @@ public class ServiceAccountRoleTest
} }
@Test @Test
public void editorSaCreateAssociationsAccessShouldBeDenied() public void editorSaAssociationAccessShouldBeDenied()
{ {
assertAccessDenied(EDITOR_SA, PermissionService.READ_ASSOCIATIONS); assertAccessDenied(EDITOR_SA, PermissionService.READ_ASSOCIATIONS);
assertAccessDenied(EDITOR_SA, PermissionService.CREATE_ASSOCIATIONS); assertAccessDenied(EDITOR_SA, PermissionService.CREATE_ASSOCIATIONS);
@@ -302,7 +302,7 @@ public class ServiceAccountRoleTest
} }
@Test @Test
public void collaboratorSaCreateAssociationsAccessShouldBeDenied() public void collaboratorSaAssociationAccessShouldBeDenied()
{ {
assertAccessDenied(COLLABORATOR_SA, PermissionService.READ_ASSOCIATIONS); assertAccessDenied(COLLABORATOR_SA, PermissionService.READ_ASSOCIATIONS);
assertAccessDenied(COLLABORATOR_SA, PermissionService.CREATE_ASSOCIATIONS); assertAccessDenied(COLLABORATOR_SA, PermissionService.CREATE_ASSOCIATIONS);
@@ -310,7 +310,7 @@ public class ServiceAccountRoleTest
} }
@Test @Test
public void adminSaCreateAssociationsAccessShouldBeAllowed() public void adminSaAssociationAccessShouldBeAllowed()
{ {
assertAccessAllowed(ADMIN_SA, PermissionService.READ_ASSOCIATIONS); assertAccessAllowed(ADMIN_SA, PermissionService.READ_ASSOCIATIONS);
assertAccessAllowed(ADMIN_SA, PermissionService.CREATE_ASSOCIATIONS); assertAccessAllowed(ADMIN_SA, PermissionService.CREATE_ASSOCIATIONS);

2
repository/src/test/java/org/alfresco/repo/sa/ServiceAccountRegistryImplTest.java → repository/src/test/java/org/alfresco/repo/serviceaccount/ServiceAccountRegistryImplTest.java
View File

@@ -23,7 +23,7 @@
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>. * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
* #L% * #L%
*/ */
package org.alfresco.repo.sa; package org.alfresco.repo.serviceaccount;
import static org.alfresco.service.cmr.security.PermissionService.ADMIN_SVC_AUTHORITY; import static org.alfresco.service.cmr.security.PermissionService.ADMIN_SVC_AUTHORITY;
import static org.alfresco.service.cmr.security.PermissionService.COLLABORATOR_SVC_AUTHORITY; import static org.alfresco.service.cmr.security.PermissionService.COLLABORATOR_SVC_AUTHORITY;