inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

RM-2812 Incompatibility in deprecated methods is still a problem.

Browse Source 
Remove the checks for deprecation, because deprecated methods/classes may
still be used.
This commit is contained in:
Tom Page
2016-05-04 14:34:18 +01:00
parent 04cac7b9e7
commit c8b766afcd
1 changed files with 6 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
rm-community/rm-community-repo/unit-test/java/org/alfresco/module/org_alfresco_module_rm/api/PublicAPITestUtil.java
View File

@@ -30,7 +30,6 @@ package org.alfresco.module.org_alfresco_module_rm.api;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
import java.lang.reflect.AnnotatedElement;
import java.lang.reflect.Constructor; import java.lang.reflect.Constructor;
import java.lang.reflect.Executable; import java.lang.reflect.Executable;
import java.lang.reflect.Field; import java.lang.reflect.Field;
@@ -159,45 +158,42 @@ public class PublicAPITestUtil
{ {
for (Method method : initialClass.getDeclaredMethods()) for (Method method : initialClass.getDeclaredMethods())
{ {
if (isVisibleToExtender(method.getModifiers()) && !isDeprecated(method)) if (isVisibleToExtender(method.getModifiers()))
{ {
referencedClasses.addAll(getClassesFromMethod(method)); referencedClasses.addAll(getClassesFromMethod(method));
} }
} }
for (Constructor<?> constructor : initialClass.getDeclaredConstructors()) for (Constructor<?> constructor : initialClass.getDeclaredConstructors())
{ {
if (isVisibleToExtender(constructor.getModifiers()) && !isDeprecated(constructor)) if (isVisibleToExtender(constructor.getModifiers()))
{ {
referencedClasses.addAll(getClassesFromConstructor(constructor)); referencedClasses.addAll(getClassesFromConstructor(constructor));
} }
} }
for (Field field : initialClass.getDeclaredFields()) for (Field field : initialClass.getDeclaredFields())
{ {
if (isVisibleToExtender(field.getModifiers()) && !isDeprecated(field)) if (isVisibleToExtender(field.getModifiers()))
{ {
referencedClasses.addAll(getClassesFromField(field)); referencedClasses.addAll(getClassesFromField(field));
} }
} }
for (Class<?> clazz : initialClass.getDeclaredClasses()) for (Class<?> clazz : initialClass.getDeclaredClasses())
{ {
if (isVisibleToExtender(clazz.getModifiers()) && !isDeprecated(clazz)) if (isVisibleToExtender(clazz.getModifiers()))
{ {
referencedClasses.addAll(getReferencedClassesFromClass(clazz, consideredClasses)); referencedClasses.addAll(getReferencedClassesFromClass(clazz, consideredClasses));
} }
} }
if (initialClass.getSuperclass() != null && !isDeprecated(initialClass.getSuperclass())) if (initialClass.getSuperclass() != null)
{ {
referencedClasses referencedClasses
.addAll(getReferencedClassesFromClass(initialClass.getSuperclass(), consideredClasses)); .addAll(getReferencedClassesFromClass(initialClass.getSuperclass(), consideredClasses));
} }
for (Class<?> clazz : initialClass.getInterfaces()) for (Class<?> clazz : initialClass.getInterfaces())
{
if (!isDeprecated(clazz))
{ {
referencedClasses.addAll(getReferencedClassesFromClass(clazz, consideredClasses)); referencedClasses.addAll(getReferencedClassesFromClass(clazz, consideredClasses));
} }
} }
}
return referencedClasses; return referencedClasses;
} }
@@ -357,18 +353,6 @@ public class PublicAPITestUtil
return returnClasses; return returnClasses;
} }
/**
* Check if the element is deprecated. Deprecated elements do not need to be part of the public API, even if they
* are visible to extenders.
*
* @param element The element to check.
* @return {@code true} if the element has been annotated as deprecated.
*/
private static boolean isDeprecated(AnnotatedElement element)
{
return (element.getDeclaredAnnotation(Deprecated.class) != null);
}
/** /**
* Check if a class is within org.alfresco, and so whether it could potentially be part of the public API. * Check if a class is within org.alfresco, and so whether it could potentially be part of the public API.
* *