Fixed major issues ("Illegal Throws") reported in Sonar

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@71958 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/action/RecordsManagementActionConditionEvaluatorAbstractBase.java

@@ -93,7 +93,7 @@ public abstract class RecordsManagementActionConditionEvaluatorAbstractBase exte
             {
                 RetryingTransactionCallback<Void> callback = new RetryingTransactionCallback<Void>()
                 {
-                    public Void execute() throws Throwable
+                    public Void execute()
                     {
                         recordsManagementActionService.register(RecordsManagementActionConditionEvaluatorAbstractBase.this);
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/audit/extractor/AuthenticatedUserRolesDataExtractor.java

@@ -84,7 +84,7 @@ public final class AuthenticatedUserRolesDataExtractor extends AbstractDataExtra
     /**
      * @see org.alfresco.repo.audit.extractor.DataExtractor#extractData(java.io.Serializable)
      */
-    public Serializable extractData(Serializable value) throws Throwable
+    public Serializable extractData(Serializable value)
     {
         NodeRef nodeRef = (NodeRef) value;
         String user = AuthenticationUtil.getFullyAuthenticatedUser();

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/audit/extractor/FilePlanIdentifierDataExtractor.java

@@ -58,7 +58,7 @@ public final class FilePlanIdentifierDataExtractor extends AbstractDataExtractor
         return nodeService.hasAspect((NodeRef)data, RecordsManagementModel.ASPECT_RECORD_COMPONENT_ID);
     }
 
-    public Serializable extractData(Serializable value) throws Throwable
+    public Serializable extractData(Serializable value)
     {
         NodeRef nodeRef = (NodeRef) value;
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/audit/extractor/FilePlanNamePathDataExtractor.java

@@ -75,7 +75,7 @@ public final class FilePlanNamePathDataExtractor extends AbstractDataExtractor
     /**
      * @see org.alfresco.repo.audit.extractor.DataExtractor#extractData(java.io.Serializable)
      */
-    public Serializable extractData(Serializable value) throws Throwable
+    public Serializable extractData(Serializable value)
     {
         NodeRef nodeRef = (NodeRef) value;
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/audit/extractor/FilePlanNodeRefPathDataExtractor.java

@@ -68,7 +68,7 @@ public final class FilePlanNodeRefPathDataExtractor extends AbstractDataExtracto
         return nodeService.hasAspect((NodeRef)data, RecordsManagementModel.ASPECT_FILE_PLAN_COMPONENT);
     }
 
-    public Serializable extractData(Serializable value) throws Throwable
+    public Serializable extractData(Serializable value)
     {
         NodeRef nodeRef = (NodeRef) value;
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/bootstrap/RecordsManagementBootstrap.java

@@ -77,7 +77,7 @@ public class RecordsManagementBootstrap extends AbstractLifecycleBean
             {
                 RetryingTransactionCallback<Void> callback = new RetryingTransactionCallback<Void>()
                 {
-                    public Void execute() throws Throwable
+                    public Void execute()
                     {
                         // initialise caveat config
                         caveatConfigService.init();

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/email/CustomEmailMappingServiceImpl.java

@@ -392,7 +392,7 @@ public class CustomEmailMappingServiceImpl extends AbstractLifecycleBean impleme
             {
                 RetryingTransactionCallback<Void> callback = new RetryingTransactionCallback<Void>()
                 {
-                    public Void execute() throws Throwable
+                    public Void execute()
                     {
                         try
                         {

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/DispositionLifecycleJobExecuter.java

@@ -173,7 +173,7 @@ public class DispositionLifecycleJobExecuter extends RecordsManagementJobExecute
 
                     RetryingTransactionCallback<Boolean> processTranCB = new RetryingTransactionCallback<Boolean>()
                     {
-                        public Boolean execute() throws Throwable
+                        public Boolean execute()
                         {
                             final String dispAction = (String) nodeService.getProperty(currentNode, RecordsManagementModel.PROP_DISPOSITION_ACTION);
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/NotifyOfRecordsDueForReviewJobExecuter.java

@@ -107,7 +107,7 @@ public class NotifyOfRecordsDueForReviewJobExecuter extends RecordsManagementJob
                     RetryingTransactionCallback<Boolean> txCallbackSendEmail = new RetryingTransactionCallback<Boolean>()
                     {
                         // Set the notification issued property.
-                        public Boolean execute() throws Throwable
+                        public Boolean execute()
                         {
                             // Send notification
                             recordsManagementNotificationHelper.recordsDueForReviewEmailNotification(resultNodes);
@@ -119,7 +119,7 @@ public class NotifyOfRecordsDueForReviewJobExecuter extends RecordsManagementJob
                     RetryingTransactionCallback<Boolean> txUpdateNodesCallback = new RetryingTransactionCallback<Boolean>()
                     {
                         // Set the notification issued property.
-                        public Boolean execute() throws Throwable
+                        public Boolean execute()
                         {
                             for (NodeRef node : resultNodes)
                             {

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/PublishUpdatesJobExecuter.java

@@ -201,7 +201,7 @@ public class PublishUpdatesJobExecuter extends RecordsManagementJobExecuter
             new RetryingTransactionHelper.RetryingTransactionCallback<List<NodeRef>>()
             {
                 @Override
-                public List<NodeRef> execute() throws Throwable
+                public List<NodeRef> execute()
                 {
                     // Build the query string
                     StringBuilder sb = new StringBuilder();
@@ -251,7 +251,7 @@ public class PublishUpdatesJobExecuter extends RecordsManagementJobExecuter
             new RetryingTransactionHelper.RetryingTransactionCallback<Void>()
             {
                 @Override
-                public Void execute() throws Throwable
+                public Void execute()
                 {
                     if (logger.isDebugEnabled())
                     {
@@ -287,7 +287,7 @@ public class PublishUpdatesJobExecuter extends RecordsManagementJobExecuter
             new RetryingTransactionHelper.RetryingTransactionCallback<Void>()
             {
                 @Override
-                public Void execute() throws Throwable
+                public Void execute()
                 {
                     behaviourFilter.disableBehaviour(nodeRef, TYPE_DISPOSITION_ACTION_DEFINITION);
                     try
@@ -358,7 +358,7 @@ public class PublishUpdatesJobExecuter extends RecordsManagementJobExecuter
             new RetryingTransactionHelper.RetryingTransactionCallback<Void>()
             {
                 @Override
-                public Void execute() throws Throwable
+                public Void execute()
                 {
                     behaviourFilter.disableBehaviour(nodeRef, TYPE_DISPOSITION_ACTION_DEFINITION);
                     try

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/RecordsManagementJobExecuter.java

@@ -63,7 +63,7 @@ public abstract class RecordsManagementJobExecuter implements RecordsManagementM
             retryingTransactionHelper.doInTransaction(new RetryingTransactionCallback<Void>()
             {
                 @Override
-                public Void execute() throws Throwable
+                public Void execute()
                 {
                     executeImpl();
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/AbstractModulePatch.java

@@ -233,7 +233,7 @@ public abstract class AbstractModulePatch implements ModulePatch, BeanNameAware
          * @see org.alfresco.repo.transaction.RetryingTransactionHelper.RetryingTransactionCallback#execute()
          */
         @Override
-        public Void execute() throws Throwable
+        public Void execute()
         {
             applyInternal();
             return null;

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/ModulePatchExecuterImpl.java

@@ -97,7 +97,7 @@ public class ModulePatchExecuterImpl extends   AbstractModuleComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executeInternal() throws Throwable
+    protected void executeInternal()
     {
         // get current schema version
         int currentSchema = getCurrentSchema();

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/compatibility/ModulePatchComponent.java

@@ -85,7 +85,7 @@ public abstract class ModulePatchComponent extends AbstractModuleComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executeInternal() throws Throwable
+    protected void executeInternal()
     {
         try
         {
@@ -98,7 +98,7 @@ public abstract class ModulePatchComponent extends AbstractModuleComponent
             retryingTransactionHelper.doInTransaction(new RetryingTransactionHelper.RetryingTransactionCallback<Void>()
             {
                 @Override
-                public Void execute() throws Throwable
+                public Void execute()
                 {
                     behaviourFilter.disableBehaviour();
                     try
@@ -132,8 +132,6 @@ public abstract class ModulePatchComponent extends AbstractModuleComponent
 
     /**
      * Execute patch work.
-     *
-     * @throws Throwable
      */
-    protected abstract void executePatch() throws Throwable;
+    protected abstract void executePatch();
 }

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v20/NotificationTemplatePatch.java

@@ -126,7 +126,7 @@ public class NotificationTemplatePatch extends ModulePatchComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         NodeRef supersededTemplate = notificationHelper.getSupersededTemplate();
         updateTemplate(supersededTemplate, PATH_SUPERSEDED);

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v20/RMv2FilePlanNodeRefPatch.java

@@ -106,7 +106,7 @@ public class RMv2FilePlanNodeRefPatch extends ModulePatchComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
     	Pair<Long, QName> aspectPair = qnameDAO.getQName(RecordsManagementModel.ASPECT_FILE_PLAN_COMPONENT);
         if (aspectPair != null)

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v20/RMv2ModelPatch.java

@@ -66,7 +66,7 @@ public class RMv2ModelPatch extends ModulePatchComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         updateQName(QName.createQName(DOD_URI, "filePlan"), TYPE_FILE_PLAN, "TYPE");
         updateQName(QName.createQName(DOD_URI, "recordCategory"), TYPE_RECORD_CATEGORY, "TYPE");

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v20/RMv2SavedSearchPatch.java

@@ -82,7 +82,7 @@ public class RMv2SavedSearchPatch extends ModulePatchComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         if (siteService.getSite(RM_SITE_ID) != null)
         {

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/NotificationTemplatePatch_v21.java

@@ -82,7 +82,7 @@ public class NotificationTemplatePatch_v21 extends RMv21PatchComponent
     }
 
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         NodeRef nodeRef = new NodeRef(StoreRef.STORE_REF_WORKSPACE_SPACESSTORE, CONFIG_NODEID);
         // get the parent node

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21BehaviorScriptsPatch.java

@@ -85,7 +85,7 @@ public class RMv21BehaviorScriptsPatch extends RMv21PatchComponent implements Be
      * @see org.alfresco.module.org_alfresco_module_rm.patch.compatibility.ModulePatchComponent#executePatch()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         // check that the rm config root has been correctly bootstrapped
         if (!nodeService.exists(RM_CONFIG))

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21CapabilityPatch.java

@@ -123,7 +123,7 @@ public class RMv21CapabilityPatch extends RMv21PatchComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         Set<NodeRef> filePlans = getFilePlans();
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21InPlacePatch.java

@@ -134,7 +134,7 @@ public class RMv21InPlacePatch extends RMv21PatchComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         Set<NodeRef> filePlans = filePlanService.getFilePlans();
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21RMAdminUserPatch.java

@@ -109,7 +109,7 @@ public class RMv21RMAdminUserPatch extends RMv21PatchComponent implements BeanNa
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         String user = filePlanAuthenticationService.getRmAdminUserName();
         String firstName = I18NUtil.getMessage(MSG_FIRST_NAME);

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21RecordInheritancePatch.java

@@ -102,7 +102,7 @@ public class RMv21RecordInheritancePatch extends RMv21PatchComponent
      * @see org.alfresco.repo.module.AbstractModuleComponent#executeInternal()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         Pair<Long, QName> aspectPair = qnameDAO.getQName(ASPECT_RECORD);
         if (aspectPair != null)

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21ReportServicePatch.java

@@ -69,7 +69,7 @@ public class RMv21ReportServicePatch extends RMv21PatchComponent
     }
 
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         // check whether report dir exists or not
         if (nodeService.exists(RM_CONFIG_FOLDER) && !nodeService.exists(TEMPLATE_ROOT))

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21RolesPatch.java

@@ -67,7 +67,7 @@ public class RMv21RolesPatch extends RMv21PatchComponent implements BeanNameAwar
      * @see org.alfresco.module.org_alfresco_module_rm.patch.compatibility.ModulePatchComponent#executePatch()
      */
     @Override
-    protected void executePatch() throws Throwable
+    protected void executePatch()
     {
         Set<NodeRef> filePlans = filePlanService.getFilePlans();