Merged FILE-FOLDER-API (5.2.0) to HEAD (5.2)

119796 jvonka: FileFolder API - NodeApiTest - add tests (+ve & -ve) for create folder
   RA-635


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@126368 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/rest/api/model/Document.java

@@ -22,6 +22,7 @@ import java.io.Serializable;
 import java.math.BigInteger;
 import java.util.Map;
 
+import com.fasterxml.jackson.annotation.JsonInclude;
 import org.alfresco.model.ContentModel;
 import org.alfresco.service.ServiceRegistry;
 import org.alfresco.service.cmr.repository.ContentData;
@@ -35,15 +36,11 @@ import org.alfresco.service.namespace.QName;
  * @author janv
  *
  */
+@JsonInclude(JsonInclude.Include.NON_NULL)
 public class Document extends Node
 {
     private ContentInfo contentInfo;
 
-    // instance init block
-    {
-        this.isFolder = Boolean.FALSE;
-    }
-
     public Document() {
         super();
     }
@@ -60,6 +57,8 @@ public class Document extends Node
             String mimeTypeName = sr.getMimetypeService().getDisplaysByMimetype().get(mimeType);
             this.contentInfo = new ContentInfo(mimeType, mimeTypeName, cd.getSize(), cd.getEncoding());
         }
+
+        this.isFolder = false;
     }
 
     public ContentInfo getContent()

source/java/org/alfresco/rest/api/model/Folder.java

@@ -22,6 +22,7 @@ package org.alfresco.rest.api.model;
 import java.io.Serializable;
 import java.util.Map;
 
+import com.fasterxml.jackson.annotation.JsonInclude;
 import org.alfresco.service.ServiceRegistry;
 import org.alfresco.service.cmr.repository.NodeRef;
 import org.alfresco.service.namespace.QName;
@@ -32,13 +33,9 @@ import org.alfresco.service.namespace.QName;
  * @author steveglover
  * @author janv
  */
+@JsonInclude(JsonInclude.Include.NON_NULL)
 public class Folder extends Node
 {
-    // instance init block
-    {
-        this.isFolder = Boolean.TRUE;
-    }
-
     public Folder()
     {
         super();
@@ -47,6 +44,7 @@ public class Folder extends Node
     public Folder(NodeRef nodeRef, NodeRef parentNodeRef, Map<QName, Serializable> nodeProps, Map<String, UserInfo> mapUserInfo, ServiceRegistry sr)
     {
         super(nodeRef, parentNodeRef, nodeProps, mapUserInfo, sr);
+        this.isFolder = true;
     }
 
     @Override

source/java/org/alfresco/rest/api/model/Node.java

@@ -24,11 +24,12 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
+import com.fasterxml.jackson.annotation.JsonInclude;
 import org.alfresco.model.ContentModel;
 import org.alfresco.repo.security.authentication.AuthenticationUtil;
-import org.alfresco.rest.framework.resource.UniqueId;
 import org.alfresco.service.ServiceRegistry;
 import org.alfresco.service.cmr.repository.NodeRef;
+import org.alfresco.service.cmr.repository.StoreRef;
 import org.alfresco.service.cmr.security.NoSuchPersonException;
 import org.alfresco.service.cmr.security.PersonService;
 import org.alfresco.service.namespace.QName;
@@ -42,6 +43,7 @@ import org.apache.chemistry.opencmis.commons.data.PropertyData;
  * @author Gethin James
  * @author janv
  */
+@JsonInclude(JsonInclude.Include.NON_NULL)
 public class Node implements Comparable<Node>
 {
     protected NodeRef nodeRef;
@@ -135,15 +137,29 @@ public class Node implements Comparable<Node>
         return userInfo;
     }
 
-    @UniqueId
-    public NodeRef getNodeRef()
-    {
-        return nodeRef;
+    private String getNodeRefAsString(NodeRef nRef) {
+        return (nRef != null ? nRef.getId() : null);
     }
 
-    public void setNodeRef(NodeRef nodeRef)
+    private NodeRef getStringAsNodeRef(String nRefString) {
+        if(! NodeRef.isNodeRef(nRefString))
+        {
+            return new NodeRef(StoreRef.STORE_REF_WORKSPACE_SPACESSTORE, nRefString);
+        }
+        else
+        {
+            return new NodeRef(nRefString);
+        }
+    }
+
+    public String getId()
     {
-        this.nodeRef = nodeRef;
+        return getNodeRefAsString(this.nodeRef);
+    }
+
+    public void setId(String id)
+    {
+       this.nodeRef = getStringAsNodeRef(id);
     }
 
     public Date getCreatedAt()
@@ -215,14 +231,14 @@ public class Node implements Comparable<Node>
         this.aspectNames = aspectNames;
     }
 
-    public NodeRef getParentId()
+    public String getParentId()
     {
-        return parentNodeRef;
+        return getNodeRefAsString(parentNodeRef);
     }
 
-    public void setParentId(NodeRef parentNodeRef)
+    public void setParentId(String parentId)
     {
-        this.parentNodeRef = parentNodeRef;
+        this.parentNodeRef = getStringAsNodeRef(parentId);
     }
 
     public Boolean getIsFolder()
@@ -258,13 +274,13 @@ public class Node implements Comparable<Node>
         }
 
         Node node = (Node)other;
-        return EqualsHelper.nullSafeEquals(getNodeRef(), node.getNodeRef());
+        return EqualsHelper.nullSafeEquals(getId(), node.getId());
     }
 
     @Override
     public int compareTo(Node node)
     {
-        return getNodeRef().toString().compareTo(node.getNodeRef().toString());
+        return getId().toString().compareTo(node.getId().toString());
     }
 
     @Override