REPO-1144: LockService - add isLocked & isLockedAndReadOnly common helper methods to public API

- remove duplicated code from various locations to use the new methods
- add sanity checks to Lock*Test

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/DEV/5.2.N/root@129764 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Jan Vonka
2016-08-22 14:20:52 +00:00
parent 8679372a42
commit cc97515300
14 changed files with 591 additions and 437 deletions

View File

@@ -1,28 +1,28 @@
/*
* #%L
* Alfresco Repository
* %%
* Copyright (C) 2005 - 2016 Alfresco Software Limited
* %%
* This file is part of the Alfresco software.
* If the software was purchased under a paid Alfresco license, the terms of
* the paid license agreement will prevail. Otherwise, the software is
* provided under the following open source license terms:
*
* Alfresco is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Alfresco is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
* #L%
*/
/*
* #%L
* Alfresco Repository
* %%
* Copyright (C) 2005 - 2016 Alfresco Software Limited
* %%
* This file is part of the Alfresco software.
* If the software was purchased under a paid Alfresco license, the terms of
* the paid license agreement will prevail. Otherwise, the software is
* provided under the following open source license terms:
*
* Alfresco is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Alfresco is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
* #L%
*/
package org.alfresco.repo.template;
import java.io.Serializable;
@@ -404,11 +404,7 @@ public class TemplateNode extends BasePermissionsNode implements NamespacePrefix
if (getAspects().contains(ContentModel.ASPECT_LOCKABLE))
{
LockStatus lockStatus = this.services.getLockService().getLockStatus(this.nodeRef);
if (lockStatus == LockStatus.LOCKED || lockStatus == LockStatus.LOCK_OWNER)
{
locked = true;
}
locked = this.services.getLockService().isLocked(this.nodeRef);
}
return locked;
@@ -599,19 +595,19 @@ public class TemplateNode extends BasePermissionsNode implements NamespacePrefix
String applicationName = "alfresco-access";
AuditQueryParameters pathParams = new AuditQueryParameters();
pathParams.setApplicationName(applicationName);
pathParams.addSearchKey("/alfresco-access/transaction/path", nodePath);
pathParams.addSearchKey("/alfresco-access/transaction/path", nodePath);
// unfortunately, the getAuditTrail API forces us to get them all
services.getAuditService().auditQuery(callback, pathParams, Integer.MAX_VALUE);
AuditQueryParameters copyFromPathParams = new AuditQueryParameters();
copyFromPathParams.setApplicationName(applicationName);
copyFromPathParams.addSearchKey("/alfresco-access/transaction/copy/from/path", nodePath);
copyFromPathParams.addSearchKey("/alfresco-access/transaction/copy/from/path", nodePath);
// unfortunately, the getAuditTrail API forces us to get them all
services.getAuditService().auditQuery(callback, copyFromPathParams, Integer.MAX_VALUE);
AuditQueryParameters moveFromPathParams = new AuditQueryParameters();
moveFromPathParams.setApplicationName(applicationName);
moveFromPathParams.addSearchKey("/alfresco-access/transaction/move/from/path", nodePath);
moveFromPathParams.addSearchKey("/alfresco-access/transaction/move/from/path", nodePath);
// unfortunately, the getAuditTrail API forces us to get them all
services.getAuditService().auditQuery(callback, moveFromPathParams, Integer.MAX_VALUE);
return null;