From cf8e81265d2d2ef027566dede9439cb88752003c Mon Sep 17 00:00:00 2001 From: Silviu Dinuta Date: Thu, 15 Sep 2016 14:04:06 +0300 Subject: [PATCH] RM-3996: added unit tests and fixed the bug with infinite loop when batchsize=0 --- .../repo/web/scripts/roles/DynamicAuthoritiesGet.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/rm-server/source/java/org/alfresco/repo/web/scripts/roles/DynamicAuthoritiesGet.java b/rm-server/source/java/org/alfresco/repo/web/scripts/roles/DynamicAuthoritiesGet.java index 6ce3574d6d..b023dcf45e 100644 --- a/rm-server/source/java/org/alfresco/repo/web/scripts/roles/DynamicAuthoritiesGet.java +++ b/rm-server/source/java/org/alfresco/repo/web/scripts/roles/DynamicAuthoritiesGet.java @@ -56,7 +56,7 @@ import org.springframework.extensions.webscripts.WebScriptRequest; @SuppressWarnings("deprecation") public class DynamicAuthoritiesGet extends DeclarativeWebScript implements RecordsManagementModel { - + private static final String MESSAGE_PARAMETER_BATCHSIZE_GREATER_THAN_ZERO = "Parameter batchsize should be a number greater than 0."; private static final String MESSAGE_PROCESSING_BEGIN = "Processing - BEGIN"; private static final String MESSAGE_PROCESSING_END = "Processing - END"; private static final String MESSAGE_PROCESSING_RECORD_END_TEMPLATE = "Processing record {0} - END"; @@ -114,6 +114,13 @@ public class DynamicAuthoritiesGet extends DeclarativeWebScript implements Recor try { size = Long.parseLong(batchSizeStr); + if(size <= 0) + { + model.put(MODEL_STATUS, FAILED_STATUS); + model.put(MODEL_MESSAGE, MESSAGE_PARAMETER_BATCHSIZE_GREATER_THAN_ZERO); + logger.info(MESSAGE_PARAMETER_BATCHSIZE_GREATER_THAN_ZERO); + return model; + } } catch(NumberFormatException ex) {