Fixed minor issues reported by sonar (Unread public/protected field)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63814 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

rm-server/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml

@@ -586,7 +586,6 @@
          class="org.alfresco.module.org_alfresco_module_rm.vital.BroadcastVitalRecordDefinitionAction"
          parent="rmAction">
       <property name="filePlanService" ref="FilePlanService"/>
-      <property name="filePlanAuthenticationService" ref="FilePlanAuthenticationService"/>
       <property name="auditable" value="false"/>
    </bean>
 

rm-server/config/alfresco/module/org_alfresco_module_rm/rm-model-context.xml

@@ -101,7 +101,6 @@
    <bean id="rma.record" class="org.alfresco.module.org_alfresco_module_rm.model.rma.aspect.RecordAspect" parent="rm.baseBehaviour">
         <property name="scriptService" ref="ScriptService" />
         <property name="extendedSecurityService" ref="ExtendedSecurityService" />
-        <property name="recordService" ref="RecordService" />
    </bean>
 
    <bean id="rma.recordComponentIdentifier" class="org.alfresco.module.org_alfresco_module_rm.model.rma.aspect.RecordComponentIdentifierAspect" parent="rm.baseBehaviour">

rm-server/config/alfresco/module/org_alfresco_module_rm/rm-report-context.xml

@@ -31,9 +31,6 @@
    <!--  Report Service -->
 
    <bean id="reportService" parent="baseService" class="org.alfresco.module.org_alfresco_module_rm.report.ReportServiceImpl">
-      <property name="fileFolderService" ref="FileFolderService" />
-      <property name="filePlanService" ref="FilePlanService" />
-      <property name="contentService" ref="ContentService" />
       <property name="recordService" ref="RecordService" />
    </bean>
 
@@ -77,7 +74,6 @@
       <property name="mimetypeService" ref="MimetypeService"/>
       <property name="fileFolderService" ref="FileFolderService"/>
       <property name="templateService" ref="TemplateService"/>
-      <property name="nodeService" ref="NodeService" />
       <property name="parameterProcessorComponent" ref="parameterProcessorComponent"/>
       <property name="repository" ref="repositoryHelper" />
       <property name="sysAdminParams" ref="sysAdminParams" />

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/model/rma/aspect/RecordAspect.java

@@ -28,7 +28,6 @@ import org.alfresco.module.org_alfresco_module_rm.RecordsManagementPolicies;
 import org.alfresco.module.org_alfresco_module_rm.model.BaseBehaviourBean;
 import org.alfresco.module.org_alfresco_module_rm.model.RecordsManagementCustomModel;
 import org.alfresco.module.org_alfresco_module_rm.model.behaviour.RecordsManagementSearchBehaviour;
-import org.alfresco.module.org_alfresco_module_rm.record.RecordService;
 import org.alfresco.module.org_alfresco_module_rm.security.ExtendedSecurityService;
 import org.alfresco.repo.copy.CopyBehaviourCallback;
 import org.alfresco.repo.copy.CopyDetails;
@@ -71,9 +70,6 @@ public class RecordAspect extends    BaseBehaviourBean
     /** script service */
     protected ScriptService scriptService;
 
-    /** record service */
-    protected RecordService recordService;
-    
     /**
      * @param extendedSecurityService   extended security service
      */
@@ -90,14 +86,6 @@ public class RecordAspect extends    BaseBehaviourBean
         this.scriptService = scriptService;
     }
 
-    /**
-     * @param recordService record service
-     */
-    public void setRecordService(RecordService recordService)
-    {
-        this.recordService = recordService;
-    }
-    
     /**
      * Behaviour to ensure renditions have the appropriate extended security.
      *

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/model/rma/type/RmSiteType.java

@@ -28,7 +28,6 @@ import org.alfresco.module.org_alfresco_module_rm.model.BaseBehaviourBean;
 import org.alfresco.module.org_alfresco_module_rm.search.RecordsManagementSearchService;
 import org.alfresco.repo.node.NodeServicePolicies;
 import org.alfresco.repo.policy.Behaviour.NotificationFrequency;
-import org.alfresco.repo.policy.PolicyComponent;
 import org.alfresco.repo.policy.annotation.Behaviour;
 import org.alfresco.repo.policy.annotation.BehaviourBean;
 import org.alfresco.repo.policy.annotation.BehaviourKind;
@@ -66,9 +65,6 @@ public class RmSiteType extends    BaseBehaviourBean
     public static final String DEFAULT_SITE_NAME = "rm";
     public static final QName DEFAULT_FILE_PLAN_TYPE = TYPE_FILE_PLAN;
 
-    /** Policy component */
-    protected PolicyComponent policyComponent;
-    
     /** Site service */
     protected SiteService siteService;
 
@@ -81,15 +77,6 @@ public class RmSiteType extends    BaseBehaviourBean
     /** Map of file plan type's key'ed by corresponding site types */
     protected Map<QName, QName> mapFilePlanType = new HashMap<QName, QName>(3);
 
-    /**
-     * Set the policy component
-     * @param policyComponent   policy component
-     */
-    public void setPolicyComponent(PolicyComponent policyComponent)
-    {
-        this.policyComponent = policyComponent;
-    }
-    
     /**
      * Set the site service
      * @param siteService	site service

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/report/ReportServiceImpl.java

@@ -24,12 +24,9 @@ import java.util.Map;
 import java.util.Set;
 
 import org.alfresco.error.AlfrescoRuntimeException;
-import org.alfresco.module.org_alfresco_module_rm.fileplan.FilePlanService;
 import org.alfresco.module.org_alfresco_module_rm.record.RecordService;
 import org.alfresco.module.org_alfresco_module_rm.util.ServiceBaseImpl;
 import org.alfresco.repo.content.MimetypeMap;
-import org.alfresco.service.cmr.model.FileFolderService;
-import org.alfresco.service.cmr.repository.ContentService;
 import org.alfresco.service.cmr.repository.NodeRef;
 import org.alfresco.service.namespace.QName;
 import org.springframework.extensions.surf.util.ParameterCheck;
@@ -43,45 +40,12 @@ import org.springframework.extensions.surf.util.ParameterCheck;
 public class ReportServiceImpl extends ServiceBaseImpl
                                implements ReportService
 {
-    /** file folder service */
-    protected FileFolderService fileFolderService;
-
-    /** file plan service */
-    protected FilePlanService filePlanService;
-
-    /** content service */
-    protected ContentService contentService;
-
     /** record service */
     protected RecordService recordService;
 
     /** report generator registry */
     private Map<QName, ReportGenerator> registry = new HashMap<QName, ReportGenerator>();
 
-    /**
-     * @param fileFolderService file folder service
-     */
-    public void setFileFolderService(FileFolderService fileFolderService)
-    {
-        this.fileFolderService = fileFolderService;
-    }
-
-    /**
-     * @param filePlanService   file plan service
-     */
-    public void setFilePlanService(FilePlanService filePlanService)
-    {
-        this.filePlanService = filePlanService;
-    }
-
-    /**
-     * @param contentService    content service
-     */
-    public void setContentService(ContentService contentService)
-    {
-        this.contentService = contentService;
-    }
-
     /**
      * @param recordService record service
      */

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/report/generator/DeclarativeReportGenerator.java

@@ -32,7 +32,6 @@ import org.alfresco.service.cmr.repository.ContentService;
 import org.alfresco.service.cmr.repository.ContentWriter;
 import org.alfresco.service.cmr.repository.MimetypeService;
 import org.alfresco.service.cmr.repository.NodeRef;
-import org.alfresco.service.cmr.repository.NodeService;
 import org.alfresco.service.cmr.repository.StoreRef;
 import org.alfresco.service.cmr.repository.TemplateService;
 import org.alfresco.util.UrlUtil;
@@ -65,9 +64,6 @@ public class DeclarativeReportGenerator extends BaseReportGenerator
     /** template service */
     protected TemplateService templateService;
 
-    /** node service */
-    protected NodeService nodeService;
-
     /** repository helper */
     protected Repository repository;
 
@@ -109,14 +105,6 @@ public class DeclarativeReportGenerator extends BaseReportGenerator
         this.contentService = contentService;
     }
 
-    /**
-     * @param nodeService   node service
-     */
-    public void setNodeService(NodeService nodeService)
-    {
-        this.nodeService = nodeService;
-    }
-
     /**
      * @param parameterProcessorComponent   parameter processor component
      */

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/vital/BroadcastVitalRecordDefinitionAction.java

@@ -27,7 +27,6 @@ import org.alfresco.model.ContentModel;
 import org.alfresco.module.org_alfresco_module_rm.action.RMActionExecuterAbstractBase;
 import org.alfresco.module.org_alfresco_module_rm.fileplan.FilePlanService;
 import org.alfresco.module.org_alfresco_module_rm.model.RecordsManagementModel;
-import org.alfresco.module.org_alfresco_module_rm.security.FilePlanAuthenticationService;
 import org.alfresco.repo.security.authentication.AuthenticationUtil;
 import org.alfresco.repo.security.authentication.AuthenticationUtil.RunAsWork;
 import org.alfresco.service.cmr.action.Action;
@@ -49,16 +48,9 @@ public class BroadcastVitalRecordDefinitionAction extends RMActionExecuterAbstra
 {
 	protected FilePlanService filePlanService;
 
-    protected FilePlanAuthenticationService filePlanAuthenticationService;
-    
     public void setFilePlanService(FilePlanService filePlanService)
     {
-		this.filePlanService = filePlanService;
+        this.filePlanService = filePlanService;
-	}
-    
-    public void setFilePlanAuthenticationService(FilePlanAuthenticationService filePlanAuthenticationService)
-    {
-        this.filePlanAuthenticationService = filePlanAuthenticationService;
     }
 
     /**