From d5af9932f960cc6a6d6befc9af7752abe000ecfd Mon Sep 17 00:00:00 2001 From: Rodica Sutu Date: Mon, 29 Jan 2018 09:29:08 +0200 Subject: [PATCH] review updates - minor formatting, update java docs --- .../query/RecordsManagementQueryDAO.java | 2 +- .../service/RecordsManagementQueryDAOImplTest.java | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/query/RecordsManagementQueryDAO.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/query/RecordsManagementQueryDAO.java index 86b2357d02..f210f2afe5 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/query/RecordsManagementQueryDAO.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/query/RecordsManagementQueryDAO.java @@ -54,7 +54,7 @@ public interface RecordsManagementQueryDAO int getCountRmaIdentifier(String identifierValue); /** - * Returns the property values from children for the given property + * Returns distinct property values from children for the given property * * @param parent the parent to evaluate * @param property the QName of the property to evaluate diff --git a/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/RecordsManagementQueryDAOImplTest.java b/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/RecordsManagementQueryDAOImplTest.java index cb2162ec59..e1c8ead2ce 100644 --- a/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/RecordsManagementQueryDAOImplTest.java +++ b/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/RecordsManagementQueryDAOImplTest.java @@ -100,7 +100,7 @@ public class RecordsManagementQueryDAOImplTest extends BaseRMTestCase implements * Then the answer contains all distinct property values set */ @org.junit.Test - public void testgetChildrenWithPropertyValues_childrenWithValues() throws Exception + public void testGetChildrenWithPropertyValues_childrenWithValues() throws Exception { doBehaviourDrivenTest(new BehaviourDrivenTest() { @@ -136,8 +136,8 @@ public class RecordsManagementQueryDAOImplTest extends BaseRMTestCase implements @Override public void then() throws Exception { - Set expectedValues = ImmutableSet.of(propValue1,propValue2,propValue3); - assertEquals(propertyValues.size(),expectedValues.size()); + Set expectedValues = ImmutableSet.of(propValue1, propValue2, propValue3); + assertEquals(propertyValues.size(), expectedValues.size()); assertTrue(propertyValues.containsAll(expectedValues)); } @@ -261,8 +261,8 @@ public class RecordsManagementQueryDAOImplTest extends BaseRMTestCase implements /** * Given a folder with no children but the property set on itself - * When I check if the folder contains children having certain descriptions - * Then the answer is negative + * When get the children property values + * Then the list is empty */ @org.junit.Test public void testGetChildrenWithPropertyValues_noChildren() throws Exception