Removed unnecessary semicolon

This commit is contained in:
cagache
2019-07-01 16:19:52 +03:00
parent 3dc65aaed5
commit d645c19e37
18 changed files with 26 additions and 28 deletions

View File

@@ -64,7 +64,7 @@ public class RMListOfValuesConstraint extends ListOfValuesConstraint
// closed marking - all values must match // closed marking - all values must match
AND, AND,
// open marking - at least one value must match // open marking - at least one value must match
OR; OR
} }
// note: alternative to static init could be to use 'registered' constraint // note: alternative to static init could be to use 'registered' constraint

View File

@@ -35,5 +35,5 @@ package org.alfresco.module.org_alfresco_module_rm.action.evaluator;
*/ */
public enum DispositionActionRelativePositions public enum DispositionActionRelativePositions
{ {
ANY, NEXT, PREVIOUS; ANY, NEXT, PREVIOUS
} }

View File

@@ -796,7 +796,7 @@ public class RecordsManagementAuditServiceImpl extends AbstractLifecycleBean
format == ReportFormat.HTML ? AUDIT_TRAIL_HTML_FILE_SUFFIX : AUDIT_TRAIL_JSON_FILE_SUFFIX); format == ReportFormat.HTML ? AUDIT_TRAIL_HTML_FILE_SUFFIX : AUDIT_TRAIL_JSON_FILE_SUFFIX);
try (FileOutputStream fileOutputStream = new FileOutputStream(auditTrailFile); try (FileOutputStream fileOutputStream = new FileOutputStream(auditTrailFile);
Writer fileWriter = new BufferedWriter(new OutputStreamWriter(fileOutputStream,"UTF8"));) Writer fileWriter = new BufferedWriter(new OutputStreamWriter(fileOutputStream,"UTF8")))
{ {
// Get the results, dumping to file // Get the results, dumping to file
getAuditTrailImpl(params, null, fileWriter, format); getAuditTrailImpl(params, null, fileWriter, format);

View File

@@ -51,5 +51,5 @@ public enum FilePlanComponentKind
HOLD_CONTAINER, HOLD_CONTAINER,
DISPOSITION_SCHEDULE, DISPOSITION_SCHEDULE,
UNFILED_RECORD_CONTAINER, UNFILED_RECORD_CONTAINER,
UNFILED_RECORD_FOLDER; UNFILED_RECORD_FOLDER
} }

View File

@@ -39,5 +39,5 @@ import org.alfresco.api.AlfrescoPublicApi;
public enum RelationshipType public enum RelationshipType
{ {
BIDIRECTIONAL, BIDIRECTIONAL,
PARENTCHILD; PARENTCHILD
} }

View File

@@ -129,7 +129,7 @@ public class TransferReportGet extends BaseTransferWebScript
// create the writer // create the writer
try (FileOutputStream fileOutputStream = new FileOutputStream(report); try (FileOutputStream fileOutputStream = new FileOutputStream(report);
Writer writer = new OutputStreamWriter(fileOutputStream, Charset.forName("UTF-8"));) Writer writer = new OutputStreamWriter(fileOutputStream, Charset.forName("UTF-8")))
{ {
// get all 'transferred' nodes // get all 'transferred' nodes
NodeRef[] itemsToTransfer = getTransferNodes(transferNode); NodeRef[] itemsToTransfer = getTransferNodes(transferNode);

View File

@@ -237,7 +237,7 @@ public class TransferReportPost extends BaseTransferWebScript
// create the writer // create the writer
try (FileOutputStream fileOutputStream = new FileOutputStream(report) ; try (FileOutputStream fileOutputStream = new FileOutputStream(report) ;
Writer writer = new OutputStreamWriter(fileOutputStream, Charset.forName("UTF-8"));) Writer writer = new OutputStreamWriter(fileOutputStream, Charset.forName("UTF-8")))
{ {
// get all 'transferred' nodes // get all 'transferred' nodes
NodeRef[] itemsToTransfer = getTransferNodes(transferNode); NodeRef[] itemsToTransfer = getTransferNodes(transferNode);

View File

@@ -38,5 +38,5 @@ import org.alfresco.api.AlfrescoPublicApi;
public enum UpdateActionType public enum UpdateActionType
{ {
ADD, ADD,
REMOVE; REMOVE
} }

View File

@@ -704,7 +704,6 @@ public class InplaceRecordPermissionTest extends BaseRMTestCase
AccessStatus.DENIED, // view record capability AccessStatus.DENIED, // view record capability
AccessStatus.DENIED, // edit non record metadata capability AccessStatus.DENIED, // edit non record metadata capability
AccessStatus.DENIED)); // edit record metadata capability AccessStatus.DENIED)); // edit record metadata capability
;
} }
/** /**
@@ -772,7 +771,6 @@ public class InplaceRecordPermissionTest extends BaseRMTestCase
AccessStatus.DENIED, // view record capability AccessStatus.DENIED, // view record capability
AccessStatus.DENIED, // edit non record metadata capability AccessStatus.DENIED, // edit non record metadata capability
AccessStatus.DENIED)); // edit record metadata capability AccessStatus.DENIED)); // edit record metadata capability
;
} }
/** /**
@@ -902,7 +900,6 @@ public class InplaceRecordPermissionTest extends BaseRMTestCase
AccessStatus.DENIED, // view record capability AccessStatus.DENIED, // view record capability
AccessStatus.DENIED, // edit non record metadata capability AccessStatus.DENIED, // edit non record metadata capability
AccessStatus.DENIED)); // edit record metadata capability AccessStatus.DENIED)); // edit record metadata capability
;
} }
/** /**
@@ -932,7 +929,6 @@ public class InplaceRecordPermissionTest extends BaseRMTestCase
.expect(3) .expect(3)
.from(() -> authorityService.getContainedAuthorities(null, "GROUP_INPLACE_RECORD_MANAGEMENT", true).size()) .from(() -> authorityService.getContainedAuthorities(null, "GROUP_INPLACE_RECORD_MANAGEMENT", true).size())
.because("The read and write groups are reused."); .because("The read and write groups are reused.");
;
} }
/** /**

View File

@@ -80,7 +80,7 @@ public class MoveRecordTest extends BaseRMTestCase
sourceCategory = filePlanService.createRecordCategory(filePlan, GUID.generate()); sourceCategory = filePlanService.createRecordCategory(filePlan, GUID.generate());
utils.createBasicDispositionSchedule(sourceCategory, GUID.generate(), GUID.generate(), true, true); utils.createBasicDispositionSchedule(sourceCategory, GUID.generate(), GUID.generate(), true, true);
sourceRecordFolder = recordFolderService.createRecordFolder(sourceCategory, GUID.generate()); sourceRecordFolder = recordFolderService.createRecordFolder(sourceCategory, GUID.generate());
destinationCategory = filePlanService.createRecordCategory(filePlan, GUID.generate());; destinationCategory = filePlanService.createRecordCategory(filePlan, GUID.generate());
destinationRecordFolder = recordFolderService.createRecordFolder(destinationCategory, GUID.generate()); destinationRecordFolder = recordFolderService.createRecordFolder(destinationCategory, GUID.generate());
// create record // create record

View File

@@ -75,7 +75,7 @@ public class CreateRecordActionTest extends BaseRMTestCase
assertEquals(AccessStatus.ALLOWED, permissionService.hasPermission(dmDocument, RMPermissionModel.READ_RECORDS)); assertEquals(AccessStatus.ALLOWED, permissionService.hasPermission(dmDocument, RMPermissionModel.READ_RECORDS));
assertEquals(AccessStatus.ALLOWED, permissionService.hasPermission(filePlan, RMPermissionModel.VIEW_RECORDS)); assertEquals(AccessStatus.ALLOWED, permissionService.hasPermission(filePlan, RMPermissionModel.VIEW_RECORDS));
}; }
}, },
dmCollaborator); dmCollaborator);
} }

View File

@@ -104,7 +104,7 @@ public class RecordableVersionConfigActionTest extends BaseRMTestCase
public void test(Void result) throws Exception public void test(Void result) throws Exception
{ {
assertNull(nodeService.getProperty(dmFolder, PROP_RECORDABLE_VERSION_POLICY)); assertNull(nodeService.getProperty(dmFolder, PROP_RECORDABLE_VERSION_POLICY));
}; }
}, },
dmCollaborator); dmCollaborator);
@@ -122,7 +122,7 @@ public class RecordableVersionConfigActionTest extends BaseRMTestCase
public void test(Void result) throws Exception public void test(Void result) throws Exception
{ {
assertNull(nodeService.getProperty(document2, PROP_RECORDABLE_VERSION_POLICY)); assertNull(nodeService.getProperty(document2, PROP_RECORDABLE_VERSION_POLICY));
}; }
}, },
dmCollaborator); dmCollaborator);
@@ -145,7 +145,7 @@ public class RecordableVersionConfigActionTest extends BaseRMTestCase
public void test(Void result) throws Exception public void test(Void result) throws Exception
{ {
assertNull(nodeService.getProperty(document3, PROP_RECORDABLE_VERSION_POLICY)); assertNull(nodeService.getProperty(document3, PROP_RECORDABLE_VERSION_POLICY));
}; }
}, },
dmCollaborator); dmCollaborator);
} }

View File

@@ -622,7 +622,7 @@ public class DispositionServiceImplTest extends BaseRMTestCase
checkDisposableItemUnchanged(mhRecordFolder42); checkDisposableItemUnchanged(mhRecordFolder42);
checkDisposableItemUnchanged(record43); checkDisposableItemUnchanged(record43);
checkDisposableItemUnchanged(mhRecordFolder44); checkDisposableItemUnchanged(mhRecordFolder44);
checkDisposableItemUnchanged(record45);; checkDisposableItemUnchanged(record45);
} }
}); });
@@ -644,7 +644,7 @@ public class DispositionServiceImplTest extends BaseRMTestCase
checkDisposableItemChanged(mhRecordFolder42); checkDisposableItemChanged(mhRecordFolder42);
checkDisposableItemUnchanged(record43); checkDisposableItemUnchanged(record43);
checkDisposableItemUnchanged(mhRecordFolder44); checkDisposableItemUnchanged(mhRecordFolder44);
checkDisposableItemUnchanged(record45);; checkDisposableItemUnchanged(record45);
} }
}); });

View File

@@ -135,7 +135,7 @@ public class ExtendedSecurityServiceImplTest extends BaseRMTestCase
doTestInTransaction(new Test<Void>() doTestInTransaction(new Test<Void>()
{ {
Set<String> extendedReaders = new HashSet<>(2);; Set<String> extendedReaders = new HashSet<>(2);
public Void run() throws Exception public Void run() throws Exception
{ {

View File

@@ -599,7 +599,7 @@ public class RecordsManagementAdminServiceImplTest extends BaseRMTestCase
RelationshipDefinition relationshipDefinition = relationshipService.createRelationshipDefinition(displayName); RelationshipDefinition relationshipDefinition = relationshipService.createRelationshipDefinition(displayName);
// Get the qualified name // Get the qualified name
QName qNameResult = QName.createQName(RM_CUSTOM_PREFIX, relationshipDefinition.getUniqueName(), namespaceService);; QName qNameResult = QName.createQName(RM_CUSTOM_PREFIX, relationshipDefinition.getUniqueName(), namespaceService);
System.out.println("Creating new " + refType + " reference definition: " + qNameResult); System.out.println("Creating new " + refType + " reference definition: " + qNameResult);
System.out.println(" params- label: '" + label + "' source: '" + source + "' target: '" + target + "'"); System.out.println(" params- label: '" + label + "' source: '" + source + "' target: '" + target + "'");

View File

@@ -57,7 +57,7 @@ public class EagerContentStoreCleanerUnitTest extends BaseUnitTest
@InjectMocks private EagerContentStoreCleaner eagerContentStoreCleaner = new EagerContentStoreCleaner() @InjectMocks private EagerContentStoreCleaner eagerContentStoreCleaner = new EagerContentStoreCleaner()
{ {
/** dummy implementation */ /** dummy implementation */
public boolean registerOrphanedContentUrl(String contentUrl, boolean force) {return true;}; public boolean registerOrphanedContentUrl(String contentUrl, boolean force) {return true;}
}; };
@Mock private ContentCleanser mockedContentCleanser; @Mock private ContentCleanser mockedContentCleanser;

View File

@@ -51,7 +51,7 @@ public class ContentCleanser522022MUnitTest extends BaseUnitTest
@InjectMocks @Spy private ContentCleanser522022M contentCleanser522022M = new ContentCleanser522022M() @InjectMocks @Spy private ContentCleanser522022M contentCleanser522022M = new ContentCleanser522022M()
{ {
/** dummy implementations */ /** dummy implementations */
protected void overwrite(File file, OverwriteOperation overwriteOperation) {}; protected void overwrite(File file, OverwriteOperation overwriteOperation) {}
}; };
@Mock private File mockedFile; @Mock private File mockedFile;

View File

@@ -73,15 +73,17 @@ public class ExtendedPermissionServiceImplUnitTest extends BaseUnitTest
/** permission service impl, default */ /** permission service impl, default */
private @InjectMocks @Spy ExtendedPermissionServiceImpl extendedPermissionServiceImpl = new ExtendedPermissionServiceImpl() private @InjectMocks @Spy ExtendedPermissionServiceImpl extendedPermissionServiceImpl = new ExtendedPermissionServiceImpl()
{ {
protected AccessStatus hasPermissionImpl(NodeRef nodeRef, String perm) { return AccessStatus.UNDETERMINED; }; protected AccessStatus hasPermissionImpl(NodeRef nodeRef, String perm) { return AccessStatus.UNDETERMINED; }
}; };
/** permission service impl instance extended for reader/writer tests */ /** permission service impl instance extended for reader/writer tests */
private @InjectMocks ExtendedPermissionServiceImpl extendedPermissionServiceImplWithReaderWritersSet = new ExtendedPermissionServiceImpl() private @InjectMocks ExtendedPermissionServiceImpl extendedPermissionServiceImplWithReaderWritersSet = new ExtendedPermissionServiceImpl()
{ {
protected AccessStatus hasPermissionImpl(NodeRef nodeRef, String perm) { return AccessStatus.UNDETERMINED; }; protected AccessStatus hasPermissionImpl(NodeRef nodeRef, String perm) { return AccessStatus.UNDETERMINED; }
public java.util.Set<String> getReaders(Long aclId) { return READERS; };
public java.util.Set<String> getWriters(Long aclId) { return WRITERS; }; public java.util.Set<String> getReaders(Long aclId) { return READERS; }
public java.util.Set<String> getWriters(Long aclId) { return WRITERS; }
}; };
/** mocks */ /** mocks */