Merged HEAD-BUG-FIX (5.1/Cloud) to HEAD (5.1/Cloud)

102713: Merged 5.0.N (5.0.2) to HEAD-BUG-FIX (5.1/Cloud)
      102494: Merged V4.2-BUG-FIX (4.2.5) to 5.0.N (5.0.2)
         102420: MNT-13710 : User cannot change site role if its current role contains an underscore
          Build failed. Was corected some junit tests.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@103543 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Alan Davis
2015-05-02 07:19:06 +00:00
parent f38566ccf1
commit d87d938309

View File

@@ -677,8 +677,6 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
public void testMNT_13710() throws Exception
{
final String user = "user";
String siteName = "test" + System.currentTimeMillis();
List<String> roleList = new ArrayList<String>();
@@ -690,14 +688,12 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
authenticationComponent.setCurrentUser(AuthenticationUtil.getAdminUserName());
SiteInfo siteInfo = this.siteService.createSite(siteName, siteName, siteName, siteName, SiteVisibility.PUBLIC);
createUser(user, user);
for(String role : roleList)
{
this.siteService.setMembership(siteInfo.getShortName(), user, role);
this.siteService.setMembership(siteInfo.getShortName(), USER_ONE, role);
List<String> list = this.siteServiceImpl.getMembersRoles(siteName, user);
List<String> list = this.siteServiceImpl.getMembersRoles(siteName, USER_ONE);
assertTrue(list.contains(role));
}
@@ -708,11 +704,6 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
{
siteService.deleteSite(siteName);
}
if (this.personService.getPerson(user) != null)
{
this.personService.deletePerson(user);
}
}
}
@@ -1381,8 +1372,8 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
assertNotNull(roles);
assertFalse(roles.isEmpty());
// By default there are just the 4 roles
assertEquals(4, roles.size());
// By default there are just the 4 roles, but in classpath:org/alfresco/repo/site/site-custom-context.xml there are 7
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));
@@ -1473,14 +1464,14 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
// Check the roles on it
List<String> roles = siteService.getSiteRoles();
assertEquals(4, roles.size());
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_MANAGER));
roles = siteService.getSiteRoles(site.getShortName());
assertEquals(4, roles.size());
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));
@@ -1492,14 +1483,14 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
// Check again
roles = siteService.getSiteRoles();
assertEquals(4, roles.size());
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_MANAGER));
roles = siteService.getSiteRoles(site.getShortName());
assertEquals(4, roles.size());
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));
@@ -1522,7 +1513,7 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
siteServiceImpl.setPermissionService(testPermissionService);
roles = siteService.getSiteRoles();
assertEquals(4, roles.size());
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));
@@ -1536,14 +1527,14 @@ public class SiteServiceImplTest extends BaseAlfrescoSpringTest
// Put the permissions back
siteServiceImpl.setPermissionService(permissionService);
roles = siteService.getSiteRoles();
assertEquals(4, roles.size());
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_MANAGER));
roles = siteService.getSiteRoles(site.getShortName());
assertEquals(4, roles.size());
assertEquals(7, roles.size());
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONSUMER));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_CONTRIBUTOR));
assertEquals(true, roles.contains(SiteServiceImpl.SITE_COLLABORATOR));