Fixed AssociationRef.equals method that was causing association matching to fail

Fixed node tests that were hiding a NullPointerException when node associations weren't found
Fixed NodeAssoc AssociationRef caching for cases where the source or target nodes move stores
Removed storage of Path property for archived nodes


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@2886 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/repo/domain/hibernate/NodeAssocImpl.java

@@ -74,13 +74,24 @@ public class NodeAssocImpl implements NodeAssoc
     
     public AssociationRef getNodeAssocRef()
     {
+        boolean trashReference = false;
         // first check if it is available
         refReadLock.lock();
         try
         {
             if (nodeAssocRef != null)
             {
-                return nodeAssocRef;
+                // double check that the parent and child node references match those of our reference
+                if (nodeAssocRef.getSourceRef() != source.getNodeRef() ||
+                        nodeAssocRef.getTargetRef() != target.getNodeRef())
+                {
+                    trashReference = true;
+                }
+                else
+                {
+                    // we are sure that the reference is correct
+                    return nodeAssocRef;
+                }
             }
         }
         finally
@@ -92,7 +103,7 @@ public class NodeAssocImpl implements NodeAssoc
         try
         {
             // double check
-            if (nodeAssocRef == null )
+            if (nodeAssocRef == null || trashReference)
             {
                 nodeAssocRef = new AssociationRef(
                         getSource().getNodeRef(),