REPO-1579: V1 REST API - create person fix

- expect 403 instead of 409, if a non-admin tries to create a person that already exists
- REPO-892

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/DEV/5.2.N/root@133423 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/rest/api/impl/PeopleImpl.java

@@ -440,7 +440,13 @@ public class PeopleImpl implements People
 	{
 		validateCreatePersonData(person);
 
-		// TODO: check, is this transaction safe?
+        if (! isAdminAuthority())
+        {
+            // note: do an explict check for admin here (since personExists does not throw 403 unlike createPerson,
+            // hence next block would cause 409 to be returned)
+            throw new PermissionDeniedException();
+        }
+
 		// Unfortunately PersonService.createPerson(...) only throws an AlfrescoRuntimeException
 		// rather than a more specific exception and does not use a message ID either, so there's
 		// no sensible way to know that it was thrown due to the user already existing - hence this check here.