From dca3a954ac6fd2a76e597f7cf7df0454e9165a24 Mon Sep 17 00:00:00 2001 From: Tuna Aksoy Date: Tue, 18 Mar 2014 23:50:41 +0000 Subject: [PATCH] Fixed major issues reported by sonar (Simplify Boolean Expression) git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64828 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261 --- .../org_alfresco_module_rm/action/impl/DeclareRecordAction.java | 2 +- .../patch/v21/RMv21BehaviorScriptsPatch.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/action/impl/DeclareRecordAction.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/action/impl/DeclareRecordAction.java index 9bee4dccbc..a116e8e28c 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/action/impl/DeclareRecordAction.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/action/impl/DeclareRecordAction.java @@ -150,7 +150,7 @@ public class DeclareRecordAction extends RMActionExecuterAbstractBase } } - if (result != false) + if (result) { Set aspects = this.nodeService.getAspects(nodeRef); for (QName aspect : aspects) diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21BehaviorScriptsPatch.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21BehaviorScriptsPatch.java index baf6f6298a..723036e632 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21BehaviorScriptsPatch.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/patch/v21/RMv21BehaviorScriptsPatch.java @@ -135,7 +135,7 @@ public class RMv21BehaviorScriptsPatch extends RMv21PatchComponent implements Be // Move files from RM Scripts folder to RM Behavior Scripts folder. List oldBehaviorScripts = fileFolderService.listFiles(OLD_BEHAVIOR_SCRIPTS_FOLDER); - if (oldBehaviorScripts != null && oldBehaviorScripts.isEmpty() != true) + if (oldBehaviorScripts != null && !oldBehaviorScripts.isEmpty()) { if (logger.isDebugEnabled()) {