inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-24 17:32:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests for the RetryingTransactionHelper

Browse Source 
- Tests new inner transactions
 - Tests various modes of failure, including silent mark for rollback
Archive restore uses retries


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@5953 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Derek Hulley
2007-06-14 12:34:39 +00:00
parent d403021a74
commit dd2f3985b9
3 changed files with 394 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
source/java/org/alfresco/repo/transaction/RetryingTransactionHelper.java
View File

@@ -27,7 +27,6 @@ package org.alfresco.repo.transaction;
import java.sql.BatchUpdateException;
import java.util.Random;
import javax.transaction.RollbackException;
import javax.transaction.Status;
import javax.transaction.SystemException;
import javax.transaction.UserTransaction;
@@ -57,7 +56,7 @@ public class RetryingTransactionHelper
/**
* Exceptions that trigger retries.
*/
private static final Class[] RETRY_EXCEPTIONS;
public static final Class[] RETRY_EXCEPTIONS;
static
{
RETRY_EXCEPTIONS = new Class[] {
@@ -149,6 +148,7 @@ public class RetryingTransactionHelper
*
* @param cb The callback containing the unit of work.
* @return Returns the result of the unit of work.
* @throws RuntimeException all checked exceptions are converted
*/
public <R> R doInTransaction(RetryingTransactionCallback<R> cb)
{
@@ -167,6 +167,7 @@ public class RetryingTransactionHelper
* @param cb The callback containing the unit of work.
* @param readOnly Whether this is a read only transaction.
* @return Returns the result of the unit of work.
* @throws RuntimeException all checked exceptions are converted
*/
public <R> R doInTransaction(RetryingTransactionCallback<R> cb, boolean readOnly)
{
@@ -184,11 +185,12 @@ public class RetryingTransactionHelper
*
* @param cb The callback containing the unit of work.
* @param readOnly Whether this is a read only transaction.
* @param newTransaction <tt>true</tt> to force a new transaction or
* @param requiresNew <tt>true</tt> to force a new transaction or
* <tt>false</tt> to partake in any existing transaction.
* @return Returns the result of the unit of work.
* @throws RuntimeException all checked exceptions are converted
*/
public <R> R doInTransaction(RetryingTransactionCallback<R> cb, boolean readOnly, boolean newTransaction)
public <R> R doInTransaction(RetryingTransactionCallback<R> cb, boolean readOnly, boolean requiresNew)
{
if (this.readOnly && !readOnly)
{
@@ -203,7 +205,7 @@ public class RetryingTransactionHelper
boolean isNew = false;
try
{
if (newTransaction)
if (requiresNew)
{
txn = fTxnService.getNonPropagatingUserTransaction();
}
@@ -211,12 +213,10 @@ public class RetryingTransactionHelper
{
txn = fTxnService.getUserTransaction(readOnly);
}
// Do we need to handle transaction demarcation. If no, we cannot do retries,
// that will be up to the containing transaction.
isNew = newTransaction || txn.getStatus() == Status.STATUS_NO_TRANSACTION;
// Only start a transaction if required. This check isn't necessary as the transactional
// behaviour ensures that the appropriate propogation is performed. It is a useful and
// simple optimization.
isNew = requiresNew || txn.getStatus() == Status.STATUS_NO_TRANSACTION;
if (isNew)
{
txn.begin();
@@ -250,13 +250,6 @@ public class RetryingTransactionHelper
}
return result;
}
catch (RollbackException e)
{
// Our explicit rollback didn't work
throw new AlfrescoRuntimeException(
"Unexpected rollback exception: \n" + e.getMessage(),
e);
}
catch (Throwable e)
{
// Somebody else 'owns' the transaction, so just rethrow.
@@ -268,7 +261,9 @@ public class RetryingTransactionHelper
}
else
{
throw new AlfrescoRuntimeException("Unknown Exception.", e);
throw new AlfrescoRuntimeException(
"Exception from transactional callback: " + cb,
e);
}
}
// Rollback if we can.
@@ -283,15 +278,15 @@ public class RetryingTransactionHelper
}
catch (IllegalStateException e1)
{
throw new AlfrescoRuntimeException("Failure during rollback.", e1);
throw new AlfrescoRuntimeException("Failure during rollback: " + cb, e1);
}
catch (SecurityException e1)
{
throw new AlfrescoRuntimeException("Failure during rollback.", e1);
throw new AlfrescoRuntimeException("Failure during rollback: " + cb, e1);
}
catch (SystemException e1)
{
throw new AlfrescoRuntimeException("Failure during rollback.", e1);
throw new AlfrescoRuntimeException("Failure during rollback: " + cb, e1);
}
}
lastException = (e instanceof RuntimeException) ?