From 55a085b30306fdf0e1c127f9687b37ece2dad257 Mon Sep 17 00:00:00 2001
From: David Webster <david.webster@alfresco.com>
Date: Fri, 23 Sep 2016 16:59:35 +0100
Subject: [PATCH 1/6] Add info on surf build error for those without access to
 internal maven repo

Mirrored from community commit 845413179d5f316a498996d9397ef9769626baf5
---
 README.txt | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/README.txt b/README.txt
index 0f9a62945a..ebcafd29fd 100644
--- a/README.txt
+++ b/README.txt
@@ -103,3 +103,11 @@ Code Formatting:
 ----------------
 
 This project follows the usual Alfresco Coding Standards. If you use Eclipse or IntelliJ, there are settings inside the ide-config directory for you to import.
+
+Surf build errors:
+------------------
+
+If you get: 
+[ERROR] Failed to execute goal on project alfresco-rm-community-share: Could not resolve dependencies for project org.alfresco:alfresco-rm-community-share:amp:2.6-SNAPSHOT: Failed to collect dependencies at org.alfresco.surf:spring-surf-api:jar:6.3 -> org.alfresco.surf:spring-surf:jar:${dependency.surf.version}: Failed to read artifact descriptor for org.alfresco.surf:spring-surf:jar:${dependency.surf.version}: Could not transfer artifact org.alfresco.surf:spring-surf:pom:${dependency.surf.version} from/to alfresco-internal (https://artifacts.alfresco.com/nexus/content/groups/private): Not authorized , ReasonPhrase:Unauthorized. -> [Help 1]
+
+then please re-run with  -Ddependency.surf.version=6.3

From 747ac95e206edfbe8613b4ef037c00f782b5097f Mon Sep 17 00:00:00 2001
From: Mihai Cozma <mihai.cozma@savatech.ro>
Date: Thu, 13 Oct 2016 15:37:54 +0300
Subject: [PATCH 2/6] RM-4245_update_module_version

---
 pom.xml                                       | 45 +++++++++++++++++++
 .../org_alfresco_module_rm/module.properties  |  2 +-
 rm-server/pom.xml                             | 16 ++++++-
 3 files changed, 61 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index f9872a4b4a..6784705b6b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -85,6 +85,36 @@
 
    <build>
       <plugins>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>build-helper-maven-plugin</artifactId>
+            <executions>
+               <execution>
+                  <id>regex-property</id>
+                  <goals>
+                     <goal>regex-property</goal>
+                  </goals>
+                  <configuration>
+                     <name>rm.module.version</name>
+                     <value>${project.version}</value>
+                     <regex>(\d+)\.(\d+).(\d+).*</regex>
+                     <replacement>$1.$2.$3</replacement>
+                     <failIfNoMatch>true</failIfNoMatch>
+                  </configuration>
+               </execution>
+               <execution>
+                  <id>add-test-source</id>
+                  <goals>
+                     <goal>add-test-source</goal>
+                  </goals>
+                  <configuration>
+                     <sources>
+                        <source>unit-test/java</source>
+                     </sources>
+                  </configuration>
+               </execution>
+            </executions>
+         </plugin>
          <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-enforcer-plugin</artifactId>
@@ -311,6 +341,21 @@
                               <ignore />
                            </action>
                         </pluginExecution>
+                        <pluginExecution>
+                           <pluginExecutionFilter>
+                              <groupId>org.codehaus.mojo</groupId>
+                              <artifactId>
+                                 build-helper-maven-plugin
+                              </artifactId>
+                              <versionRange>[1.8,)</versionRange>
+                              <goals>
+                                 <goal>regex-property</goal>
+                              </goals>
+                           </pluginExecutionFilter>
+                           <action>
+                              <ignore></ignore>
+                           </action>
+                        </pluginExecution>
                      </pluginExecutions>
                   </lifecycleMappingMetadata>
                </configuration>
diff --git a/rm-server/config/alfresco/module/org_alfresco_module_rm/module.properties b/rm-server/config/alfresco/module/org_alfresco_module_rm/module.properties
index d4d49678db..ac31d2f2ee 100644
--- a/rm-server/config/alfresco/module/org_alfresco_module_rm/module.properties
+++ b/rm-server/config/alfresco/module/org_alfresco_module_rm/module.properties
@@ -6,6 +6,6 @@ module.aliases=org_alfresco_module_dod5015
 
 module.title=Records Management
 module.description=Alfresco Record Management Extension
-module.version=2.3
+module.version=${rm.module.version}
 
 module.repo.version.min=4.2.2
diff --git a/rm-server/pom.xml b/rm-server/pom.xml
index 9a9d09695b..7256d117b4 100644
--- a/rm-server/pom.xml
+++ b/rm-server/pom.xml
@@ -19,6 +19,7 @@
       <resources>
          <resource>
             <directory>config</directory>
+             <filtering>true</filtering>
          </resource>
       </resources>
       <testResources>
@@ -32,6 +33,19 @@
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>build-helper-maven-plugin</artifactId>
             <executions>
+                 <execution>
+                  <id>regex-property</id>
+                  <goals>
+                     <goal>regex-property</goal>
+                  </goals>
+                  <configuration>
+                     <name>rm.module.version</name>
+                     <value>${project.version}</value>
+                     <regex>(\d+)\.(\d+).(\d+).*</regex>
+                     <replacement>$1.$2.$3</replacement>
+                     <failIfNoMatch>true</failIfNoMatch>
+                  </configuration>
+               </execution>
                <execution>
                   <id>add-source</id>
                   <goals>
@@ -154,7 +168,7 @@
                            <goal>run</goal>
                         </goals>
                         <configuration>
-                           <tasks>
+                        <tasks>
                               <delete file="${project.build.outputDirectory}/alfresco/extension/dev-context.xml"/>
                               <move todir="${project.build.directory}/${project.build.finalName}/config/alfresco">
                                  <fileset dir="${project.build.outputDirectory}/alfresco"/>

From cabaa629af8b81d0af757250a5644c8cf3d4b2d3 Mon Sep 17 00:00:00 2001
From: Mihai Cozma <mihai.cozma@savatech.ro>
Date: Thu, 13 Oct 2016 17:08:59 +0300
Subject: [PATCH 3/6] Fixed to handle more digits

---
 pom.xml           | 4 ++--
 rm-server/pom.xml | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index 6784705b6b..12ef840712 100644
--- a/pom.xml
+++ b/pom.xml
@@ -97,8 +97,8 @@
                   <configuration>
                      <name>rm.module.version</name>
                      <value>${project.version}</value>
-                     <regex>(\d+)\.(\d+).(\d+).*</regex>
-                     <replacement>$1.$2.$3</replacement>
+                     <regex>([0-9\.]*[0-9]).*</regex>
+                     <replacement>$1</replacement>
                      <failIfNoMatch>true</failIfNoMatch>
                   </configuration>
                </execution>
diff --git a/rm-server/pom.xml b/rm-server/pom.xml
index 7256d117b4..a4554801db 100644
--- a/rm-server/pom.xml
+++ b/rm-server/pom.xml
@@ -41,8 +41,8 @@
                   <configuration>
                      <name>rm.module.version</name>
                      <value>${project.version}</value>
-                     <regex>(\d+)\.(\d+).(\d+).*</regex>
-                     <replacement>$1.$2.$3</replacement>
+                     <regex>([0-9\.]*[0-9]).*</regex>
+                     <replacement>$1</replacement>
                      <failIfNoMatch>true</failIfNoMatch>
                   </configuration>
                </execution>

From 5937ac38cb31099a314ea1637fc90ce1599c65c1 Mon Sep 17 00:00:00 2001
From: Mihai Cozma <mihai.cozma@savatech.ro>
Date: Fri, 14 Oct 2016 11:18:28 +0300
Subject: [PATCH 4/6] add symetrical build-helper-maven-plugin for both
 rm-share and rm-server

---
 pom.xml | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/pom.xml b/pom.xml
index 12ef840712..e5f5f35ebe 100644
--- a/pom.xml
+++ b/pom.xml
@@ -85,36 +85,6 @@
 
    <build>
       <plugins>
-         <plugin>
-            <groupId>org.codehaus.mojo</groupId>
-            <artifactId>build-helper-maven-plugin</artifactId>
-            <executions>
-               <execution>
-                  <id>regex-property</id>
-                  <goals>
-                     <goal>regex-property</goal>
-                  </goals>
-                  <configuration>
-                     <name>rm.module.version</name>
-                     <value>${project.version}</value>
-                     <regex>([0-9\.]*[0-9]).*</regex>
-                     <replacement>$1</replacement>
-                     <failIfNoMatch>true</failIfNoMatch>
-                  </configuration>
-               </execution>
-               <execution>
-                  <id>add-test-source</id>
-                  <goals>
-                     <goal>add-test-source</goal>
-                  </goals>
-                  <configuration>
-                     <sources>
-                        <source>unit-test/java</source>
-                     </sources>
-                  </configuration>
-               </execution>
-            </executions>
-         </plugin>
          <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-enforcer-plugin</artifactId>

From d9251cb8666c0ff0dfe79604393314948395d389 Mon Sep 17 00:00:00 2001
From: Mihai Cozma <mihai.cozma@savatech.ro>
Date: Mon, 17 Oct 2016 13:45:25 +0300
Subject: [PATCH 5/6] Fix resource filtering

---
 rm-server/pom.xml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/rm-server/pom.xml b/rm-server/pom.xml
index a4554801db..3f8f1443f7 100644
--- a/rm-server/pom.xml
+++ b/rm-server/pom.xml
@@ -19,7 +19,13 @@
       <resources>
          <resource>
             <directory>config</directory>
-             <filtering>true</filtering>
+            <filtering>true</filtering>
+             <includes>
+                <include>**/module.properties</include>
+             </includes>
+         </resource>
+         <resource>
+            <directory>config</directory>
          </resource>
       </resources>
       <testResources>

From 480718fe24b6e5af12b337ea737b69a4f1eb5a1c Mon Sep 17 00:00:00 2001
From: Mihai Cozma <mihai.cozma@savatech.ro>
Date: Wed, 19 Oct 2016 08:58:32 +0300
Subject: [PATCH 6/6] Fix version with more digits. modified:   pom.xml

---
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 293caa8b57..ece5c12dca 100644
--- a/pom.xml
+++ b/pom.xml
@@ -134,8 +134,8 @@
                         <regexPropertySetting>
                            <name>rm.module.repo.version.min</name>
                            <value>${alfresco.version}</value>
-                           <regex>(\d+)\.(\d+).*</regex>
-                           <replacement>$1.$2</replacement>
+                           <regex>([0-9\.]*[0-9]).*</regex>
+                           <replacement>$1</replacement>
                            <failIfNoMatch>false</failIfNoMatch>
                         </regexPropertySetting>
                         <regexPropertySetting>