Fixed ALF-10280: Slow to report « Duplicate entry » in database.

- DuplicateChildNodeNameException implements DoNotRetryException
 - Must be merged back to V3.4


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@30468 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/repo/transaction/DoNotRetryException.java

@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2005-2010 Alfresco Software Limited.
+ *
+ * This file is part of Alfresco
+ *
+ * Alfresco is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Alfresco is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
+ */
+package org.alfresco.repo.transaction;
+
+/**
+ * Marker interface for the exceptions that should not trigger retries, regardless of
+ * the contained causal exceptions.
+ * 
+ * @author Derek Hulley
+ * @since 3.4.6
+ */
+public interface DoNotRetryException
+{
+}

source/java/org/alfresco/repo/transaction/RetryingTransactionHelper.java

@@ -541,7 +541,8 @@ public class RetryingTransactionHelper
     }
 
     /**
-     * Sometimes, the exception means retry and sometimes not.
+     * Sometimes, the exception means retry and sometimes not.  The stack of exceptions is also checked
+     * for any occurence of {@link DoNotRetryException} and, if found, nothing is returned.
      *
      * @param cause     the cause to examine
      * @return          Returns the original cause if it is a valid retry cause, otherwise <tt>null</tt>
@@ -554,6 +555,11 @@ public class RetryingTransactionHelper
         {
             return null;
         }
+        else if (ExceptionStackUtil.getCause(cause, DoNotRetryException.class) != null)
+        {
+            // Someone decided that the txn should NOT retry
+            return null;
+        }
         else if (retryCause instanceof SQLGrammarException
                 && ((SQLGrammarException) retryCause).getErrorCode() != 3960)
         {