Fixed ALF-10280: Slow to report « Duplicate entry » in database.

- DuplicateChildNodeNameException implements DoNotRetryException
 - Must be merged back to V3.4


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@30468 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/repo/transaction/RetryingTransactionHelper.java

@@ -541,7 +541,8 @@ public class RetryingTransactionHelper
     }
 
     /**
-     * Sometimes, the exception means retry and sometimes not.
+     * Sometimes, the exception means retry and sometimes not.  The stack of exceptions is also checked
+     * for any occurence of {@link DoNotRetryException} and, if found, nothing is returned.
      *
      * @param cause     the cause to examine
      * @return          Returns the original cause if it is a valid retry cause, otherwise <tt>null</tt>
@@ -554,6 +555,11 @@ public class RetryingTransactionHelper
         {
             return null;
         }
+        else if (ExceptionStackUtil.getCause(cause, DoNotRetryException.class) != null)
+        {
+            // Someone decided that the txn should NOT retry
+            return null;
+        }
         else if (retryCause instanceof SQLGrammarException
                 && ((SQLGrammarException) retryCause).getErrorCode() != 3960)
         {