From e83f5f2bd0a31cbaff23f6989f7f8d17e2ccf5b1 Mon Sep 17 00:00:00 2001
From: Nick Burch <nick.burch@quanticate.com>
Date: Tue, 7 Sep 2010 11:53:21 +0000
Subject: [PATCH] Add commented out unit test for ALF-4610, to show that we can
 cope with replication definitions with funny characters in the name Unit test
 is disabled for now, as it triggers a springsurf webscript bug...

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@22293 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../replication/ReplicationRestApiTest.java   | 84 +++++++++++++++++++
 1 file changed, 84 insertions(+)

diff --git a/source/java/org/alfresco/repo/web/scripts/replication/ReplicationRestApiTest.java b/source/java/org/alfresco/repo/web/scripts/replication/ReplicationRestApiTest.java
index 9206cee128..d3479b19be 100644
--- a/source/java/org/alfresco/repo/web/scripts/replication/ReplicationRestApiTest.java
+++ b/source/java/org/alfresco/repo/web/scripts/replication/ReplicationRestApiTest.java
@@ -40,6 +40,7 @@ import org.alfresco.util.ISO8601DateFormat;
 import org.json.JSONArray;
 import org.json.JSONObject;
 import org.springframework.context.ApplicationContext;
+import org.springframework.extensions.surf.util.URLEncoder;
 import org.springframework.extensions.webscripts.Status;
 import org.springframework.extensions.webscripts.TestWebScriptServer.GetRequest;
 import org.springframework.extensions.webscripts.TestWebScriptServer.PostRequest;
@@ -1390,6 +1391,89 @@ public class ReplicationRestApiTest extends BaseWebScriptTest
        assertNull(replicationService.loadReplicationDefinition("Test 3"));
     }
     
+    /**
+     * Test that when creating and working with replication
+     *  definitions with a name that includes "nasty"
+     *  characters, things still work.
+     * Related to ALF-4610.
+     * TEST DISABLED - Spring Surf bug... 
+     *  Caused by: java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "^&"
+     */
+    public void DISABLEDtestReplicationDefinitionsNastyNames() throws Exception
+    {
+       AuthenticationUtil.setFullyAuthenticatedUser(AuthenticationUtil.getAdminUserName());
+       Response response;
+       String jsonStr;
+       
+       String nastyName = "~!@#$%^&()_+-={}[];";
+       String nastyNameURL = URLEncoder.encodeUriComponent(nastyName);
+       
+       
+       // Create
+       JSONObject json = new JSONObject();
+       json.put("name", nastyName);
+       json.put("description", "Nasty Characters");
+       response = sendRequest(new PostRequest(URL_DEFINITIONS, json.toString(), JSON), Status.STATUS_OK);
+       assertEquals(Status.STATUS_OK, response.getStatus());
+       
+       jsonStr = response.getContentAsString();
+       json = new JSONObject(jsonStr).getJSONObject("data");
+       assertNotNull(json);
+       
+       assertEquals(nastyName, json.get("name"));
+       assertEquals("Nasty Characters", json.get("description"));
+       assertEquals("New", json.get("status"));
+       assertEquals(JSONObject.NULL, json.get("startedAt"));
+       assertEquals(JSONObject.NULL, json.get("endedAt"));
+       assertEquals(JSONObject.NULL, json.get("failureMessage"));
+       assertEquals(JSONObject.NULL, json.get("executionDetails"));
+       assertEquals(JSONObject.NULL, json.get("transferLocalReport"));
+       assertEquals(JSONObject.NULL, json.get("transferRemoteReport"));
+       assertEquals(true, json.get("enabled"));
+       assertEquals(JSONObject.NULL, json.get("targetName"));
+       assertEquals(0, json.getJSONArray("payload").length());
+       
+       
+       // Check it turned up
+       assertEquals(1, replicationService.loadReplicationDefinitions().size());
+       assertEquals(nastyName, replicationService.loadReplicationDefinitions().get(0).getReplicationName());
+       
+       
+       // Fetch the details
+       response = sendRequest(new GetRequest(URL_DEFINITION + nastyNameURL), 200);
+       assertEquals(Status.STATUS_OK, response.getStatus());
+       
+       jsonStr = response.getContentAsString();
+       json = new JSONObject(jsonStr).getJSONObject("data");
+       assertNotNull(json);
+       
+       assertEquals(nastyName, json.get("name"));
+       assertEquals("Nasty Characters", json.get("description"));
+       assertEquals("New", json.get("status"));
+       
+       
+       // Delete
+       // Because some of the delete operations happen post-commit, and
+       //  because we don't have real transactions, fake it
+       UserTransaction txn = transactionService.getUserTransaction();
+       txn.begin();
+       
+       // Call the delete webscript
+       response = sendRequest(new DeleteRequest(URL_DEFINITION + nastyNameURL), Status.STATUS_NO_CONTENT);
+       assertEquals(Status.STATUS_NO_CONTENT, response.getStatus());
+       
+       // Let the node service do its work
+       txn.commit();
+       Thread.sleep(50);
+       
+       // Check the details webscript to ensure it went
+       response = sendRequest(new GetRequest(URL_DEFINITION + nastyNameURL), Status.STATUS_NOT_FOUND);
+       assertEquals(Status.STATUS_NOT_FOUND, response.getStatus());
+       
+       // And check the service too
+       assertEquals(0, replicationService.loadReplicationDefinitions().size());
+    }
+    
     
     @Override
     protected void setUp() throws Exception